.rubocop_todo.yml in riiif-1.7.1 vs .rubocop_todo.yml in riiif-2.0.0.beta1
- old
+ new
@@ -1,35 +1,20 @@
# This configuration was generated by
# `rubocop --auto-gen-config`
-# on 2018-05-14 11:34:53 -0500 using RuboCop version 0.47.1.
+# on 2017-04-11 15:07:00 -0500 using RuboCop version 0.47.1.
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
# versions of RuboCop, may require this file to be generated again.
-# Offense count: 2
-# Configuration parameters: Include.
-# Include: **/Gemfile, **/gems.rb
-Bundler/DuplicatedGem:
- Exclude:
- - 'Gemfile'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: Include.
-# Include: **/Gemfile, **/gems.rb
-Bundler/OrderedGems:
- Exclude:
- - 'Gemfile'
-
# Offense count: 9
# Configuration parameters: AllowSafeAssignment.
Lint/AssignmentInCondition:
Exclude:
- 'app/models/riiif/file.rb'
- 'app/services/riiif/option_decoder.rb'
- - 'lib/riiif/http_file_resolver.rb'
+ - 'app/resolvers/riiif/http_file_resolver.rb'
# Offense count: 1
Lint/HandleExceptions:
Exclude:
- 'spec/models/riiif/http_file_resolver_spec.rb'
@@ -37,63 +22,52 @@
# Offense count: 1
Lint/UselessAssignment:
Exclude:
- 'app/models/riiif/file.rb'
-# Offense count: 6
+# Offense count: 5
Metrics/AbcSize:
Max: 29
# Offense count: 1
Metrics/CyclomaticComplexity:
Max: 8
-# Offense count: 103
+# Offense count: 96
# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
# URISchemes: http, https
Metrics/LineLength:
- Max: 153
+ Max: 117
# Offense count: 6
# Configuration parameters: CountComments.
Metrics/MethodLength:
Max: 18
+Metrics/ParameterLists:
+ Exclude:
+ - 'app/services/riiif/imagemagick_command_factory.rb'
+
# Offense count: 1
# Configuration parameters: EnforcedStyle, SupportedStyles.
# SupportedStyles: nested, compact
Style/ClassAndModuleChildren:
Exclude:
- 'lib/riiif/rails/routes.rb'
-# Offense count: 13
+# Offense count: 14
Style/Documentation:
Exclude:
- 'spec/**/*'
- 'test/**/*'
- 'app/controllers/riiif/images_controller.rb'
- 'app/models/riiif/file.rb'
- 'app/models/riiif/image.rb'
+ - 'app/resolvers/riiif/abstract_file_system_resolver.rb'
+ - 'app/resolvers/riiif/akubra_system_file_resolver.rb'
+ - 'app/resolvers/riiif/file_system_file_resolver.rb'
+ - 'app/resolvers/riiif/http_file_resolver.rb'
+ - 'app/services/riiif/nil_authorization_service.rb'
- 'lib/riiif.rb'
- - 'lib/riiif/abstract_file_system_resolver.rb'
- - 'lib/riiif/akubra_system_file_resolver.rb'
- 'lib/riiif/engine.rb'
- - 'lib/riiif/file_system_file_resolver.rb'
- - 'lib/riiif/http_file_resolver.rb'
- - 'lib/riiif/nil_authorization_service.rb'
- 'lib/riiif/rails/routes.rb'
- 'lib/riiif/routes.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: AllowForAlignment.
-Style/SpaceAroundOperators:
- Exclude:
- - 'Gemfile'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles, ConsistentQuotesInMultiline.
-# SupportedStyles: single_quotes, double_quotes
-Style/StringLiterals:
- Exclude:
- - 'Gemfile'