spec/reviewlette_spec.rb in reviewlette-0.0.8 vs spec/reviewlette_spec.rb in reviewlette-0.0.9

@@ -1,71 +1,85 @@
 require 'spec_helper'
 
 describe Reviewlette do
-
   subject { Reviewlette }
-  let( :reviewlette ) { subject.new }
 
-  before {
-    allow(GithubConnection).to receive(:new).and_return GithubConnection
-    allow(TrelloConnection).to receive(:new).and_return TrelloConnection
-  }
+  let(:reviewlette)    { subject.new }
 
+  let(:members_config) { { 'members' => [member1, member2] } }
+  let(:member1)        { { 'name' => 'test1',  'suse_username' => 'test1', 'trello_username' => 'trellotest1' } }
+  let(:member2)        { { 'name' => 'test2', 'suse_username' => 'test2', 'trello_username' => 'trellotest2' } }
 
+  let(:github_config)  { { token: token, repos: [repo, repo2] } }
+  let(:token)          { '1234' }
+  let(:repo)           { 'SUSE/test' }
+  let(:repo2)          { 'SUSE/foo' }
+
+  before do
+    allow(TrelloConnection).to receive(:new).and_return TrelloConnection
+    allow(GithubConnection).to receive(:new).with(repo, token).and_return GithubConnection
+    allow(YAML).to receive(:load_file).with(/github\.yml/).and_return github_config
+    allow(YAML).to receive(:load_file).with(/members\.yml/).and_return members_config
+  end
+
   describe '.new' do
-    it 'sets github and trello connections' do
-       expect(GithubConnection).to receive (:new)
-       expect(TrelloConnection).to receive (:new)
-       subject.new
+    it 'sets trello connections' do
+      expect(TrelloConnection).to receive(:new)
+      subject.new
     end
   end
 
   describe '.run' do
+    it 'iterates over all open repositories and looks for unassigned pull requests' do
+      github_config[:repos].each do |r|
+        expect(reviewlette).to receive(:check_repo).with(r, token)
+        reviewlette.check_repo(r, token)
+      end
+    end
+  end
 
+  describe '.check_repo' do
     it 'iterates over all open pull requests and extracts trello ids from name' do
+      expect(GithubConnection).to receive(:repo_exists?).and_return true
       expect(GithubConnection).to receive(:unassigned_pull_requests).and_return([{number: 11, title: 'test_issue_12'}])
       expect(TrelloConnection).to receive(:find_card_by_id).with(12)
 
-      reviewlette.run
+      reviewlette.check_repo(repo, token)
     end
 
     it 'adds assignee and reviewer comment on github, adds comment on trello and moves card' do
       card = Trello::Card.new
+
+      expect(GithubConnection).to receive(:repo_exists?).and_return true
       expect(GithubConnection).to receive(:unassigned_pull_requests).and_return([{number: 11, title: 'test_issue_12'}])
       expect(TrelloConnection).to receive(:find_card_by_id).with(12).and_return(card)
       expect(reviewlette).to receive(:select_reviewer).and_return({'suse_username' => 'test', 'github_username' => 'testgit'})
 
       expect(GithubConnection).to receive(:add_assignee).with(11, 'testgit')
       expect(GithubConnection).to receive(:reviewer_comment).with(11, 'testgit', card)
-      expect(GithubConnection).to receive(:repo).and_return('SUSE/test')
 
       expect(TrelloConnection).to receive(:comment_on_card).with("@ will review https://github.com/SUSE/test/issues/11", card)
       expect(TrelloConnection).to receive(:move_card_to_list).with(card, 'In review')
 
-      reviewlette.run
+      reviewlette.check_repo(repo, token)
     end
 
   end
 
   describe '.select_reviewer' do
-
-    MEMBERS_CONFIG['members'] = [{'suse_username' => 'test1', 'trello_username' => 'trellotest1'},
-                                 {'suse_username' => 'test2', 'trello_username' => 'trellotest2'}]
-
     it 'excludes members on vacation' do
-      card = Trello::Card.new
+      card       = Trello::Card.new
+
       allow(card).to receive(:members).and_return([])
-      expect(Vacations).to receive(:members_on_vacation).and_return(MEMBERS_CONFIG['members'].first['suse_username'])
-      expect(reviewlette.select_reviewer(nil, card)).to eq(MEMBERS_CONFIG['members'].last)
+      expect(Vacations).to receive(:members_on_vacation).and_return([member1['suse_username']])
+      expect(reviewlette.select_reviewer(nil, card)).to eq(member2)
     end
 
     it 'excludes the owner of the trello card' do
       card = Trello::Card.new
+
       allow(card).to receive_message_chain(:members, :map).and_return(['trellotest1'])
       expect(Vacations).to receive(:members_on_vacation).and_return([])
-      expect(reviewlette.select_reviewer(nil, card)).to eq(MEMBERS_CONFIG['members'].last)
+      expect(reviewlette.select_reviewer(nil, card)).to eq(members_config['members'].last)
     end
-
   end
-
-
 end