lib/reviewer/command.rb in reviewer-0.1.4 vs lib/reviewer/command.rb in reviewer-0.1.5

@@ -1,60 +1,39 @@
 # frozen_string_literal: true
 
 require_relative 'command/string'
-require_relative 'command/verbosity'
 
 module Reviewer
   # The core funtionality to translate a tool, command type, and verbosity into a runnable command
   class Command
     include Conversions
 
     SEED_SUBSTITUTION_VALUE = '$SEED'
 
-    attr_reader :tool, :type
+    attr_reader :tool
 
+    attr_accessor :type
+
     # Creates an instance of the Command class to synthesize a command string using the tool,
     # command type, and verbosity.
     # @param tool [Tool, Symbol] a tool or tool key to use to look up the command and options
     # @param type [Symbol] the desired command type (:install, :prepare, :review, :format)
-    # @param verbosity = Verbosity::TOTAL_SILENCE [Symbol] the desired verbosity for the command
     #
     # @return [Command] the intersection of a tool, command type, and verbosity
-    def initialize(tool, type, verbosity = Verbosity::TOTAL_SILENCE)
+    def initialize(tool, type)
       @tool = Tool(tool)
       @type = type.to_sym
-      @verbosity = Verbosity(verbosity)
     end
 
     # The final command string with all of the conditions appled
     #
     # @return [String] the final, valid command string to run
     def string
       @string ||= seed_substitution? ? seeded_string : raw_string
     end
     alias to_s string
 
-    # Getter for @verbosity. Since the setter is custom, the getter needs to be explicitly declared.
-    # Otherwise, using `attr_accessor` and then overriding the setter muddies the waters.
-    #
-    # @return [Verbosity] the current verbosity setting for the command
-    def verbosity # rubocop:disable Style/TrivialAccessors
-      @verbosity
-    end
-
-    # Override verbosity assignment to clear the related memoized values when verbosity changes
-    # @param verbosity [Verbosity, Symbol] the desired verbosity for the command
-    #
-    # @return [Verbosity] the updated verbosity level for the command
-    def verbosity=(verbosity)
-      # Unmemoize string since the verbosity has been changed
-      @raw_string = nil
-      @string = nil
-
-      @verbosity = Verbosity(verbosity)
-    end
-
     # Generates a seed that can be re-used across runs so that the results are consistent across
     # related runs for tools that would otherwise change the seed automatically every run.
     # Since not all tools will use the seed, there's no need to generate it in the initializer.
     # Instead, it's memoized if it's used.
     #
@@ -66,22 +45,18 @@
       Reviewer.history.set(tool.key, :last_seed, @seed)
 
       @seed
     end
 
-    private
-
     # The raw command string before any substitutions. For example, since seeds need to remain
     # consistent from one run to the next, they're
     #
     # @return [type] [description]
     def raw_string
-      @raw_string ||= String.new(
-        type,
-        tool_settings: tool.settings,
-        verbosity: verbosity
-      ).to_s
+      @raw_string ||= String.new(type, tool_settings: tool.settings).to_s
     end
+
+    private
 
     # The version of the command with the SEED_SUBSTITUTION_VALUE replaced
     #
     # @return [String] the command string with the SEED_SUBSTITUTION_VALUE replaced
     def seeded_string