test/test_image_finder.rb in review-4.0.0 vs test/test_image_finder.rb in review-4.1.0

@@ -5,95 +5,77 @@
 
 class ImageFinderTest < Test::Unit::TestCase
   include ReVIEW
 
   def setup
+    if ENV['GITHUB_WORKSPACE']
+      ENV['TMPDIR'] = File.join(ENV['GITHUB_WORKSPACE'], 'tmp_review')
+      FileUtils.mkdir_p(ENV['TMPDIR'])
+    end
+    @dir = Dir.mktmpdir
   end
 
+  def teardown
+    if @dir
+      FileUtils.remove_entry_secure(@dir)
+    end
+  end
+
   def test_find_path_pattern1
-    dir = Dir.mktmpdir
-    begin
-      path = File.join(dir, 'builder/ch01/foo.jpg')
-      FileUtils.mkdir_p(File.dirname(path))
-      FileUtils.touch(path)
+    path = File.join(@dir, 'builder/ch01/foo.jpg')
+    FileUtils.mkdir_p(File.dirname(path))
+    FileUtils.touch(path)
 
-      finder = ReVIEW::Book::ImageFinder.new(dir, 'ch01', 'builder', ['.jpg'])
-      assert_equal(path, finder.find_path('foo'))
-    ensure
-      FileUtils.remove_entry_secure(dir)
-    end
+    finder = ReVIEW::Book::ImageFinder.new(@dir, 'ch01', 'builder', ['.jpg'])
+
+    assert_equal(path, finder.find_path('foo'))
   end
 
   def test_find_path_pattern2
-    dir = Dir.mktmpdir
-    begin
-      path = File.join(dir, 'builder/ch01-foo.jpg')
-      FileUtils.mkdir_p(File.dirname(path))
-      FileUtils.touch(path)
+    path = File.join(@dir, 'builder/ch01-foo.jpg')
+    FileUtils.mkdir_p(File.dirname(path))
+    FileUtils.touch(path)
 
-      finder = ReVIEW::Book::ImageFinder.new(dir, 'ch01', 'builder', ['.jpg'])
-      assert_equal(path, finder.find_path('foo'))
-    ensure
-      FileUtils.remove_entry_secure(dir)
-    end
+    finder = ReVIEW::Book::ImageFinder.new(@dir, 'ch01', 'builder', ['.jpg'])
+    assert_equal(path, finder.find_path('foo'))
   end
 
   def test_find_path_pattern3
-    dir = Dir.mktmpdir
-    begin
-      path = File.join(dir, 'builder/foo.jpg')
-      FileUtils.mkdir_p(File.dirname(path))
-      FileUtils.touch(path)
+    path = File.join(@dir, 'builder/foo.jpg')
+    FileUtils.mkdir_p(File.dirname(path))
+    FileUtils.touch(path)
 
-      finder = ReVIEW::Book::ImageFinder.new(dir, 'ch01', 'builder', ['.jpg'])
-      assert_equal(path, finder.find_path('foo'))
-    ensure
-      FileUtils.remove_entry_secure(dir)
-    end
+    finder = ReVIEW::Book::ImageFinder.new(@dir, 'ch01', 'builder', ['.jpg'])
+    assert_equal(path, finder.find_path('foo'))
   end
 
   def test_find_path_pattern4
-    dir = Dir.mktmpdir
-    begin
-      path = File.join(dir, 'ch01/foo.jpg')
-      FileUtils.mkdir_p(File.dirname(path))
-      FileUtils.touch(path)
+    path = File.join(@dir, 'ch01/foo.jpg')
+    FileUtils.mkdir_p(File.dirname(path))
+    FileUtils.touch(path)
 
-      finder = ReVIEW::Book::ImageFinder.new(dir, 'ch01', 'builder', ['.jpg'])
-      assert_equal(path, finder.find_path('foo'))
-    ensure
-      FileUtils.remove_entry_secure(dir)
-    end
+    finder = ReVIEW::Book::ImageFinder.new(@dir, 'ch01', 'builder', ['.jpg'])
+    assert_equal(path, finder.find_path('foo'))
   end
 
   def test_find_path_pattern5
-    dir = Dir.mktmpdir
-    begin
-      path = File.join(dir, 'ch01-foo.jpg')
-      FileUtils.mkdir_p(File.dirname(path))
-      FileUtils.touch(path)
+    path = File.join(@dir, 'ch01-foo.jpg')
+    FileUtils.mkdir_p(File.dirname(path))
+    FileUtils.touch(path)
 
-      finder = ReVIEW::Book::ImageFinder.new(dir, 'ch01', 'builder', ['.jpg'])
-      assert_equal(path, finder.find_path('foo'))
-    ensure
-      FileUtils.remove_entry_secure(dir)
-    end
+    finder = ReVIEW::Book::ImageFinder.new(@dir, 'ch01', 'builder', ['.jpg'])
+    assert_equal(path, finder.find_path('foo'))
   end
 
   def test_find_path_dir_symlink
-    dir = Dir.mktmpdir
-    begin
-      path_src = File.join(dir, 'src')
-      path_dst = File.join(dir, 'ch01')
-      FileUtils.mkdir_p(path_src)
-      FileUtils.symlink(path_src, path_dst)
-      path_srcimg = File.join(path_src, 'foo.jpg')
-      path_dstimg = File.join(path_dst, 'foo.jpg')
-      FileUtils.touch(path_srcimg)
+    path_src = File.join(@dir, 'src')
+    path_dst = File.join(@dir, 'ch01')
+    FileUtils.mkdir_p(path_src)
+    FileUtils.symlink(path_src, path_dst)
+    path_srcimg = File.join(path_src, 'foo.jpg')
+    path_dstimg = File.join(path_dst, 'foo.jpg')
+    FileUtils.touch(path_srcimg)
 
-      finder = ReVIEW::Book::ImageFinder.new(dir, 'ch01', 'builder', ['.jpg'])
-      assert_equal(path_dstimg, finder.find_path('foo'))
-    ensure
-      FileUtils.remove_entry_secure(dir)
-    end
+    finder = ReVIEW::Book::ImageFinder.new(@dir, 'ch01', 'builder', ['.jpg'])
+    assert_equal(path_dstimg, finder.find_path('foo'))
   end
 end