dump_index_spec.rb in resync-client-0.3.0

- old
+ new

@@ -49,14 +49,18 @@
             index.all_zip_packages
           end
 
           it 'is lazy enough not to download resources it doesn\'t need' do
             resources = Array.new(3) { instance_double(ZippedResource) }
-            resources.each do |r|
+            zip_packages = Array.new(3) { instance_double(Zip::ZipPackage) }
+            resources.each_with_index do |r, i|
               allow(r).to receive(:client_delegate=)
-              zip_package = instance_double(Zip::ZipPackage)
-              expect(r).to receive(:zip_package).once.and_return(zip_package)
+              if i <= 1
+                expect(r).to receive(:zip_package).once.and_return(zip_packages[i])
+              else
+                expect(r).not_to receive(:zip_package)
+              end
             end
 
             dump1 = ResourceDump.new(resources: resources[0, 3])
 
             dump1_resource = instance_double(Resource)
@@ -66,40 +70,12 @@
             dump2_resource = instance_double(Resource)
             allow(dump2_resource).to receive(:client_delegate=)
             expect(dump2_resource).not_to receive(:get_and_parse)
 
             index = ResourceDumpIndex.new(resources: [dump1_resource, dump2_resource])
-            index.all_zip_packages.each_with_index do |_, i|
-              break if i >= 2
-            end
-          end
-
-          it 'caches downloaded resources' do
-            resources = Array.new(6) { instance_double(ZippedResource) }
-            resources.each do |r|
-              allow(r).to receive(:client_delegate=)
-              zip_package = instance_double(Zip::ZipPackage)
-              expect(r).to receive(:zip_package).once.and_return(zip_package)
-            end
-
-            dump1 = ResourceDump.new(resources: resources[0, 3])
-            dump2 = ResourceDump.new(resources: resources[3, 3])
-
-            dump1_resource = instance_double(Resource)
-            allow(dump1_resource).to receive(:client_delegate=)
-            expect(dump1_resource).to receive(:get_and_parse).once.and_return(dump1)
-
-            dump2_resource = instance_double(Resource)
-            allow(dump2_resource).to receive(:client_delegate=)
-            expect(dump2_resource).to receive(:get_and_parse).once.and_return(dump2)
-
-            index = ResourceDumpIndex.new(resources: [dump1_resource, dump2_resource])
-            all_packages = index.all_zip_packages
-
-            a1 = all_packages.to_a
-            a2 = all_packages.to_a
-            a1.each_with_index do |pkg, i|
-              expect(pkg).to be(a2[i])
+            index.all_zip_packages.each_with_index do |zp, i|
+              expect(zp).to be(zip_packages[i])
+              break if i >= 1
             end
           end
         end
       end
     end