.rubocop.yml in remocon-0.1.0 vs .rubocop.yml in remocon-0.2.0

- old
+ new

@@ -1,70 +1,178 @@ +# Defaults can be found here: https://github.com/bbatsov/rubocop/blob/master/config/default.yml + +# If you don't like these settings, just delete this file :) + AllCops: Exclude: - - '*.gemspec' - 'vendor/**/*' - - 'Gemfile' - - 'Rakefile' + - 'spec/fixtures/**/*' + - 'tmp/**/*' + TargetRubyVersion: 2.3.7 -Style/Documentation: +Metrics/ModuleLength: Exclude: - 'spec/**/*' - - 'test/**/*' + Enabled: true -Metrics/LineLength: - Max: 150 +Style/StringLiterals: + EnforcedStyle: double_quotes + Enabled: true + +# kind_of? is a good way to check a type +Style/ClassCheck: + EnforcedStyle: kind_of? + +# It's better to be more explicit about the type +Style/BracesAroundHashParameters: + Enabled: false + +# specs sometimes have useless assignments, which is fine +Lint/UselessAssignment: Exclude: - - "spec/**/*" + - '**/spec/**/*' +# We could potentially enable the 2 below: +Layout/IndentHash: + Enabled: false + +Layout/AlignHash: + Enabled: false + +# HoundCI doesn't like this rule +Layout/DotPosition: + Enabled: false + +# We allow !! as it's an easy way to convert ot boolean +Style/DoubleNegation: + Enabled: false + +# Cop supports --auto-correct. +Lint/UnusedBlockArgument: + Enabled: false + +# We want to allow class Fastlane::Class +Style/ClassAndModuleChildren: + Enabled: false + Metrics/AbcSize: + Max: 60 + +# The %w might be confusing for new users +Style/WordArray: + MinSize: 19 + +# raise and fail are both okay +Style/SignalException: Enabled: false -Metrics/ClassLength: +# Better too much 'return' than one missing +Style/RedundantReturn: Enabled: false -Metrics/CyclomaticComplexity: +# Having if in the same line might not always be good +Style/IfUnlessModifier: Enabled: false -Metrics/MethodLength: +# and and or is okay +Style/AndOr: Enabled: false -Metrics/ModuleLength: +# Configuration parameters: CountComments. +Metrics/ClassLength: + Max: 350 + +Metrics/CyclomaticComplexity: + Max: 17 + +# Configuration parameters: AllowURI, URISchemes. +Metrics/LineLength: + Max: 370 + +# Configuration parameters: CountKeywordArgs. +Metrics/ParameterLists: + Max: 10 + +Metrics/PerceivedComplexity: + Max: 18 + +# Sometimes it's easier to read without guards +Style/GuardClause: Enabled: false -Style/BracesAroundHashParameters: +# something = if something_else +# that's confusing +Style/ConditionalAssignment: Enabled: false +# Better to have too much self than missing a self +Style/RedundantSelf: + Enabled: false + +Metrics/MethodLength: + Max: 60 + +# We're not there yet Style/Documentation: Enabled: false -Style/EachWithObject: +# Adds complexity +Style/IfInsideElse: Enabled: false -Style/LineEndConcatenation: +# danger specific + +Style/BlockComments: Enabled: false -Style/MutableConstant: +Layout/MultilineMethodCallIndentation: + EnforcedStyle: indented + +# FIXME: 25 +Metrics/BlockLength: + Max: 345 + Exclude: + - "**/*_spec.rb" + +Style/MixinGrouping: Enabled: false -Style/NumericLiterals: +Style/FileName: Enabled: false -Style/ParallelAssignment: +Layout/IndentHeredoc: Enabled: false -Style/RedundantSelf: +Style/SpecialGlobalVars: Enabled: false -Style/RegexpLiteral: - Enabled: true +PercentLiteralDelimiters: + PreferredDelimiters: + "%": () + "%i": () + "%q": () + "%Q": () + "%r": "{}" + "%s": () + "%w": () + "%W": () + "%x": () -Style/StringLiterals: +Security/YAMLLoad: Enabled: false -Style/SymbolProc: +Style/TrailingCommaInArguments: + Enabled: true + +Style/TrailingCommaInArrayLiteral: Enabled: false -Style/UnneededPercentQ: +Style/TrailingCommaInHashLiteral: Enabled: false -Style/PerlBackrefs: +Naming/HeredocDelimiterNaming: + Exclude: + - 'vendor/**/*' + - 'spec/**/*' + +Security/Open: Enabled: false \ No newline at end of file