spec/reek/smells/repeated_conditional_spec.rb in reek-2.0.0 vs spec/reek/smells/repeated_conditional_spec.rb in reek-2.0.1

@@ -1,68 +1,65 @@
 require 'spec_helper'
 require 'reek/smells/repeated_conditional'
 require 'reek/core/code_context'
 require 'reek/smells/smell_detector_shared'
 
-include Reek::Core
-include Reek::Smells
-
-describe RepeatedConditional do
-  before :each do
-    @source_name = 'howdy-doody'
-    @detector = RepeatedConditional.new(@source_name)
+describe Reek::Smells::RepeatedConditional do
+  before(:each) do
+    @source_name = 'dummy_source'
+    @detector = build(:smell_detector, smell_type: :RepeatedConditional, source: @source_name)
   end
 
   it_should_behave_like 'SmellDetector'
 
   context 'with no conditionals' do
     it 'gathers an empty hash' do
       ast = 'module Stable; end'.to_reek_source.syntax_tree
-      ctx = CodeContext.new(nil, ast)
+      ctx = Reek::Core::CodeContext.new(nil, ast)
       expect(@detector.conditional_counts(ctx).length).to eq(0)
     end
   end
 
   context 'with a test of block_given?' do
     it 'does not record the condition' do
       ast = 'def fred() yield(3) if block_given?; end'.to_reek_source.syntax_tree
-      ctx = CodeContext.new(nil, ast)
+      ctx = Reek::Core::CodeContext.new(nil, ast)
       expect(@detector.conditional_counts(ctx).length).to eq(0)
     end
   end
 
   context 'with an empty condition' do
     it 'does not record the condition' do
       ast = 'def fred() case; when 3; end; end'.to_reek_source.syntax_tree
-      ctx = CodeContext.new(nil, ast)
+      ctx = Reek::Core::CodeContext.new(nil, ast)
       expect(@detector.conditional_counts(ctx).length).to eq(0)
     end
   end
 
   context 'with three identical conditionals' do
     before :each do
       @cond = '@field == :sym'
       @cond_expr = @cond.to_reek_source.syntax_tree
-      src = <<EOS
-class Scrunch
-  def first
-    puts "hello" if @debug
-    return #{@cond} ? 0 : 3;
-  end
-  def second
-    if #{@cond}
-      @other += " quarts"
-    end
-  end
-  def third
-    raise 'flu!' unless #{@cond}
-  end
-end
-EOS
+      src = <<-EOS
+        class Scrunch
+          def first
+            puts "hello" if @debug
+            return #{@cond} ? 0 : 3;
+          end
+          def second
+            if #{@cond}
+              @other += " quarts"
+            end
+          end
+          def third
+            raise 'flu!' unless #{@cond}
+          end
+        end
+      EOS
 
       ast = src.to_reek_source.syntax_tree
-      @ctx = CodeContext.new(nil, ast)
+      @ctx = Reek::Core::CodeContext.new(nil, ast)
       @conds = @detector.conditional_counts(@ctx)
     end
 
     it 'finds both conditionals' do
       expect(@conds.length).to eq(2)
@@ -79,36 +76,37 @@
 
   context 'with a matching if and case' do
     before :each do
       cond = '@field == :sym'
       @cond_expr = cond.to_reek_source.syntax_tree
-      src = <<EOS
-class Scrunch
-  def alpha
-    return #{cond} ? 0 : 2;
-  end
-  def beta
-    case #{cond}
-    when :symbol
-      @tother += " pints"
-    end
-  end
-end
-EOS
+      src = <<-EOS
+        class Scrunch
+          def alpha
+            return #{cond} ? 0 : 2;
+          end
+          def beta
+            case #{cond}
+            when :symbol
+              @tother += " pints"
+            end
+          end
+        end
+      EOS
 
       ast = src.to_reek_source.syntax_tree
-      ctx = CodeContext.new(nil, ast)
+      ctx = Reek::Core::CodeContext.new(nil, ast)
       @conds = @detector.conditional_counts(ctx)
     end
+
     it 'finds exactly one conditional' do
       expect(@conds.length).to eq(1)
     end
+
     it 'returns the condition expr' do
       expect(@conds.keys[0]).to eq(@cond_expr)
     end
+
     it 'knows there are two copies' do
       expect(@conds.values[0].length).to eq(2)
     end
   end
-
-  # And count code in superclasses, if we have it
 end