spec/reek/smells/data_clump_spec.rb in reek-1.6.6 vs spec/reek/smells/data_clump_spec.rb in reek-2.0.0

- old
+ new

@@ -12,11 +12,11 @@ def first(pa) @field == :sym ? 0 : 3; end def second(pa) @field == :sym; end def third(pa) pa - pb + @fred; end end EOS - expect(src).not_to smell_of(DataClump) + expect(src).not_to reek_of(DataClump) end context 'with 3 identical pairs' do before :each do @module_name = 'Scrunch' @@ -60,50 +60,50 @@ def one(pa, pb) @field == :sym ? 0 : 3; end def two(pb, pa) @field == :sym; end def tri(pa, pb) pa - pb + @fred; end end EOS - expect(src).to smell_of(DataClump, - count: 3, - parameters: ['pa', 'pb']) + expect(src).to reek_of(DataClump, + count: 3, + parameters: ['pa', 'pb']) end it 'reports 3 identical parameter sets' do src = <<EOS #{@context} Scrunch def first(pa, pb, pc) @field == :sym ? 0 : 3; end def second(pa, pb, pc) @field == :sym; end def third(pa, pb, pc) pa - pb + @fred; end end EOS - expect(src).to smell_of(DataClump, - count: 3, - parameters: ['pa', 'pb', 'pc']) + expect(src).to reek_of(DataClump, + count: 3, + parameters: ['pa', 'pb', 'pc']) end it 'reports re-ordered identical parameter sets' do src = <<EOS #{@context} Scrunch def first(pb, pa, pc) @field == :sym ? 0 : 3; end def second(pc, pb, pa) @field == :sym; end def third(pa, pb, pc) pa - pb + @fred; end end EOS - expect(src).to smell_of(DataClump, - count: 3, - parameters: ['pa', 'pb', 'pc']) + expect(src).to reek_of(DataClump, + count: 3, + parameters: ['pa', 'pb', 'pc']) end it 'counts only identical parameter sets' do src = <<EOS #{@context} RedCloth def fa(p1, p2, p3, conten) end def fb(p1, p2, p3, conten) end def fc(name, windowW, windowH) end end EOS - expect(src).not_to smell_of(DataClump) + expect(src).not_to reek_of(DataClump) end it 'gets a real example right' do src = <<EOS #{@context} Inline @@ -112,11 +112,11 @@ def c_singleton (src, options) end def c_raw (src, options) end def c_raw_singleton (src, options) end end EOS - expect(src).to smell_of(DataClump, count: 5) + expect(src).to reek_of(DataClump, count: 5) end it 'correctly checks number of occurences' do src = <<-EOS #{@context} Smelly @@ -125,34 +125,34 @@ def fc(p3, p4, p5) end def fd(p4, p5, p1) end def fe(p5, p1, p2) end end EOS - expect(src).not_to smell_of(DataClump) + expect(src).not_to reek_of(DataClump) end it 'detects clumps smaller than the total number of arguments' do src = <<-EOS #{@context} Smelly def fa(p1, p2, p3) end def fb(p1, p3, p2) end def fc(p4, p1, p2) end end EOS - expect(src).to smell_of(DataClump, - parameters: %w(p1 p2)) + expect(src).to reek_of(DataClump, + parameters: %w(p1 p2)) end it 'ignores anonymous parameters' do src = <<-EOS #{@context} Smelly def fa(p1, p2, *) end def fb(p1, p2, *) end def fc(p1, p2, *) end end EOS - expect(src).to smell_of(DataClump, - parameters: %w(p1 p2)) + expect(src).to reek_of(DataClump, + parameters: %w(p1 p2)) end end describe DataClump do before(:each) do