lib/reek/smells/nil_check.rb in reek-3.3.1 vs lib/reek/smells/nil_check.rb in reek-3.4.0
- old
+ new
@@ -5,11 +5,10 @@
module Smells
# Checking for nil is a special kind of type check, and therefore a case of
# SimulatedPolymorphism.
#
# See {file:docs/Nil-Check.md} for details.
- # @api private
class NilCheck < SmellDetector
def self.smell_category
'SimulatedPolymorphism'
end
@@ -17,13 +16,13 @@
call_node_finder = NodeFinder.new(ctx, :send, NilCallNodeDetector)
case_node_finder = NodeFinder.new(ctx, :when, NilWhenNodeDetector)
smelly_nodes = call_node_finder.smelly_nodes + case_node_finder.smelly_nodes
smelly_nodes.map do |node|
- SmellWarning.new self,
- context: ctx.full_name,
- lines: [node.line],
- message: 'performs a nil-check'
+ smell_warning(
+ context: ctx,
+ lines: [node.line],
+ message: 'performs a nil-check')
end
end
#
# A base class that allows to work on all nodes of a certain type.