spec/client_spec.rb in redis_failover-0.8.9 vs spec/client_spec.rb in redis_failover-0.9.0

@@ -24,11 +24,11 @@
       update_znode_timestamp
     end
   end
 
   describe Client do
-    let(:client) { ClientStub.new(:zkservers => 'localhost:9281') }
+    let(:client) { ClientStub.new(:zkservers => 'localhost:9281', :safe_mode => true) }
 
     describe '#build_clients' do
       it 'properly parses master' do
         client.current_master.to_s.should == 'localhost:6379'
       end
@@ -46,20 +46,34 @@
         end
         client.del('foo')
         called.should be_true
       end
 
-      it 'routes read operations to a slave' do
-        called = false
-        client.current_slaves.first.change_role_to('slave')
-        client.current_slaves.first.define_singleton_method(:get) do |*args|
-          called = true
+      context 'with :master_only false' do
+        it 'routes read operations to a slave' do
+          called = false
+          client.current_slaves.first.change_role_to('slave')
+          client.current_slaves.first.define_singleton_method(:get) do |*args|
+            called = true
+          end
+          client.get('foo')
+          called.should be_true
         end
-        client.get('foo')
-        called.should be_true
       end
 
+      context 'with :master_only true' do
+        it 'routes read operations to master' do
+          client = ClientStub.new(:zkservers => 'localhost:9281', :master_only => true)
+          called = false
+          client.current_master.define_singleton_method(:get) do |*args|
+            called = true
+          end
+          client.get('foo')
+          called.should be_true
+        end
+      end
+
       it 'reconnects when node is unavailable' do
         class << client
           attr_reader :reconnected
           def build_clients
             @reconnected = true
@@ -88,13 +102,24 @@
 
       it 'raises error for unsupported operations' do
         expect { client.select }.to raise_error(UnsupportedOperationError)
       end
 
-      it 'attempts ZK reconnect when no communication from Node Manager within certain time window' do
-        client.instance_variable_set(:@last_znode_timestamp, Time.at(0))
-        client.should_receive(:build_clients)
-        client.del('foo')
+      context 'with :safe_mode enabled' do
+        it 'rebuilds clients when no communication from Node Manager within certain time window' do
+          client.instance_variable_set(:@last_znode_timestamp, Time.at(0))
+          client.should_receive(:build_clients)
+          client.del('foo')
+        end
+      end
+
+      context 'with :safe_mode disabled' do
+        it 'does not rebuild clients when no communication from Node Manager within certain time window' do
+          client = ClientStub.new(:zkservers => 'localhost:9281', :safe_mode => false)
+          client.instance_variable_set(:@last_znode_timestamp, Time.at(0))
+          client.should_not_receive(:build_clients)
+          client.del('foo')
+        end
       end
     end
   end
 end