.rubocop.yml in red_amber-0.3.0 vs .rubocop.yml in red_amber-0.4.0
- old
+ new
@@ -29,20 +29,33 @@
# ===
# To let you know the possibility of refactoring ===
+# Max: 120
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns, IgnoredPatterns.
+# URISchemes: http, https
+Layout/LineLength:
+ Max: 90
+ Exclude:
+ - 'test/**/*'
+
+# EnforcedStyle: aligned
+Layout/MultilineMethodCallIndentation:
+ EnforcedStyle: indented_relative_to_receiver
+
# avoid unused variable asignment
Rubycw/Rubycw:
Exclude:
- 'test/**/*'
# Disabled to define Vector operators
# Offense count: 38
Lint/BinaryOperatorWithIdenticalOperands:
Exclude:
- - 'test/test_vector_function.rb'
+ - 'test/test_vector_binary_element_wise.rb'
# Need for test with empty block
# Offense count: 1
# Configuration parameters: AllowComments, AllowEmptyLambdas.
Lint/EmptyBlock:
@@ -53,19 +66,10 @@
# Offense count: 6
Lint/UselessAssignment:
Exclude:
- 'test/**/*'
-# Max: 120
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns, IgnoredPatterns.
-# URISchemes: http, https
-Layout/LineLength:
- Max: 90
- Exclude:
- - 'test/**/*'
-
# <= 17 satisfactory
# 18..30 unsatisfactory
# > 30 dangerous
# Offense count: 28
# Configuration parameters: AllowedMethods, AllowedPatterns, IgnoredMethods, CountRepeatedAttributes.
@@ -102,27 +106,29 @@
Metrics/ClassLength:
Exclude:
- 'test/**/*'
- 'lib/red_amber/data_frame.rb' # 162
- 'lib/red_amber/group.rb' # 105
+ - 'lib/red_amber/subframes.rb' # 110
- 'lib/red_amber/vector.rb' # 152
# Only for monitoring. I will measure by PerceivedComplexity.
# Max: 7
# Offense count: 16
# Configuration parameters: AllowedMethods, AllowedPatterns, IgnoredMethods.
Metrics/CyclomaticComplexity:
Max: 12
AllowedMethods: [
- 'join', # 14
+ 'split', # 33
'format_table', # 21
+ 'normalize_element', # 17
'slice_by', # 16
+ 'assign_update', # 14
+ 'join', # 14
+ 'parse_range', # 14
'remove', # 14
- 'normalize_element', # 17
'[]', # 13
- 'parse_range', # 14
- 'split', # 33
]
# Max: 10
# Offense count: 34
# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, AllowedMethods, AllowedPatterns, IgnoredMethods.
@@ -132,10 +138,11 @@
'join', # 47
'dataframe_info', # 33
'format_table', # 53
'slice_by', # 38
'assign_update', # 35
+ 'aggregate', # 31
]
# Max: 100
# Offense count: 5
# Configuration parameters: CountComments, CountAsOne.
@@ -161,21 +168,27 @@
# Offense count: 15
# Configuration parameters: AllowedMethods, AllowedPatterns, IgnoredMethods.
Metrics/PerceivedComplexity:
Max: 10
AllowedMethods: [
- 'join', # 14
- 'dataframe_info', # 13
'format_table', # 22
'slice_by', # 20
- 'remove', # 14
- 'drop', # 12
- 'filters', # 11
'normalize_element', # 17
- '[]', # 11
+ 'assign_update', # 15
'parse_range', # 15
+ 'join', # 14
+ 'remove', # 14
'split', # 14
+ 'dataframe_info', # 13
+ 'replace', # 13
+ 'drop', # 12
+ 'initialize', # 12
+ 'aggregate', # 12
+ '[]', # 11
+ 'filters', # 11
+ 'html_table', # 11
+ 'slice', # 11
]
# Offense count: 1
# Configuration parameters: ExpectMatchingDefinition, CheckDefinitionPathHierarchy, CheckDefinitionPathHierarchyRoots, Regex, IgnoreExecutableScripts, AllowedAcronyms.
# CheckDefinitionPathHierarchyRoots: lib, spec, test, src
@@ -194,9 +207,15 @@
Naming/PredicateName:
Exclude:
- 'lib/red_amber/vector.rb'
- 'lib/red_amber/vector_functions.rb'
- 'lib/red_amber/vector_selectable.rb'
+
+# Offense count: 16
+# This cop supports safe autocorrection (--autocorrect).
+Style/OperatorMethodCall:
+ Exclude:
+ - 'test/test_vector_binary_element_wise.rb'
# Necessary to test when range.end == -1
# Offense count: 2
# This cop supports unsafe autocorrection (--autocorrect-all).
Style/SlicingWithRange: