spec/lib/rambling/trie/configuration/provider_collection_spec.rb in rambling-trie-1.0.3 vs spec/lib/rambling/trie/configuration/provider_collection_spec.rb in rambling-trie-2.0.0

@@ -1,5 +1,7 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Rambling::Trie::Configuration::ProviderCollection do
   let(:configured_default) { nil }
   let(:configured_providers) do
@@ -11,11 +13,11 @@
 
   let(:provider_collection) do
     Rambling::Trie::Configuration::ProviderCollection.new(
       :provider,
       configured_providers,
-      configured_default
+      configured_default,
     )
   end
 
   describe '.new' do
     it 'has a name' do
@@ -82,29 +84,23 @@
         expect(provider_collection.default).to eq second_provider
       end
     end
 
     context 'when the given value is not in the providers list' do
-      it 'does not change the default provider' do
-        expect do
-          begin
-            provider_collection.default = other_provider
-          rescue
-          end
-        end.not_to change { provider_collection.default }
+      it 'raises an error and keeps the default provider' do
+        expect { provider_collection.default = other_provider }
+          .to raise_error
+          .and(not_change { provider_collection.default })
       end
 
       it 'raises an ArgumentError' do
-        expect do
-          provider_collection.default = other_provider
-        end.to raise_error ArgumentError
+        expect { provider_collection.default = other_provider }
+          .to raise_error ArgumentError
       end
     end
 
     context 'when the providers list is empty' do
-      let(:configured_providers) do
-        {}
-      end
+      let(:configured_providers) { {} }
 
       it 'accepts nil' do
         provider_collection.default = nil
         expect(provider_collection.default).to be_nil
       end