lib/rake/funnel/support/argument_mapper/styles/msdeploy.rb in rake-funnel-0.18.0 vs lib/rake/funnel/support/argument_mapper/styles/msdeploy.rb in rake-funnel-0.19.0

@@ -12,40 +12,41 @@
               @value_separator = '='
               @value_list_separator = ','
             end
 
             def generate_from(model)
-              model.map { |switch|
-                switch.values.map { |item|
-                  if item.is_a?(Enumerable)
-                    values = item.map.with_index { |nested, index| nested(nested, index) }
-                  else
-                    values = nested(item)
-                  end
+              model.flat_map do |switch|
+                switch.values.map do |item|
+                  values = if item.is_a?(Enumerable)
+                             item.map.with_index { |nested, index| nested(nested, index) }
+                           else
+                             nested(item)
+                           end
 
                   (top_level(switch) + values).flatten
-                }
-              }.flatten(1)
+                end
+              end
             end
 
             private
+
             def top_level(switch)
               [prefix, quote(switch.switch)]
             end
 
-            def nested(value, index = 0)
+            def nested(value, index = 0) # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity
               res = []
-              res << value_list_separator unless index == 0
+              res << value_list_separator unless index.zero?
               res << separator unless value.key.nil? && value.value.nil? || index != 0
               res << quote(value.key)
               res << value_separator unless value.key.nil? || value.value.nil?
               res << quote(value.value)
               res.compact
             end
 
             def quote(value)
               value = value.gsub(/"/, '""') if value.is_a?(String)
-              return %{"#{value}"} if value =~ /\s/
+              return %("#{value}") if value =~ /\s/
               value
             end
           end
         end
       end