crl_distribution_points.rb in r509-1.0

- old
+ new

@@ -34,11 +34,11 @@
         #   name = R509::ASN1::GeneralName.new(:type => "URI", :value => "http://crl.domain.com/test.crl")
         #   R509::Cert::Extensions::CRLDistributionPoints.new(
         #     :value => [name]
         #   )
         def initialize(arg)
-          if not R509::Cert::Extensions.is_extension?(arg)
+          unless R509::Cert::Extensions.is_extension?(arg)
             arg = build_extension(arg)
           end
 
           super(arg)
           parse_extension
@@ -58,11 +58,11 @@
         end
 
         private
 
         def parse_extension
-          @general_names= R509::ASN1::GeneralNames.new
+          @general_names = R509::ASN1::GeneralNames.new
           data = R509::ASN1.get_extension_payload(self)
           data.entries.each do |distribution_point|
             #   DistributionPoint ::= SEQUENCE {
             #        distributionPoint       [0]     DistributionPointName OPTIONAL,
             #        reasons                 [1]     ReasonFlags OPTIONAL,
@@ -77,21 +77,19 @@
           end
         end
 
         def build_extension(arg)
           validate_crl_distribution_points(arg)
-          validate_location('crl_distribution_points',arg[:value])
+          validate_location('crl_distribution_points', arg[:value])
           serialize = R509::ASN1::GeneralNames.new(arg[:value]).serialize_names
           ef = OpenSSL::X509::ExtensionFactory.new
           ef.config = OpenSSL::Config.parse(serialize[:conf])
           critical = R509::Cert::Extensions.calculate_critical(arg[:critical], false)
-          return ef.create_extension("crlDistributionPoints", serialize[:extension_string],critical)
+          ef.create_extension("crlDistributionPoints", serialize[:extension_string], critical)
         end
 
         def validate_crl_distribution_points(arg)
-          if not arg.kind_of?(Hash)
-            raise ArgumentError, "You must pass a hash with a :value key"
-          end
+          raise ArgumentError, "You must pass a hash with a :value key" unless arg.is_a?(Hash)
         end
       end
     end
   end
 end