spec/punchblock/command/dial_spec.rb in punchblock-1.9.4 vs spec/punchblock/command/dial_spec.rb in punchblock-2.0.0.beta1

@@ -5,63 +5,105 @@
 module Punchblock
   module Command
     describe Dial do
 
       it 'registers itself' do
-        RayoNode.class_from_registration(:dial, 'urn:xmpp:rayo:1').should be == Dial
+        RayoNode.class_from_registration(:dial, 'urn:xmpp:rayo:1').should be == described_class
       end
 
-      let(:join_params) { {:call_id => 'abc123'} }
+      let(:join_params) { {:call_uri => 'abc123'} }
 
       describe "when setting options in initializer" do
-        subject { Dial.new :to => 'tel:[phone]', :from => 'tel:[phone]', :timeout => 30000, :headers => { :x_skill => 'agent', :x_customer_id => 8877 }, :join => join_params }
+        subject { described_class.new to: 'tel:[phone]', from: 'tel:[phone]', timeout: 30000, headers: { 'X-skill' => 'agent', 'X-customer-id' => '8877' }, join: join_params }
 
-        it_should_behave_like 'command_headers'
-
         its(:to)      { should be == 'tel:[phone]' }
         its(:from)    { should be == 'tel:[phone]' }
         its(:timeout) { should be == 30000 }
         its(:join)    { should be == Join.new(join_params) }
+        its(:headers) { should be == { 'X-skill' => 'agent', 'X-customer-id' => '8877' } }
+
+        describe "exporting to Rayo" do
+          it "should export to XML that can be understood by its parser" do
+            new_instance = RayoNode.from_xml subject.to_rayo
+            new_instance.should be_instance_of described_class
+            new_instance.to.should == 'tel:[phone]'
+            new_instance.from.should == 'tel:[phone]'
+            new_instance.timeout.should == 30000
+            new_instance.join.should == Join.new(join_params)
+            new_instance.headers.should == { 'X-skill' => 'agent', 'X-customer-id' => '8877' }
+          end
+
+          it "should render to a parent node if supplied" do
+            doc = Nokogiri::XML::Document.new
+            parent = Nokogiri::XML::Node.new 'foo', doc
+            doc.root = parent
+            rayo_doc = subject.to_rayo(parent)
+            rayo_doc.should == parent
+          end
+
+          context "when attributes are not set" do
+            subject { described_class.new to: 'abc123' }
+
+            it "should not include them in the XML representation" do
+              subject.to_rayo['to'].should == 'abc123'
+              subject.to_rayo['from'].should be_nil
+            end
+          end
+        end
       end
 
       describe "from a stanza" do
         let :stanza do
           <<-MESSAGE
 <dial to='tel:[phone]' from='tel:[phone]' timeout='30000' xmlns='urn:xmpp:rayo:1'>
-  <join call-id="abc123" />
+  <join call-uri="abc123" />
   <header name="X-skill" value="agent" />
   <header name="X-customer-id" value="8877" />
 </dial>
           MESSAGE
         end
 
-        subject { RayoNode.import parse_stanza(stanza).root, '9f00061', '1' }
+        subject { RayoNode.from_xml parse_stanza(stanza).root, '9f00061', '1' }
 
-        it { should be_instance_of Dial }
+        it { should be_instance_of described_class }
 
-        it_should_behave_like 'event_headers'
-
         its(:to)      { should be == 'tel:[phone]' }
         its(:from)    { should be == 'tel:[phone]' }
         its(:timeout) { should be == 30000 }
         its(:join)    { should be == Join.new(join_params) }
+        its(:headers) { should be == { 'X-skill' => 'agent', 'X-customer-id' => '8877' } }
+
+        context "with no headers provided" do
+          let(:stanza) { '<dial xmlns="urn:xmpp:rayo:1"/>' }
+
+          its(:headers) { should == {} }
+        end
       end
 
       describe "#response=" do
         before { subject.request! }
 
         let(:call_id) { 'abc123' }
+        let(:domain)  { 'rayo.net' }
 
         let :ref do
-          Ref.new.tap do |ref|
-            ref.id = call_id
-          end
+          Ref.new uri: "xmpp:#{call_id}@#{domain}"
         end
 
+        it "should set the transport from the ref" do
+          subject.response = ref
+          subject.transport.should be == 'xmpp'
+        end
+
         it "should set the call ID from the ref" do
           subject.response = ref
           subject.target_call_id.should be == call_id
         end
+
+        it "should set the domain from the ref" do
+          subject.response = ref
+          subject.domain.should be == domain
+        end
       end
     end
   end
-end # Punchblock
+end