README.md in postgres_upsert-5.0.0 vs README.md in postgres_upsert-5.1.0
- old
+ new
@@ -111,11 +111,11 @@
And the following railsy code to create 10,000 users:
```ruby
def insert_dumb
time = Benchmark.measure do
(1..10000).each do |n|
- User.create!(:email => "number#{n}@postgres.up", :password => "#{(n-5..n).to_a.join('')}")
+ User.create!(:email => "number#{n}@email.com", :password => "password#{n)}")
end
end
puts time
end
```
@@ -123,13 +123,13 @@
Compared to the following code using Postgres_upsert:
```ruby
def insert_smart
time = Benchmark.measure do
csv_string = CSV.generate do |csv|
- csv << %w(email password)
+ csv << %w(email password) # CSV header row
(1..10000).each do |n|
- csv << ["number#{n}@postgres.up", "#{(n-5..n).to_a.join('')}"]
+ csv << ["number#{n}@email.com", "password#{n)}"]
end
end
io = StringIO.new(csv_string)
PostgresUpsert.write User io, unique_key: "email"
end
@@ -156,10 +156,13 @@
Note that for the benchmark, my database is local. The performance improvement should only increase when we have network latency to worry about.
## Note on Patches/Pull Requests
-* Fork the project
-* add your feature/fix to your fork(rpsec tests pleaze)
+I greatly appreciate contribution to this gem.
+
+* Fork the project and clone the repo locally
+* run 'bin/setup' to setup dependencies and create test DB
+* add your feature/fix to your fork(add and run rpsec tests please)
* submit a PR
* If you find an issue but can't fix in in a PR, please log an issue. I'll do my best.