snapshots_spec.rb in percy-capybara-2.4.1

- old
+ new

@@ -6,21 +6,20 @@
 RSpec.describe Percy::Capybara::Client::Snapshots, type: :feature do
   let(:capybara_client) { Percy::Capybara::Client.new(enabled: true) }
 
   describe '#snapshot', type: :feature, js: true do
     context 'simple page with no resources' do
-      before(:each) { setup_sprockets(capybara_client) }
       let(:loader) { capybara_client.initialize_loader(page: page) }
       let(:build_resource_sha) { loader.build_resources.first.sha }
       let(:snapshot_resource_sha) { loader.snapshot_resources.first.sha }
       let(:mock_build_response) do
         {
           'data' => {
             'id' => '123',
             'type' => 'builds',
             'relationships' => {
-              'self' => "/api/v1/snapshots/123",
+              'self' => '/api/v1/snapshots/123',
               'missing-resources' => {},
             },
           },
         }
       end
@@ -28,11 +27,11 @@
         {
           'data' => {
             'id' => '256',
             'type' => 'snapshots',
             'relationships' => {
-              'self' => "/api/v1/snapshots/123",
+              'self' => '/api/v1/snapshots/123',
               'missing-resources' => {
                 'data' => [
                   {
                     'type' => 'resources',
                     'id' => snapshot_resource_sha,
@@ -41,22 +40,24 @@
               },
             },
           },
         }
       end
-      before :each do
+      before do
+        setup_sprockets(capybara_client)
+
         visit '/'
-        loader  # Force evaluation now.
+        loader # Force evaluation now.
         repo = Percy::Client::Environment.repo
         stub_request(:post, "https://percy.io/api/v1/repos/#{repo}/builds/")
           .to_return(status: 201, body: mock_build_response.to_json)
         stub_request(:post, 'https://percy.io/api/v1/builds/123/snapshots/')
           .to_return(status: 201, body: mock_snapshot_response.to_json)
-        stub_request(:post, "https://percy.io/api/v1/builds/123/resources/")
+        stub_request(:post, 'https://percy.io/api/v1/builds/123/resources/')
           .with(body: /#{snapshot_resource_sha}/)
           .to_return(status: 201, body: {success: true}.to_json)
-        stub_request(:post, "https://percy.io/api/v1/snapshots/256/finalize")
+        stub_request(:post, 'https://percy.io/api/v1/snapshots/256/finalize')
           .to_return(status: 200, body: {success: true}.to_json)
         capybara_client.initialize_build
       end
 
       it 'creates a snapshot' do
@@ -69,22 +70,23 @@
         capybara_client = Percy::Capybara::Client.new(enabled: true)
         expect { capybara_client.snapshot(page) }.to raise_error(RuntimeError)
       end
       it 'passes through options to the percy client if given' do
         expect(capybara_client.client).to receive(:create_snapshot)
-          .with(anything, anything, {name: 'foo', widths: [320, 1024], enable_javascript: true})
+          .with(anything, anything, name: 'foo', widths: [320, 1024], enable_javascript: true)
           .and_call_original
 
         result = capybara_client.snapshot(
-          page, name: 'foo', widths: [320, 1024], enable_javascript: true)
+          page, name: 'foo', widths: [320, 1024], enable_javascript: true
+        )
         expect(result).to eq(true)
         expect(capybara_client.failed?).to eq(false)
       end
       it 'safely handles snapshot bad request errors' do
         error = Percy::Client::BadRequestError.new(400, '', '', '', 'snapshot error msg')
         expect(capybara_client.client).to receive(:create_snapshot).and_raise(error)
         expect(capybara_client.snapshot(page)).to eq(nil)
-        expect(capybara_client.failed?).to eq(false)  # Build is not failed.
+        expect(capybara_client.failed?).to eq(false) # Build is not failed.
       end
       it 'safely handles connection errors' do
         expect(capybara_client.client).to receive(:create_snapshot)
           .and_raise(Percy::Client::ConnectionFailed)
         expect(capybara_client.snapshot(page)).to eq(nil)