test/test_source.rb in pdd-0.20.6 vs test/test_source.rb in pdd-0.20.7

@@ -1,6 +1,6 @@
-# Copyright (c) 2014-2020 Yegor Bugayenko
+# Copyright (c) 2014-2021 Yegor Bugayenko
 #
 # Permission is hereby granted, free of charge, to any person obtaining a copy
 # of this software and associated documentation files (the 'Software'), to deal
 # in the Software without restriction, including without limitation the rights
 # to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
@@ -23,11 +23,11 @@
 require_relative '../lib/pdd'
 require_relative '../lib/pdd/sources'
 
 # Source test.
 # Author:: Yegor Bugayenko ([e-mail])
-# Copyright:: Copyright (c) 2014-2020 Yegor Bugayenko
+# Copyright:: Copyright (c) 2014-2021 Yegor Bugayenko
 # License:: MIT
 class TestSource < Minitest::Test
   def test_parsing
     Dir.mktmpdir 'test' do |dir|
       file = File.join(dir, 'a.txt')
@@ -40,22 +40,46 @@
         Something else
         ~~ \x40todo #ABC-3 this is another puzzle
         ~~  and it also has to work
         "
       )
-      list = PDD::VerboseSource.new(file, PDD::Source.new(file, 'hey')).puzzles
-      assert_equal 2, list.size
-      puzzle = list.first
-      assert_equal '2-3', puzzle.props[:lines]
-      assert_equal 'привет, how are you doing?', puzzle.props[:body]
-      assert_equal '44', puzzle.props[:ticket]
-      assert puzzle.props[:author].nil?
-      assert puzzle.props[:email].nil?
-      assert puzzle.props[:time].nil?
+      stub_source_find_github_user(file, 'hey') do |source|
+        list = source.puzzles
+        assert_equal 2, list.size
+        puzzle = list.first
+        assert_equal '2-3', puzzle.props[:lines]
+        assert_equal 'привет, how are you doing?', puzzle.props[:body]
+        assert_equal '44', puzzle.props[:ticket]
+        assert puzzle.props[:author].nil?
+        assert puzzle.props[:email].nil?
+        assert puzzle.props[:time].nil?
+      end
     end
   end
 
+  def test_parsing_leading_spaces
+    Dir.mktmpdir 'test' do |dir|
+      file = File.join(dir, 'a.txt')
+      File.write(
+        file,
+        "
+        * \x40todo #56:30min this is a
+        *       multi-line
+        *     comment!
+        "
+      )
+      stub_source_find_github_user(file, 'hey') do |source|
+        list = source.puzzles
+        assert_equal 1, list.size
+        puzzle = list.first
+        assert_equal '2-4', puzzle.props[:lines]
+        assert_equal 'this is a multi-line comment!', puzzle.props[:body]
+        assert_equal '56', puzzle.props[:ticket]
+      end
+    end
+  end
+
   def test_failing_on_invalid_puzzle
     Dir.mktmpdir 'test' do |dir|
       file = File.join(dir, 'a.txt')
       File.write(
         file,
@@ -63,38 +87,65 @@
         * \x40todo #44 this is an incorrectly formatted puzzle,
         * with a second line without a leading space
         "
       )
       error = assert_raises PDD::Error do
-        PDD::VerboseSource.new(file, PDD::Source.new(file, 'hey')).puzzles
+        stub_source_find_github_user(file, 'hey', &:puzzles)
       end
       assert !error.message.index('Space expected').nil?
     end
   end
 
+  def test_succeed_despite_bad_puzzles
+    Dir.mktmpdir 'test' do |dir|
+      file = File.join(dir, 'a.txt')
+      File.write(
+        file,
+        "
+        * \x40todo #44 this is an incorrectly formatted puzzle,
+        * with a second line without a leading space
+        Another badly formatted puzzle
+        * \x40todo this puzzle misses ticket name/number
+        Something else
+        * \x40todo #123 This puzzle is correctly formatted
+        "
+      )
+      PDD.opts = { 'skip-errors' => true }
+      stub_source_find_github_user(file, 'hey') do |source|
+        list = source.puzzles
+        PDD.opts = nil
+        assert_equal 1, list.size
+        puzzle = list.first
+        assert_equal '7-7', puzzle.props[:lines]
+        assert_equal 'This puzzle is correctly formatted', puzzle.props[:body]
+        assert_equal '123', puzzle.props[:ticket]
+      end
+    end
+  end
+
   def test_failing_on_incomplete_puzzle
     Dir.mktmpdir 't5' do |dir|
       file = File.join(dir, 'ff.txt')
       File.write(
         file,
         "
         * \x40todo this puzzle misses ticket name/number
         "
       )
       error = assert_raises PDD::Error do
-        PDD::VerboseSource.new(file, PDD::Source.new(file, 'ff')).puzzles
+        stub_source_find_github_user(file, 'ff', &:puzzles)
       end
       assert !error.to_s.index("\x40todo is not followed by").nil?
     end
   end
 
   def test_failing_on_broken_unicode
     Dir.mktmpdir 'test' do |dir|
       file = File.join(dir, 'xx.txt')
       File.write(file, ' * \x40todo #44 this is a broken unicode: ' + 0x92.chr)
       assert_raises PDD::Error do
-        PDD::VerboseSource.new(file, PDD::Source.new(file, 'xx')).puzzles
+        stub_source_find_github_user(file, 'xx', &:puzzles)
       end
     end
   end
 
   def test_failing_on_invalid_puzzle_without_hash_sign
@@ -105,11 +156,11 @@
         "
         * \x40todo 44 this puzzle is not formatted correctly
         "
       )
       error = assert_raises PDD::Error do
-        PDD::VerboseSource.new(file, PDD::Source.new(file, 'hey')).puzzles
+        stub_source_find_github_user(file, 'hey', &:puzzles)
       end
       assert !error.message.index('is not followed by a puzzle marker').nil?
     end
   end
 
@@ -121,11 +172,11 @@
         "
         *\x40todo #999 this is an incorrectly formatted puzzle!
         "
       )
       error = assert_raises PDD::Error do
-        PDD::VerboseSource.new(file, PDD::Source.new(file, 'x')).puzzles
+        stub_source_find_github_user(file, 'x', &:puzzles)
       end
       assert !error.message.index("\x40todo must have a leading space").nil?
     end
   end
 
@@ -137,11 +188,11 @@
         "
         * \x40todo # 123 This puzzle has an unnecessary space before the dash
         "
       )
       error = assert_raises PDD::Error do
-        PDD::VerboseSource.new(file, PDD::Source.new(file, 'x')).puzzles
+        stub_source_find_github_user(file, 'x', &:puzzles)
       end
       assert !error.message.index('an unexpected space').nil?
     end
   end
 
@@ -151,24 +202,27 @@
       raise unless system("
         set -e
         cd '#{dir}'
         git init --quiet .
         git config user.email [e-mail]
-        git config user.name test
+        git config user.name test_unknown
         echo '\x40todo #1 this is the puzzle' > a.txt
         git add a.txt
         git commit --quiet -am 'first version'
       ")
-      list = PDD::Source.new(File.join(dir, 'a.txt'), '').puzzles
-      assert_equal 1, list.size
-      puzzle = list.first
-      assert_equal '1-de87adc8', puzzle.props[:id]
-      assert_equal '1-1', puzzle.props[:lines]
-      assert_equal 'this is the puzzle', puzzle.props[:body]
-      assert_equal 'test', puzzle.props[:author]
-      assert_equal '[e-mail]', puzzle.props[:email]
-      assert_match(/\d{4}-\d{2}-\d{2}T\d{2}:\d{2}:\d{2}Z/, puzzle.props[:time])
+      stub_source_find_github_user(File.join(dir, 'a.txt')) do |source|
+        list = source.puzzles
+        assert_equal 1, list.size
+        puzzle = list.first
+        assert_equal '1-de87adc8', puzzle.props[:id]
+        assert_equal '1-1', puzzle.props[:lines]
+        assert_equal 'this is the puzzle', puzzle.props[:body]
+        assert_equal 'test_unknown', puzzle.props[:author]
+        assert_equal '[e-mail]', puzzle.props[:email]
+        assert_match(/\d{4}-\d{2}-\d{2}T\d{2}:\d{2}:\d{2}Z/,
+                     puzzle.props[:time])
+      end
     end
   end
 
   def test_skips_invalid_git_mail
     skip if Gem.win_platform?
@@ -181,19 +235,22 @@
         git config user.name test
         echo '\x40todo #1 this is the puzzle' > a.txt
         git add a.txt
         git commit --quiet -am 'first version'
       ")
-      list = PDD::Source.new(File.join(dir, 'a.txt'), '').puzzles
-      assert_equal 1, list.size
-      puzzle = list.first
-      assert_equal '1-de87adc8', puzzle.props[:id]
-      assert_equal '1-1', puzzle.props[:lines]
-      assert_equal 'this is the puzzle', puzzle.props[:body]
-      assert_equal 'test', puzzle.props[:author]
-      assert_nil puzzle.props[:email]
-      assert_match(/\d{4}-\d{2}-\d{2}T\d{2}:\d{2}:\d{2}Z/, puzzle.props[:time])
+      stub_source_find_github_user(File.join(dir, 'a.txt')) do |source|
+        list = source.puzzles
+        assert_equal 1, list.size
+        puzzle = list.first
+        assert_equal '1-de87adc8', puzzle.props[:id]
+        assert_equal '1-1', puzzle.props[:lines]
+        assert_equal 'this is the puzzle', puzzle.props[:body]
+        assert_equal 'test', puzzle.props[:author]
+        assert_nil puzzle.props[:email]
+        assert_match(/\d{4}-\d{2}-\d{2}T\d{2}:\d{2}:\d{2}Z/,
+                     puzzle.props[:time])
+      end
     end
   end
 
   def test_uses_github_login
     skip if Gem.win_platform?
@@ -205,28 +262,55 @@
         git config user.name test
         echo '\x40todo #1 this is the puzzle' > a.txt
         git add a.txt
         git commit --quiet -am 'first version'
       ")
-      list = PDD::Source.new(File.join(dir, 'a.txt'), '').puzzles
-      assert_equal 1, list.size
-      puzzle = list.first
-      assert_equal '@yegor256', puzzle.props[:author]
+      stub_source_find_github_user(File.join(dir, 'a.txt')) do |source|
+        list = source.puzzles
+        assert_equal 1, list.size
+        puzzle = list.first
+        assert_equal '@yegor256', puzzle.props[:author]
+      end
     end
   end
 
+  def test_skips_uncommitted_changes
+    skip if Gem.win_platform?
+    Dir.mktmpdir 'test' do |dir|
+      raise unless system("
+        cd '#{dir}'
+        git init --quiet .
+        git config user.email [e-mail]
+        git config user.name test
+        echo 'hi' > a.txt
+        git add a.txt
+        git commit --quiet -am 'first version'
+        echo '\x40todo #1 this is a puzzle uncommitted' > a.txt
+      ")
+      stub_source_find_github_user(File.join(dir, 'a.txt')) do |source|
+        list = source.puzzles
+        assert_equal 1, list.size
+        puzzle = list.first
+        assert_nil puzzle.props[:email]
+        assert_equal 'Not Committed Yet', puzzle.props[:author]
+      end
+    end
+  end
+
   def test_skips_thymeleaf_close_tag
     Dir.mktmpdir 'test' do |dir|
       file = File.join(dir, 'a.txt')
       File.write(
         file,
         '<!--/* @todo #123 puzzle info */-->'
       )
-      list = PDD::VerboseSource.new(file, PDD::Source.new(file, 'hey')).puzzles
-      assert_equal 1, list.size
-      puzzle = list.first
-      assert_equal '1-1', puzzle.props[:lines]
-      assert_equal 'puzzle info', puzzle.props[:body]
-      assert_equal '123', puzzle.props[:ticket]
+      stub_source_find_github_user(file, 'hey') do |source|
+        list = source.puzzles
+        assert_equal 1, list.size
+        puzzle = list.first
+        assert_equal '1-1', puzzle.props[:lines]
+        assert_equal 'puzzle info', puzzle.props[:body]
+        assert_equal '123', puzzle.props[:ticket]
+      end
     end
   end
 end