ftp_spec.rb in paperclip-storage-ftp-1.1.0.rc1

- old
+ new

@@ -24,43 +24,50 @@
         }
       ]
     })
   end
 
+  let(:first_server)  { Paperclip::Storage::Ftp::Server.new }
+  let(:second_server) { Paperclip::Storage::Ftp::Server.new }
+
   context "#exists?" do
     it "returns false if original_filename not set" do
       attachment.stub(:original_filename).and_return(nil)
       attachment.exists?.should be_false
     end
 
     it "returns true if the file exists on the primary server" do
-      attachment.primary_ftp_server.should_receive(:file_exists?).with("/files/original/foo.jpg").and_return(true)
+      first_server.should_receive(:file_exists?).with("/files/original/foo.jpg").and_return(true)
+      attachment.should_receive(:with_primary_ftp_server).and_yield(first_server)
       attachment.exists?.should be_true
     end
 
     it "accepts an optional style_name parameter to build the correct file path" do
-      attachment.primary_ftp_server.should_receive(:file_exists?).with("/files/thumb/foo.jpg").and_return(true)
+      first_server.should_receive(:file_exists?).with("/files/thumb/foo.jpg").and_return(true)
+      attachment.should_receive(:with_primary_ftp_server).and_yield(first_server)
       attachment.exists?(:thumb)
     end
   end
 
   context "#to_file" do
     it "returns the file from the primary server as a local tempfile" do
       tempfile = double("tempfile")
       tempfile.should_receive(:path).and_return("/tmp/foo")
       tempfile.should_receive(:rewind).with(no_args)
       Tempfile.should_receive(:new).with(["foo", ".jpg"]).and_return(tempfile)
-      attachment.primary_ftp_server.should_receive(:get_file).with("/files/original/foo.jpg", "/tmp/foo").and_return(:foo)
+      first_server.should_receive(:get_file).with("/files/original/foo.jpg", "/tmp/foo").and_return(:foo)
+      attachment.should_receive(:with_primary_ftp_server).and_yield(first_server)
       attachment.to_file.should == tempfile
     end
 
     it "accepts an optional style_name parameter to build the correct file path" do
       tempfile = double("tempfile")
       tempfile.should_receive(:path).and_return("/tmp/foo")
       tempfile.should_receive(:rewind).with(no_args)
       Tempfile.should_receive(:new).with(["foo", ".jpg"]).and_return(tempfile)
-      attachment.primary_ftp_server.should_receive(:get_file).with("/files/thumb/foo.jpg", anything)
+      first_server.should_receive(:get_file).with("/files/thumb/foo.jpg", anything)
+      attachment.should_receive(:with_primary_ftp_server).and_yield(first_server)
       attachment.to_file(:thumb)
     end
 
     it "gets an existing file object from the local write queue, if available" do
       file = double("file")
@@ -78,16 +85,17 @@
       attachment.instance_variable_set(:@queued_for_write, {
         :original => original_file,
         :thumb    => thumb_file
       })
 
-      thumb_file.should_receive(:close).with(no_args)
-      original_file.should_receive(:close).with(no_args)
-      attachment.ftp_servers.first.should_receive(:put_file).with("/tmp/original/foo.jpg", "/files/original/foo.jpg")
-      attachment.ftp_servers.first.should_receive(:put_file).with("/tmp/thumb/foo.jpg", "/files/thumb/foo.jpg")
-      attachment.ftp_servers.second.should_receive(:put_file).with("/tmp/original/foo.jpg", "/files/original/foo.jpg")
-      attachment.ftp_servers.second.should_receive(:put_file).with("/tmp/thumb/foo.jpg", "/files/thumb/foo.jpg")
+      first_server.should_receive(:put_file).with("/tmp/original/foo.jpg", "/files/original/foo.jpg")
+      first_server.should_receive(:put_file).with("/tmp/thumb/foo.jpg", "/files/thumb/foo.jpg")
+      second_server.should_receive(:put_file).with("/tmp/original/foo.jpg", "/files/original/foo.jpg")
+      second_server.should_receive(:put_file).with("/tmp/thumb/foo.jpg", "/files/thumb/foo.jpg")
+
+      attachment.should_receive(:with_ftp_servers).and_yield([first_server, second_server])
+
       attachment.should_receive(:after_flush_writes).with(no_args)
 
       attachment.flush_writes
 
       attachment.queued_for_write.should == {}
@@ -98,47 +106,74 @@
     it "deletes the files on every server" do
       attachment.instance_variable_set(:@queued_for_delete, [
         "/files/original/foo.jpg",
         "/files/thumb/foo.jpg"
       ])
-      attachment.ftp_servers.first.should_receive(:delete_file).with("/files/original/foo.jpg")
-      attachment.ftp_servers.first.should_receive(:delete_file).with("/files/thumb/foo.jpg")
-      attachment.ftp_servers.second.should_receive(:delete_file).with("/files/original/foo.jpg")
-      attachment.ftp_servers.second.should_receive(:delete_file).with("/files/thumb/foo.jpg")
 
+      first_server.should_receive(:delete_file).with("/files/original/foo.jpg")
+      first_server.should_receive(:delete_file).with("/files/thumb/foo.jpg")
+      second_server.should_receive(:delete_file).with("/files/original/foo.jpg")
+      second_server.should_receive(:delete_file).with("/files/thumb/foo.jpg")
+
+      attachment.should_receive(:with_ftp_servers).and_yield([first_server, second_server])
+
       attachment.flush_deletes
 
       attachment.instance_variable_get(:@queued_for_delete).should == []
     end
   end
 
   context "#copy_to_local_file" do
+    before do
+      attachment.should_receive(:with_primary_ftp_server).and_yield(first_server)
+    end
+
     it "returns the file from the primary server and stores it in the path specified" do
-      attachment.primary_ftp_server.should_receive(:get_file).with("/files/original/foo.jpg", "/local/foo").and_return(:foo)
-      attachment.copy_to_local_file(:original, "/local/foo")
+      first_server.should_receive(:get_file).with("/files/original/foo.jpg", "/local/foo").and_return(:foo)
+      attachment.copy_to_local_file(:original, "/local/foo").should == :foo
     end
 
     it "accepts the style parameter to build the correct path" do
-      attachment.primary_ftp_server.should_receive(:get_file).with("/files/thumb/foo.jpg", "/local/thumb/foo").and_return(:foo)
+      first_server.should_receive(:get_file).with("/files/thumb/foo.jpg", "/local/thumb/foo")
       attachment.copy_to_local_file(:thumb, "/local/thumb/foo")
     end
   end
 
+  context "#with_primary_ftp_server" do
+    it "yields the connected primary ftp server, closes the connection afterwards" do
+      attachment.stub(:primary_ftp_server).and_return(first_server)
+      first_server.should_receive(:establish_connection).ordered
+      first_server.should_receive(:close_connection).ordered
+      expect { |b| attachment.with_primary_ftp_server(&b) }.to yield_with_args(first_server)
+    end
+  end
+
+  context "#primary_ftp_server" do
+    it "returns the first server in the list" do
+      attachment.primary_ftp_server.should equal(attachment.ftp_servers.first)
+    end
+  end
+
+  context "#with_ftp_servers" do
+    it "yields the connected ftp servers, closes the connections afterwards" do
+      attachment.stub(:ftp_servers).and_return([first_server, second_server])
+      first_server.should_receive(:establish_connection).ordered
+      second_server.should_receive(:establish_connection).ordered
+      first_server.should_receive(:close_connection).ordered
+      second_server.should_receive(:close_connection).ordered
+      expect { |b| attachment.with_ftp_servers(&b) }.to yield_with_args([first_server, second_server])
+    end
+  end
+
   context "#ftp_servers" do
     it "returns the configured ftp servers" do
       attachment.ftp_servers.first.host.should      == "ftp1.example.com"
       attachment.ftp_servers.first.user.should      == "user1"
       attachment.ftp_servers.first.password.should  == "password1"
       attachment.ftp_servers.first.port.should      == 2121
       attachment.ftp_servers.second.host.should     == "ftp2.example.com"
       attachment.ftp_servers.second.user.should     == "user2"
       attachment.ftp_servers.second.password.should == "password2"
       attachment.ftp_servers.second.passive.should  == true
-    end
-  end
-
-  context "#primary_ftp_server" do
-    it "returns the first server in the list" do
-      attachment.primary_ftp_server.should == attachment.ftp_servers.first
     end
   end
 end