lib/paperbin/handler.rb in paperbin-0.0.1 vs lib/paperbin/handler.rb in paperbin-0.0.2

@@ -67,17 +67,14 @@
     record_md5 == check_md5
   end
 
   def process_valid_records(version, last_item)
     # remove records from db expcet the lastest one
-    unless version == last_item
-      version.delete
-      options[:callback].call(gz_file(version, true)) if options[:callback]
-    end
+    version.delete unless version == last_item
     # rename file extension
     File.rename(gz_file(version), gz_file(version, true))
-
+    options[:callback].call(gz_file(version, true)) if options[:callback]
   end
 
   def generate_files
     versions.each do |version|
       data = version.to_json
@@ -93,28 +90,27 @@
 
     end
   end
 
   def check_versions
-    valid = true
     versions.each_with_index do |version, index|
       # check both file exist or not
       next unless files_exist?(md5_file(version), gz_file(version))
 
       if md5_valid?(version)
         process_valid_records(version, versions.last)
       else
-        valid = false
         # remove both files
         [gz_file(version), md5_file(version)].each do |f|
           File.delete(f)
         end
+        raise Errno::ENOENT
       end
     end
 
+  rescue Errno::ENOENT
     # lodge worker unless valid
-    Paperbin::WriteWorker.perform_async(version.item_id, version.item_type) unless valid
-
+    Paperbin::WriteWorker.perform_async(version.item_id, version.item_type)
   end
 end