element_spec.rb in page_magic-1.0.2

- old
+ new

@@ -12,23 +12,77 @@
 
     let(:session) { page_class.visit(application: rack_app) }
 
     let(:page) { session.current_page }
 
-    # let!(:browser) { double('browser') }
+    let(:described_class) do
+      Class.new(Element).tap { |clazz| clazz.parent_element(page) }
+    end
 
     subject do
-      described_class.new(:page_element, page)
+      described_class.new(:page_element)
     end
 
     it_behaves_like 'session accessor'
     it_behaves_like 'element watcher'
     it_behaves_like 'waiter'
     it_behaves_like 'element locator'
 
-    describe 'inheriting' do
-      it 'lets you create custom elements' do
+    describe '.after_events' do
+      subject do
+        Class.new(described_class)
+      end
+
+      context 'hook set' do
+        it 'returns that hook' do
+          hook = proc {}
+          subject.after_events(&hook)
+          expect(subject.after_events).to eq([described_class::DEFAULT_HOOK, hook])
+        end
+      end
+      context 'hook not registered' do
+        it 'returns the default hook' do
+          expect(subject.after_events).to eq([described_class::DEFAULT_HOOK])
+        end
+      end
+    end
+
+    describe '.before_events' do
+      subject do
+        Class.new(described_class)
+      end
+
+      context 'hook set' do
+        it 'returns that hook' do
+          hook = proc {}
+          subject.before_events(&hook)
+          expect(subject.before_events).to eq([described_class::DEFAULT_HOOK, hook])
+        end
+      end
+      context 'hook not registered' do
+        it 'returns the default hook' do
+          expect(subject.before_events).to eq([described_class::DEFAULT_HOOK])
+        end
+      end
+    end
+
+    describe '.inherited' do
+      it 'copies before hooks' do
+        before_hook = proc {}
+        described_class.before_events(&before_hook)
+        sub_class = Class.new(described_class)
+        expect(sub_class.before_events).to include(before_hook)
+      end
+
+      it 'copies after hooks' do
+        after_hook = proc {}
+        described_class.after_events(&after_hook)
+        sub_class = Class.new(described_class)
+        expect(sub_class.after_events).to include(after_hook)
+      end
+
+      it 'lets sub classes defined their own elements' do
         custom_element = Class.new(described_class) do
           text_field :form_field, id: 'field_id'
 
           def self.name
             'Form'
@@ -41,68 +95,98 @@
 
         expect(page.form.form_field).to be_visible
       end
     end
 
+    describe '.watch' do
+      let(:described_class) { Class.new(Element) }
+      it 'adds a before hook with the watcher in it' do
+        described_class.watch(:object_id)
+        instance = described_class.new(:element)
+
+        watcher_block = instance.before_events.last
+        instance.instance_exec(&watcher_block)
+        expect(instance.watchers.first.last).to eq(instance.object_id)
+      end
+    end
+
     describe 'EVENT_TYPES' do
       context 'methods created' do
         it 'creates methods for each of the event types' do
           missing = described_class::EVENT_TYPES.find_all { |event| !subject.respond_to?(event) }
           expect(missing).to be_empty
         end
 
         context 'method called' do
           let(:browser_element) { instance_double(Capybara::Node::Element) }
           subject do
-            described_class.new(browser_element, page)
+            described_class.new(browser_element)
           end
           it 'calls the browser_element passing on all args' do
             expect(browser_element).to receive(:select).with(:args)
             subject.select :args
           end
         end
       end
     end
 
-    describe '#initialize' do
-      it 'sets the parent element' do
-        instance = described_class.new(page, :parent_page_element)
-        expect(instance.parent_page_element).to eq(:parent_page_element)
-      end
-    end
-
     describe 'hooks' do
       subject do
         Class.new(described_class) do
           before_events do
-            call_in_before_hook
+            call_in_before_events
           end
-        end.new(double('button', click: true), page)
+        end.new(double('button', click: true))
       end
-      context 'method called in before hook' do
+      context 'method called in before_events' do
         it 'calls methods on the page element' do
-          expect(subject).to receive(:call_in_before_hook)
+          expect(subject).to receive(:call_in_before_events)
           subject.click
         end
       end
 
-      context 'method called in after hook' do
+      context 'method called in after_events' do
         subject do
           Class.new(described_class) do
             after_events do
-              call_in_after_hook
+              call_in_after_events
             end
-          end.new(double('button', click: true), page)
+          end.new(double('button', click: true))
         end
 
         it 'calls methods on the page element' do
-          expect(subject).to receive(:call_in_after_hook)
+          expect(subject).to receive(:call_in_after_events)
           subject.click
         end
       end
     end
 
+    describe '#initialize' do
+      it 'sets the parent element' do
+        instance = described_class.new(:element)
+        expect(instance.parent_element).to eq(page)
+      end
+
+      context 'inherited items' do
+        let(:described_class) do
+          Class.new(Element)
+        end
+
+        it 'copies the event hooks from the class' do
+          before_hook = proc {}
+          after_hook = proc {}
+          described_class.before_events(&before_hook)
+          described_class.after_events(&after_hook)
+
+          instance = described_class.new(:element)
+
+          expect(instance.before_events).to include(before_hook)
+          expect(instance.after_events).to include(after_hook)
+        end
+      end
+    end
+
     describe '#method_missing' do
       before do
         page_class.class_eval do
           element :form_by_css, css: '.form' do
             link(:link_in_form, text: 'a in a form')
@@ -123,10 +207,10 @@
 
     describe '#respond_to?' do
       subject do
         Class.new(described_class) do
           element :sub_element, css: '.sub-element'
-        end.new(double(element_method: ''), :parent_page_element)
+        end.new(double(element_method: ''))
       end
       it 'checks for methods on self' do
         expect(subject.respond_to?(:session)).to eq(true)
       end
 