lib/packwerk/reference_checking/checkers/dependency_checker.rb in packwerk-2.3.0 vs lib/packwerk/reference_checking/checkers/dependency_checker.rb in packwerk-3.0.0

@@ -7,40 +7,63 @@
       # Checks whether a given reference conforms to the configured graph of dependencies.
       class DependencyChecker
         extend T::Sig
         include Checker
 
-        sig { override.returns(ViolationType) }
+        VIOLATION_TYPE = T.let("dependency", String)
+
+        sig { override.returns(String) }
         def violation_type
-          ViolationType::Dependency
+          VIOLATION_TYPE
         end
 
         sig do
           override
             .params(reference: Packwerk::Reference)
             .returns(T::Boolean)
         end
         def invalid_reference?(reference)
-          return false unless reference.source_package
-          return false unless reference.source_package.enforce_dependencies?
-          return false if reference.source_package.dependency?(reference.constant.package)
+          return false unless reference.package.enforce_dependencies?
+          return false if reference.package.dependency?(reference.constant.package)
 
           true
         end
 
         sig do
           override
             .params(reference: Packwerk::Reference)
             .returns(String)
         end
         def message(reference)
+          const_name = reference.constant.name
+          const_package = reference.constant.package
+          ref_package = reference.package
+
           <<~EOS
-            Dependency violation: #{reference.constant.name} belongs to '#{reference.constant.package}', but '#{reference.source_package}' does not specify a dependency on '#{reference.constant.package}'.
+            Dependency violation: #{const_name} belongs to '#{const_package}', but '#{ref_package}' does not specify a dependency on '#{const_package}'.
             Are we missing an abstraction?
             Is the code making the reference, and the referenced constant, in the right packages?
 
             #{standard_help_message(reference)}
           EOS
+        end
+
+        sig { override.params(listed_offense: ReferenceOffense).returns(T::Boolean) }
+        def strict_mode_violation?(listed_offense)
+          referencing_package = listed_offense.reference.package
+          referencing_package.config["enforce_dependencies"] == "strict"
+        end
+
+        private
+
+        sig { params(reference: Reference).returns(String) }
+        def standard_help_message(reference)
+          standard_message = <<~EOS
+            Inference details: this is a reference to #{reference.constant.name} which seems to be defined in #{reference.constant.location}.
+            To receive help interpreting or resolving this error message, see: https://github.com/Shopify/packwerk/blob/main/TROUBLESHOOT.md#Troubleshooting-violations
+          EOS
+
+          standard_message.chomp
         end
       end
     end
   end
 end