.rubocop_todo.yml in oxidized-0.22.0 vs .rubocop_todo.yml in oxidized-0.23.0

@@ -1,8 +1,8 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2018-06-03 10:03:33 +0200 using RuboCop version 0.55.0.
+# on 2018-06-08 09:41:49 +0200 using RuboCop version 0.57.1.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
@@ -17,11 +17,11 @@
 Lint/AmbiguousBlockAssociation:
   Exclude:
     - 'lib/oxidized/model/model.rb'
     - 'lib/oxidized/model/nos.rb'
 
-# Offense count: 681
+# Offense count: 684
 Lint/AmbiguousRegexpLiteral:
   Enabled: false
 
 # Offense count: 8
 # Configuration parameters: AllowSafeAssignment.
@@ -66,15 +66,14 @@
 Lint/ShadowingOuterLocalVariable:
   Exclude:
     - 'lib/oxidized/model/fortios.rb'
     - 'lib/oxidized/model/planet.rb'
 
-# Offense count: 10
+# Offense count: 7
 Lint/UnderscorePrefixedVariableName:
   Exclude:
     - 'lib/oxidized/input/cli.rb'
-    - 'lib/oxidized/manager.rb'
     - 'lib/oxidized/model/model.rb'
     - 'lib/oxidized/nodes.rb'
 
 # Offense count: 2
 # Cop supports --auto-correct.
@@ -113,11 +112,11 @@
 # Configuration parameters: CheckForMethodsWithNoSideEffects.
 Lint/Void:
   Exclude:
     - 'lib/oxidized/model/voss.rb'
 
-# Offense count: 63
+# Offense count: 64
 Metrics/AbcSize:
   Max: 84
 
 # Offense count: 19
 # Configuration parameters: CountComments, ExcludedMethods.
@@ -136,11 +135,11 @@
 
 # Offense count: 14
 Metrics/CyclomaticComplexity:
   Max: 28
 
-# Offense count: 56
+# Offense count: 55
 # Configuration parameters: CountComments.
 Metrics/MethodLength:
   Max: 76
 
 # Offense count: 2
@@ -204,10 +203,16 @@
 # Cop supports --auto-correct.
 Performance/Casecmp:
   Exclude:
     - 'lib/oxidized/manager.rb'
 
+# Offense count: 1
+# Cop supports --auto-correct.
+Performance/InefficientHashSearch:
+  Exclude:
+    - 'lib/oxidized/node.rb'
+
 # Offense count: 57
 # Cop supports --auto-correct.
 Performance/RedundantMatch:
   Enabled: false
 
@@ -255,11 +260,11 @@
 Style/Alias:
   Exclude:
     - 'lib/oxidized/node.rb'
     - 'lib/oxidized/nodes.rb'
 
-# Offense count: 46
+# Offense count: 47
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: always, conditionals
 Style/AndOr:
   Enabled: false
@@ -335,11 +340,11 @@
 Style/ConditionalAssignment:
   Exclude:
     - 'lib/oxidized/hook/githubrepo.rb'
     - 'lib/oxidized/model/model.rb'
 
-# Offense count: 150
+# Offense count: 153
 Style/Documentation:
   Enabled: false
 
 # Offense count: 2
 Style/DoubleNegation:
@@ -410,11 +415,11 @@
 # Cop supports --auto-correct.
 Style/LineEndConcatenation:
   Exclude:
     - 'lib/oxidized/hook.rb'
 
-# Offense count: 137
+# Offense count: 142
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: require_parentheses, require_no_parentheses, require_no_parentheses_except_multiline
 Style/MethodDefParentheses:
   Enabled: false
@@ -483,11 +488,11 @@
     - 'lib/oxidized/core.rb'
     - 'lib/oxidized/jobs.rb'
     - 'lib/oxidized/nodes.rb'
     - 'lib/oxidized/worker.rb'
 
-# Offense count: 1
+# Offense count: 2
 # Cop supports --auto-correct.
 Style/OrAssignment:
   Exclude:
     - 'lib/oxidized/manager.rb'
 
@@ -501,11 +506,11 @@
     - 'lib/oxidized/output/git.rb'
     - 'lib/oxidized/output/gitcrypt.rb'
 
 # Offense count: 4
 # Cop supports --auto-correct.
-# Configuration parameters: AllowSafeAssignment.
+# Configuration parameters: AllowSafeAssignment, AllowInMultilineConditions.
 Style/ParenthesesAroundCondition:
   Exclude:
     - 'lib/oxidized/model/ios.rb'
     - 'lib/oxidized/model/powerconnect.rb'
     - 'lib/oxidized/source/http.rb'
@@ -532,16 +537,15 @@
 # Cop supports --auto-correct.
 Style/Proc:
   Exclude:
     - 'lib/oxidized/hook/githubrepo.rb'
 
-# Offense count: 10
+# Offense count: 9
 # Cop supports --auto-correct.
 Style/RedundantBegin:
   Exclude:
     - 'lib/oxidized/input/telnet.rb'
-    - 'lib/oxidized/manager.rb'
     - 'lib/oxidized/output/git.rb'
     - 'lib/oxidized/output/gitcrypt.rb'
 
 # Offense count: 4
 # Cop supports --auto-correct.
@@ -696,19 +700,18 @@
 # SupportedStyles: percent, brackets
 Style/WordArray:
   EnforcedStyle: percent
   MinSize: 3
 
-# Offense count: 4
+# Offense count: 3
 # Cop supports --auto-correct.
 Style/ZeroLengthPredicate:
   Exclude:
     - 'lib/oxidized/core.rb'
-    - 'lib/oxidized/input/telnet.rb'
     - 'lib/oxidized/model/ciscosmb.rb'
     - 'lib/oxidized/output/git.rb'
 
-# Offense count: 300
+# Offense count: 306
 # Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
 # URISchemes: http, https
 Metrics/LineLength:
-  Max: 283
+  Max: 193