lib/opentelemetry/instrumentation/mysql2/patches/client.rb in opentelemetry-instrumentation-mysql2-0.8.0 vs lib/opentelemetry/instrumentation/mysql2/patches/client.rb in opentelemetry-instrumentation-mysql2-0.9.0
- old
+ new
@@ -43,15 +43,15 @@
end
private
def database_span_name(sql)
- # Without obfuscation SQL Queries, setting span name
- # To the sql query woud result in PII+Cardinality issues
+ # Setting span name to the SQL query without obfuscation would
+ # result in PII + cardinality issues.
# First attempt to infer the statement type then fallback to
- # Current Otel apprroach {database.component_name}.{database_instance_name}
+ # current Otel approach {database.component_name}.{database_instance_name}
# https://github.com/open-telemetry/opentelemetry-python/blob/39fa078312e6f41c403aa8cad1868264011f7546/ext/opentelemetry-ext-dbapi/tests/test_dbapi_integration.py#L53
- # This would create span names like mysql.default, mysql.replica, postgresql.staging etc etc
+ # This creates span names like mysql.default, mysql.replica, postgresql.staging etc.
statement_type = extract_statement_type(sql)
return statement_type unless statement_type.nil?