tracer_middleware.rb in opentelemetry-instrumentation-faraday-0.24.7

- old
+ new

@@ -7,11 +7,11 @@
 module OpenTelemetry
   module Instrumentation
     module Faraday
       module Middlewares
         # TracerMiddleware propagates context and instruments Faraday requests
-        # by way of its middlware system
+        # by way of its middleware system
         class TracerMiddleware < ::Faraday::Middleware
           HTTP_METHODS_SYMBOL_TO_STRING = {
             connect: 'CONNECT',
             delete: 'DELETE',
             get: 'GET',
@@ -21,10 +21,13 @@
             post: 'POST',
             put: 'PUT',
             trace: 'TRACE'
           }.freeze
 
+          # Constant for the HTTP status range
+          HTTP_STATUS_SUCCESS_RANGE = (100..399)
+
           def call(env)
             http_method = HTTP_METHODS_SYMBOL_TO_STRING[env.method]
             config = Faraday::Instrumentation.instance.config
 
             attributes = span_creation_attributes(
@@ -66,10 +69,10 @@
             Faraday::Instrumentation.instance.tracer
           end
 
           def trace_response(span, status)
             span.set_attribute('http.status_code', status)
-            span.status = OpenTelemetry::Trace::Status.error unless (100..399).cover?(status.to_i)
+            span.status = OpenTelemetry::Trace::Status.error unless HTTP_STATUS_SUCCESS_RANGE.cover?(status.to_i)
           end
         end
       end
     end
   end