lib/opentelemetry/trace.rb in opentelemetry-api-1.2.2 vs lib/opentelemetry/trace.rb in opentelemetry-api-1.2.3

@@ -24,24 +24,22 @@
     # Generates a valid trace identifier, a 16-byte string with at least one
     # non-zero byte.
     #
     # @return [String] a valid trace ID.
     def generate_trace_id
-      loop do
-        id = Random.bytes(16)
-        return id unless id == INVALID_TRACE_ID
-      end
+      id = Random.bytes(16)
+      id = Random.bytes(16) while id == INVALID_TRACE_ID
+      id
     end
 
     # Generates a valid span identifier, an 8-byte string with at least one
     # non-zero byte.
     #
     # @return [String] a valid span ID.
     def generate_span_id
-      loop do
-        id = Random.bytes(8)
-        return id unless id == INVALID_SPAN_ID
-      end
+      id = Random.bytes(8)
+      id = Random.bytes(8) while id == INVALID_SPAN_ID
+      id
     end
 
     # Returns the current span from the current or provided context
     #
     # @param [optional Context] context The context to lookup the current