lib/openstudio-standards/standards/necb/ECMS/erv.rb in openstudio-standards-0.2.16 vs lib/openstudio-standards/standards/necb/ECMS/erv.rb in openstudio-standards-0.2.17.rc1

@@ -1,8 +1,9 @@
 class ECMS
-  # This method will add a skeleton erv to all air loops if requested.
-  def apply_erv_ecm(model:, erv_package: nil)
+  # This method will set the properties of the ERV. Must be run after the standard efficiency is complete as this will overwrite
+  # those values. See data/erv.json to view/add different erv packages available.
+  def apply_erv_ecm_efficiency(model:, erv_package: nil)
     # If erv is nil.. do nothing.
     return if erv_package.nil? || erv_package == 'none' || erv_package == 'NECB_Default'
 
     erv_info = @standards_data['tables']['erv']['table'].detect { |item| item['erv_name'] == erv_package }
     # Check if we were able to get data.
@@ -11,22 +12,19 @@
       valid = @standards_data['tables']['erv']['table'].map { |x| x['erv_name'] }
       # tell user.
       raise("ERV package name #{erv_package} does not exist. must be #{valid} /n Stopping.")
     end
 
-    # remove all existing ERVs
-    model.getHeatExchangerAirToAirSensibleAndLatents.each(&:remove) if erv_info['application'] == 'Add_ERVs_To_All_Airloops'
-    # add ervs
-    # Adds default erv to all air_loops. This will be changed in the set efficiency methods.
-    model.getAirLoopHVACs.each { |air_loop| air_loop_hvac_apply_energy_recovery_ventilator(air_loop, nil) } if erv_info['application'] == 'Add_ERVs_To_All_Airloops'
-  end
+    # add ervs if required
+    model.getAirLoopHVACs.sort.each do |air_loop|
+      if air_loop.airLoopHVACOutdoorAirSystem.is_initialized
+        erv = air_loop.airLoopHVACOutdoorAirSystem.get.components.select{|comp| comp.to_HeatExchangerAirToAirSensibleAndLatent.is_initialized}
+        if (erv.empty? && (erv_info['application'] == 'Add_ERVs_To_All_Airloops'))
+          air_loop_hvac_apply_energy_recovery_ventilator(air_loop, nil)
+        end
+      end
+    end
 
-  # This method will set the properties of the ERV that was added above. Must be run after the standard efficiency is complete as this will overwrite
-  # those values. See data/erv.json to view/add different erv packages.
-  def apply_erv_ecm_efficiency(model:, erv_package: nil)
-    # If erv is nil.. do nothing.
-    return if erv_package.nil? || erv_package == 'none' || erv_package == 'NECB_Default'
-
-    # This calls the NECB2011 implementation of the method.
+    # Apply ecm effectiveness values
     model.getHeatExchangerAirToAirSensibleAndLatents.each { |erv| heat_exchanger_air_to_air_sensible_and_latent_apply_effectiveness(erv, erv_package) }
   end
 end