lib/oneaccess/api/v3_0/providers.rb in oneaccess-1.0.0 vs lib/oneaccess/api/v3_0/providers.rb in oneaccess-1.0.1

@@ -17,41 +17,39 @@
               subject:         subject,
               emailbody:       email_body,
               receivedate:     receive_date
             }.reject { |_, v| v.nil? }
 
-            resp = send_post("inducements", inducement: params)
-
-            Response::InducementResponse.from_json(resp.body)
+            response = send_post("inducements", inducement: params)
+            Response::InducementResponse.from_json(response.body)
           end
 
-          def users_details( # rubocop:disable Metrics/MethodLength
+          # rubocop:disable Metrics/MethodLength
+          def users_details(
             buy_side_org_id:,
             provider_id:,
             contract_status_id: nil,
             user_id: nil,
             user_email: nil,
             user_reverse_entitlement_status: nil,
             vendor_id: nil,
             reverse_entitlement_status: nil
           )
 
-            provider_id = comma_separated_values(provider_id)
-
             params = {
               buysideorgid:                 buy_side_org_id,
               contractstatusid:             contract_status_id,
               userid:                       user_id,
               useremail:                    user_email,
               userreverseentitlementstatus: user_reverse_entitlement_status,
               vendorid:                     vendor_id,
               reverseentitlementstatus:     reverse_entitlement_status
-            }.reject { |_, value| value.nil? }
+            }.compact!
 
-            resp = send_get("GetProviderUserDetails?providerid=#{provider_id}", params)
-
+            resp = send_get("GetProviderUserDetails?providerid=#{comma_separated_values(provider_id)}", params)
             Response::ProvidersUsersDetailsResponse.from_json(resp.body)
           end
+          # rubocop:enable Metrics/MethodLength
 
           private
 
           # We need to diffently handle comma separated values since the RestClient,
           # gem URI encode the commas and this is not supported by the API.