spec/happymapper_spec.rb in nokogiri-happymapper-0.6.0 vs spec/happymapper_spec.rb in nokogiri-happymapper-0.7.0

@@ -1,5 +1,7 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 require 'uri'
 
 module Analytics
   class Property
@@ -37,25 +39,24 @@
   class Profile
     include HappyMapper
 
     tag 'entry'
     element :title, String
-    element :tableId, String, :namespace => 'dxp'
+    element :tableId, String, namespace: 'dxp'
 
     has_many :properties, Property
     has_many :goals, Goal
   end
 
-
   class Entry
     include HappyMapper
 
     tag 'entry'
     element :id, String
     element :updated, DateTime
     element :title, String
-    element :table_id, String, :namespace => 'dxp', :tag => 'tableId'
+    element :table_id, String, namespace: 'dxp', tag: 'tableId'
     has_many :properties, Property
   end
 
   class Feed
     include HappyMapper
@@ -71,19 +72,19 @@
 module Atom
   class Feed
     include HappyMapper
     tag 'feed'
 
-    attribute :xmlns, String, :single => true
-    element :id, String, :single => true
-    element :title, String, :single => true
-    element :updated, DateTime, :single => true
-    element :link, String, :single => false, :attributes => {
-        :rel => String,
-        :type => String,
-        :href => String
-      }
+    attribute :xmlns, String, single: true
+    element :id, String, single: true
+    element :title, String, single: true
+    element :updated, DateTime, single: true
+    element :link, String, single: false, attributes: {
+      rel: String,
+      type: String,
+      href: String
+    }
     # has_many :entries, Entry # nothing interesting in the entries
   end
 end
 
 class Country
@@ -91,11 +92,10 @@
 
   attribute :code, String
   content :name, String
 end
 
-
 class State
   include HappyMapper
 end
 
 class Address
@@ -113,11 +113,11 @@
   has_one :state, State
 end
 
 class Feature
   include HappyMapper
-  element :name, String, :xpath => './/text()'
+  element :name, String, xpath: './/text()'
 end
 
 class FeatureBullet
   include HappyMapper
 
@@ -141,11 +141,11 @@
 module FamilySearch
   class AlternateIds
     include HappyMapper
 
     tag 'alternateIds'
-    has_many :ids, String, :tag => 'id'
+    has_many :ids, String, tag: 'id'
   end
 
   class Information
     include HappyMapper
 
@@ -169,105 +169,105 @@
   class FamilyTree
     include HappyMapper
 
     tag 'familytree'
     attribute :version, String
-    attribute :status_message, String, :tag => 'statusMessage'
-    attribute :status_code, String, :tag => 'statusCode'
+    attribute :status_message, String, tag: 'statusMessage'
+    attribute :status_code, String, tag: 'statusCode'
     has_one :persons, Persons
   end
 end
 
 module FedEx
   class Address
     include HappyMapper
 
     tag 'Address'
     namespace 'v2'
-    element :city, String, :tag => 'City'
-    element :state, String, :tag => 'StateOrProvinceCode'
-    element :zip, String, :tag => 'PostalCode'
-    element :countrycode, String, :tag => 'CountryCode'
-    element :residential, Boolean, :tag => 'Residential'
+    element :city, String, tag: 'City'
+    element :state, String, tag: 'StateOrProvinceCode'
+    element :zip, String, tag: 'PostalCode'
+    element :countrycode, String, tag: 'CountryCode'
+    element :residential, Boolean, tag: 'Residential'
   end
 
   class Event
     include HappyMapper
 
     tag 'Events'
     namespace 'v2'
-    element :timestamp, String, :tag => 'Timestamp'
-    element :eventtype, String, :tag => 'EventType'
-    element :eventdescription, String, :tag => 'EventDescription'
+    element :timestamp, String, tag: 'Timestamp'
+    element :eventtype, String, tag: 'EventType'
+    element :eventdescription, String, tag: 'EventDescription'
     has_one :address, Address
   end
 
   class PackageWeight
     include HappyMapper
 
     tag 'PackageWeight'
     namespace 'v2'
-    element :units, String, :tag => 'Units'
-    element :value, Integer, :tag => 'Value'
+    element :units, String, tag: 'Units'
+    element :value, Integer, tag: 'Value'
   end
 
   class TrackDetails
     include HappyMapper
 
     tag 'TrackDetails'
     namespace 'v2'
-    element   :tracking_number, String, :tag => 'TrackingNumber'
-    element   :status_code, String, :tag => 'StatusCode'
-    element   :status_desc, String, :tag => 'StatusDescription'
-    element   :carrier_code, String, :tag => 'CarrierCode'
-    element   :service_info, String, :tag => 'ServiceInfo'
-    has_one   :weight, PackageWeight, :tag => 'PackageWeight'
-    element   :est_delivery,  String, :tag => 'EstimatedDeliveryTimestamp'
+    element   :tracking_number, String, tag: 'TrackingNumber'
+    element   :status_code, String, tag: 'StatusCode'
+    element   :status_desc, String, tag: 'StatusDescription'
+    element   :carrier_code, String, tag: 'CarrierCode'
+    element   :service_info, String, tag: 'ServiceInfo'
+    has_one   :weight, PackageWeight, tag: 'PackageWeight'
+    element   :est_delivery, String, tag: 'EstimatedDeliveryTimestamp'
     has_many  :events, Event
   end
 
   class Notification
     include HappyMapper
 
     tag 'Notifications'
     namespace 'v2'
-    element :severity, String, :tag => 'Severity'
-    element :source, String, :tag => 'Source'
-    element :code, Integer, :tag => 'Code'
-    element :message, String, :tag => 'Message'
-    element :localized_message, String, :tag => 'LocalizedMessage'
+    element :severity, String, tag: 'Severity'
+    element :source, String, tag: 'Source'
+    element :code, Integer, tag: 'Code'
+    element :message, String, tag: 'Message'
+    element :localized_message, String, tag: 'LocalizedMessage'
   end
 
   class TransactionDetail
     include HappyMapper
 
     tag 'TransactionDetail'
     namespace 'v2'
-    element :cust_tran_id, String, :tag => 'CustomerTransactionId'
+    element :cust_tran_id, String, tag: 'CustomerTransactionId'
   end
 
   class TrackReply
     include HappyMapper
 
     tag 'TrackReply'
     namespace 'v2'
-    element   :highest_severity, String, :tag => 'HighestSeverity'
-    element   :more_data, Boolean, :tag => 'MoreData'
-    has_many  :notifications, Notification, :tag => 'Notifications'
-    has_many  :trackdetails, TrackDetails, :tag => 'TrackDetails'
-    has_one   :tran_detail, TransactionDetail, :tab => 'TransactionDetail'
+    element   :highest_severity, String, tag: 'HighestSeverity'
+    element   :more_data, Boolean, tag: 'MoreData'
+    has_many  :notifications, Notification, tag: 'Notifications'
+    has_many  :trackdetails, TrackDetails, tag: 'TrackDetails'
+    has_one   :tran_detail, TransactionDetail, tab: 'TransactionDetail'
   end
 end
 
 class Place
   include HappyMapper
   element :name, String
 end
 
 class Radar
   include HappyMapper
-  has_many :places, Place, :tag => :place
+  has_many :places, Place, tag: :place
 end
 
 class Post
   include HappyMapper
 
@@ -295,64 +295,64 @@
 end
 
 class Status
   include HappyMapper
 
-  register_namespace 'fake', "faka:namespace"
+  register_namespace 'fake', 'faka:namespace'
 
   element :id, Integer
   element :text, String
   element :created_at, Time
   element :source, String
   element :truncated, Boolean
   element :in_reply_to_status_id, Integer
   element :in_reply_to_user_id, Integer
   element :favorited, Boolean
-  element :non_existent, String, :tag => 'dummy', :namespace => 'fake'
+  element :non_existent, String, tag: 'dummy', namespace: 'fake'
   has_one :user, User
 end
 
 class CurrentWeather
   include HappyMapper
 
   tag 'ob'
   namespace 'aws'
-  element :temperature, Integer, :tag => 'temp'
-  element :feels_like, Integer, :tag => 'feels-like'
-  element :current_condition, String, :tag => 'current-condition', :attributes => {:icon => String}
+  element :temperature, Integer, tag: 'temp'
+  element :feels_like, Integer, tag: 'feels-like'
+  element :current_condition, String, tag: 'current-condition', attributes: { icon: String }
 end
 
 # for type coercion
 class ProductGroup < String; end
 
 module PITA
   class Item
     include HappyMapper
 
     tag 'Item' # if you put class in module you need tag
-    element :asin, String, :tag => 'ASIN'
-    element :detail_page_url, URI, :tag => 'DetailPageURL', :parser => :parse
-    element :manufacturer, String, :tag => 'Manufacturer', :deep => true
-    element :point, String, :tag => 'point', :namespace => 'georss'
-    element :product_group, ProductGroup, :tag => 'ProductGroup', :deep => true, :parser => :new, :raw => true
+    element :asin, String, tag: 'ASIN'
+    element :detail_page_url, URI, tag: 'DetailPageURL', parser: :parse
+    element :manufacturer, String, tag: 'Manufacturer', deep: true
+    element :point, String, tag: 'point', namespace: 'georss'
+    element :product_group, ProductGroup, tag: 'ProductGroup', deep: true, parser: :new, raw: true
   end
 
   class Items
     include HappyMapper
 
     tag 'Items' # if you put class in module you need tag
-    element :total_results, Integer, :tag => 'TotalResults'
-    element :total_pages, Integer, :tag => 'TotalPages'
+    element :total_results, Integer, tag: 'TotalResults'
+    element :total_pages, Integer, tag: 'TotalPages'
     has_many :items, Item
   end
 end
 
 module GitHub
   class Commit
     include HappyMapper
 
-    tag "commit"
+    tag 'commit'
     element :url, String
     element :tree, String
     element :message, String
     element :id, String
     element :'committed-date', Date
@@ -380,59 +380,59 @@
     # called 'quarter' with an attribute indicating which quarter
     # it represented, but the refactoring that allows a single class
     # to be used for all these differently named elements is the next
     # best thing
     has_one :details, QuarterTest::Details
-    has_one :q1, QuarterTest::Quarter, :tag => 'q1'
-    has_one :q2, QuarterTest::Quarter, :tag => 'q2'
-    has_one :q3, QuarterTest::Quarter, :tag => 'q3'
-    has_one :q4, QuarterTest::Quarter, :tag => 'q4'
+    has_one :q1, QuarterTest::Quarter, tag: 'q1'
+    has_one :q2, QuarterTest::Quarter, tag: 'q2'
+    has_one :q3, QuarterTest::Quarter, tag: 'q3'
+    has_one :q4, QuarterTest::Quarter, tag: 'q4'
   end
 end
 
 # To check for multiple primitives
 class Artist
   include HappyMapper
 
   tag 'artist'
-  element :images, String, :tag => "image", :single => false
+  element :images, String, tag: 'image', single: false
   element :name, String
 end
 
 class Location
   include HappyMapper
 
   tag 'point'
-  namespace "geo"
-  element :latitude, String, :tag => "lat"
+  namespace 'geo'
+  element :latitude, String, tag: 'lat'
 end
 
 # Testing the XmlContent type
 module Dictionary
   class Variant
     include HappyMapper
     tag 'var'
     has_xml_content
 
     def to_html
-      xml_content.gsub('<tag>','<em>').gsub('</tag>','</em>')
+      xml_content.gsub('<tag>', '<em>').gsub('</tag>', '</em>')
     end
   end
 
   class Definition
     include HappyMapper
 
     tag 'def'
-    element :text, XmlContent, :tag => 'dtext'
+    element :text, XmlContent, tag: 'dtext'
   end
 
   class Record
     include HappyMapper
 
     tag 'record'
     has_many :definitions, Definition
-    has_many :variants, Variant, :tag => 'var'
+    has_many :variants, Variant, tag: 'var'
   end
 end
 
 module AmbigousItems
   class Item
@@ -447,20 +447,19 @@
 class PublishOptions
   include HappyMapper
 
   tag 'publishOptions'
 
-  element :author, String, :tag => 'author'
+  element :author, String, tag: 'author'
 
-  element :draft, Boolean, :tag => 'draft'
-  element :scheduled_day, String, :tag => 'scheduledDay'
-  element :scheduled_time, String, :tag => 'scheduledTime'
-  element :published_day, String, :tag => 'publishDisplayDay'
-  element :published_time, String, :tag => 'publishDisplayTime'
-  element :created_day, String, :tag => 'publishDisplayDay'
-  element :created_time, String, :tag => 'publishDisplayTime'
-
+  element :draft, Boolean, tag: 'draft'
+  element :scheduled_day, String, tag: 'scheduledDay'
+  element :scheduled_time, String, tag: 'scheduledTime'
+  element :published_day, String, tag: 'publishDisplayDay'
+  element :published_time, String, tag: 'publishDisplayTime'
+  element :created_day, String, tag: 'publishDisplayDay'
+  element :created_time, String, tag: 'publishDisplayTime'
 end
 
 class Article
   include HappyMapper
 
@@ -469,15 +468,14 @@
 
   attr_writer :xml_value
 
   element :title, String
   element :text, String
-  has_many :photos, 'Photo', :tag => 'Photo', :namespace => 'photo', :xpath => '/article:Article'
-  has_many :galleries, 'Gallery', :tag => 'Gallery', :namespace => 'gallery'
+  has_many :photos, 'Photo', tag: 'Photo', namespace: 'photo', xpath: '/article:Article'
+  has_many :galleries, 'Gallery', tag: 'Gallery', namespace: 'gallery'
 
-  element :publish_options, PublishOptions, :tag => 'publishOptions', :namespace => 'article'
-
+  element :publish_options, PublishOptions, tag: 'publishOptions', namespace: 'article'
 end
 
 class PartiallyBadArticle
   include HappyMapper
 
@@ -486,15 +484,14 @@
   tag 'Article'
   namespace 'article'
 
   element :title, String
   element :text, String
-  has_many :photos, 'Photo', :tag => 'Photo', :namespace => 'photo', :xpath => '/article:Article'
-  has_many :videos, 'Video', :tag => 'Video', :namespace => 'video'
+  has_many :photos, 'Photo', tag: 'Photo', namespace: 'photo', xpath: '/article:Article'
+  has_many :videos, 'Video', tag: 'Video', namespace: 'video'
 
-  element :publish_options, PublishOptions, :tag => 'publishOptions', :namespace => 'article'
-
+  element :publish_options, PublishOptions, tag: 'publishOptions', namespace: 'article'
 end
 
 class Photo
   include HappyMapper
 
@@ -502,12 +499,11 @@
   namespace 'photo'
 
   attr_writer :xml_value
 
   element :title, String
-  element :publish_options, PublishOptions, :tag => 'publishOptions', :namespace => 'photo'
-
+  element :publish_options, PublishOptions, tag: 'publishOptions', namespace: 'photo'
 end
 
 class Gallery
   include HappyMapper
 
@@ -515,11 +511,10 @@
   namespace 'gallery'
 
   attr_writer :xml_value
 
   element :title, String
-
 end
 
 class Video
   include HappyMapper
 
@@ -527,12 +522,11 @@
   namespace 'video'
 
   attr_writer :xml_value
 
   element :title, String
-  element :publish_options, PublishOptions, :tag => 'publishOptions', :namespace => 'video'
-
+  element :publish_options, PublishOptions, tag: 'publishOptions', namespace: 'video'
 end
 
 class OptionalAttribute
   include HappyMapper
   tag 'address'
@@ -541,166 +535,171 @@
 end
 
 class DefaultNamespaceCombi
   include HappyMapper
 
-
-  register_namespace 'bk', "urn:loc.gov:books"
-  register_namespace 'isbn', "urn:ISBN:0-395-36341-6"
-  register_namespace 'p', "urn:loc.gov:people"
+  register_namespace 'bk', 'urn:loc.gov:books'
+  register_namespace 'isbn', 'urn:ISBN:0-395-36341-6'
+  register_namespace 'p', 'urn:loc.gov:people'
   namespace 'bk'
 
   tag 'book'
 
-  element :title, String, :namespace => 'bk', :tag => "title"
-  element :number, String, :namespace => 'isbn', :tag => "number"
-  element :author, String, :namespace => 'p', :tag => "author"
+  element :title, String, namespace: 'bk', tag: 'title'
+  element :number, String, namespace: 'isbn', tag: 'number'
+  element :author, String, namespace: 'p', tag: 'author'
 end
 
 describe HappyMapper do
-
-  describe "being included into another class" do
+  describe 'being included into another class' do
     before do
       @klass = Class.new do
         include HappyMapper
 
-        def self.to_s
+        def self.name
           'Boo'
         end
       end
     end
 
-    class Boo; include HappyMapper end
-
-    it "should set attributes to an array" do
+    it 'should set attributes to an array' do
       expect(@klass.attributes).to eq([])
     end
 
-    it "should set @elements to a hash" do
+    it 'should set @elements to a hash' do
       expect(@klass.elements).to eq([])
     end
 
-    it "should allow adding an attribute" do
-      expect {
+    it 'should allow adding an attribute' do
+      expect do
         @klass.attribute :name, String
-      }.to change(@klass, :attributes)
+      end.to change(@klass, :attributes)
     end
 
-    it "should allow adding an attribute containing a dash" do
-      expect {
+    it 'should allow adding an attribute containing a dash' do
+      expect do
         @klass.attribute :'bar-baz', String
-      }.to change(@klass, :attributes)
+      end.to change(@klass, :attributes)
     end
 
-    it "should be able to get all attributes in array" do
+    it 'should be able to get all attributes in array' do
       @klass.attribute :name, String
       expect(@klass.attributes.size).to eq(1)
     end
 
-    it "should allow adding an element" do
-      expect {
+    it 'should allow adding an element' do
+      expect do
         @klass.element :name, String
-      }.to change(@klass, :elements)
+      end.to change(@klass, :elements)
     end
 
-    it "should allow adding an element containing a dash" do
-      expect {
+    it 'should allow adding an element containing a dash' do
+      expect do
         @klass.element :'bar-baz', String
-      }.to change(@klass, :elements)
-
+      end.to change(@klass, :elements)
     end
 
-    it "should be able to get all elements in array" do
+    it 'should be able to get all elements in array' do
       @klass.element(:name, String)
       expect(@klass.elements.size).to eq(1)
     end
 
-    it "should allow has one association" do
+    it 'should allow has one association' do
       @klass.has_one(:user, User)
       element = @klass.elements.first
       expect(element.name).to eq('user')
       expect(element.type).to eq(User)
       expect(element.options[:single]).to eq(true)
     end
 
-    it "should allow has many association" do
+    it 'should allow has many association' do
       @klass.has_many(:users, User)
       element = @klass.elements.first
       expect(element.name).to eq('users')
       expect(element.type).to eq(User)
       expect(element.options[:single]).to eq(false)
     end
 
-    it "should default tag name to lowercase class" do
+    it 'should default tag name to lowercase class' do
       expect(@klass.tag_name).to eq('boo')
     end
 
-    it "should default tag name of class in modules to the last constant lowercase" do
+    it 'generates no tag name for anonymous class' do
+      @anon = Class.new { include HappyMapper }
+      expect(@anon.tag_name).to be_nil
+    end
+
+    it 'should default tag name of class in modules to the last constant lowercase' do
       module Bar; class Baz; include HappyMapper; end; end
       expect(Bar::Baz.tag_name).to eq('baz')
     end
 
-    it "should allow setting tag name" do
+    it 'should allow setting tag name' do
       @klass.tag('FooBar')
       expect(@klass.tag_name).to eq('FooBar')
     end
 
-    it "should allow setting a namespace" do
-      @klass.namespace(namespace = "boo")
+    it 'should allow setting a namespace' do
+      @klass.namespace(namespace = 'boo')
       expect(@klass.namespace).to eq(namespace)
     end
 
-    it "should provide #parse" do
+    it 'should provide #parse' do
       expect(@klass).to respond_to(:parse)
     end
   end
 
-  describe "#attributes" do
-    it "should only return attributes for the current class" do
+  describe '#attributes' do
+    it 'should only return attributes for the current class' do
       expect(Post.attributes.size).to eq(7)
       expect(Status.attributes.size).to eq(0)
     end
   end
 
-  describe "#elements" do
-    it "should only return elements for the current class" do
+  describe '#elements' do
+    it 'should only return elements for the current class' do
       expect(Post.elements.size).to eq(0)
       expect(Status.elements.size).to eq(10)
     end
   end
 
-  describe "#content" do
-     it "should take String as default argument for type" do
-       State.content :name
-       address = Address.parse(fixture_file('address.xml'))
-       expect(address.state.name).to eq("Lower Saxony")
-       address.state.name.class == String
-     end
+  describe '#content' do
+    it 'should take String as default argument for type' do
+      State.content :name
+      address = Address.parse(fixture_file('address.xml'))
+      expect(address.state.name).to eq('Lower Saxony')
+      address.state.name.class == String
+    end
 
-     it "should work when specific type is provided" do
-       Rate.content :value, Float
-       Product.has_one :rate, Rate
-       product = Product.parse(fixture_file('product_default_namespace.xml'), :single => true)
-       expect(product.rate.value).to eq(120.25)
-       product.rate.class == Float
-     end
+    it 'should work when specific type is provided' do
+      Rate.content :value, Float
+      Product.has_one :rate, Rate
+      product = Product.parse(fixture_file('product_default_namespace.xml'), single: true)
+      expect(product.rate.value).to eq(120.25)
+      product.rate.class == Float
+    end
   end
 
-  it "should parse xml attributes into ruby objects" do
+  it 'should parse xml attributes into ruby objects' do
     posts = Post.parse(fixture_file('posts.xml'))
     expect(posts.size).to eq(20)
     first = posts.first
     expect(first.href).to eq('http://roxml.rubyforge.org/')
     expect(first.hash).to eq('19bba2ab667be03a19f67fb67dc56917')
     expect(first.description).to eq('ROXML - Ruby Object to XML Mapping Library')
     expect(first.tag).to eq('ruby xml gems mapping')
     expect(first.time).to eq(Time.utc(2008, 8, 9, 5, 24, 20))
     expect(first.others).to eq(56)
-    expect(first.extended).to eq('ROXML is a Ruby library designed to make it easier for Ruby developers to work with XML. Using simple annotations, it enables Ruby classes to be custom-mapped to XML. ROXML takes care of the marshalling and unmarshalling of mapped attributes so that developers can focus on building first-class Ruby classes.')
+    expect(first.extended).
+      to eq('ROXML is a Ruby library designed to make it easier for Ruby' \
+            ' developers to work with XML. Using simple annotations, it enables' \
+            ' Ruby classes to be custom-mapped to XML. ROXML takes care of the' \
+            ' marshalling and unmarshalling of mapped attributes so that developers can' \
+            ' focus on building first-class Ruby classes.')
   end
 
-  it "should parse xml elements to ruby objcts" do
+  it 'should parse xml elements to ruby objcts' do
     statuses = Status.parse(fixture_file('statuses.xml'))
     expect(statuses.size).to eq(20)
     first = statuses.first
     expect(first.id).to eq(882281424)
     expect(first.created_at).to eq(Time.utc(2008, 8, 9, 5, 38, 12))
@@ -712,40 +711,41 @@
     expect(first.user.id).to eq(4243)
     expect(first.user.name).to eq('John Nunemaker')
     expect(first.user.screen_name).to eq('jnunemaker')
     expect(first.user.location).to eq('Mishawaka, IN, US')
     expect(first.user.description).to eq('Loves his wife, ruby, notre dame football and iu basketball')
-    expect(first.user.profile_image_url).to eq('http://s3.amazonaws.com/twitter_production/profile_images/53781608/Photo_75_normal.jpg')
+    expect(first.user.profile_image_url).
+      to eq('http://s3.amazonaws.com/twitter_production/profile_images/53781608/Photo_75_normal.jpg')
     expect(first.user.url).to eq('http://addictedtonew.com')
     expect(first.user.protected).to be_falsey
     expect(first.user.followers_count).to eq(486)
   end
 
-  it "should parse xml containing the desired element as root node" do
-    address = Address.parse(fixture_file('address.xml'), :single => true)
+  it 'should parse xml containing the desired element as root node' do
+    address = Address.parse(fixture_file('address.xml'), single: true)
     expect(address.street).to eq('Milchstrasse')
     expect(address.postcode).to eq('26131')
     expect(address.housenumber).to eq('23')
     expect(address.city).to eq('Oldenburg')
     expect(address.country.class).to eq(Country)
   end
 
-  it "should parse text node correctly" do
-    address = Address.parse(fixture_file('address.xml'), :single => true)
+  it 'should parse text node correctly' do
+    address = Address.parse(fixture_file('address.xml'), single: true)
     expect(address.country.name).to eq('Germany')
     expect(address.country.code).to eq('de')
   end
 
-  it "should treat Nokogiri::XML::Document as root" do
+  it 'should treat Nokogiri::XML::Document as root' do
     doc = Nokogiri::XML(fixture_file('address.xml'))
     address = Address.parse(doc)
     expect(address.class).to eq(Address)
   end
 
-  it "should parse xml with default namespace (amazon)" do
+  it 'should parse xml with default namespace (amazon)' do
     file_contents = fixture_file('pita.xml')
-    items = PITA::Items.parse(file_contents, :single => true)
+    items = PITA::Items.parse(file_contents, single: true)
     expect(items.total_results).to eq(22)
     expect(items.total_pages).to eq(3)
     first  = items.items[0]
     second = items.items[1]
     expect(first.asin).to eq('0321480791')
@@ -756,11 +756,11 @@
     expect(first.product_group).to eq('<ProductGroup>Book</ProductGroup>')
     expect(second.asin).to eq('047022388X')
     expect(second.manufacturer).to eq('Wrox')
   end
 
-  it "should parse xml that has attributes of elements" do
+  it 'should parse xml that has attributes of elements' do
     items = CurrentWeather.parse(fixture_file('current_weather.xml'))
     first = items[0]
     expect(first.temperature).to eq(51)
     expect(first.feels_like).to eq(51)
     expect(first.current_condition).to eq('Sunny')
@@ -771,26 +771,26 @@
     feed = Atom::Feed.parse(fixture_file('atom.xml'))
     expect(feed.link.first.href).to eq('http://www.example.com')
     expect(feed.link.last.href).to eq('http://www.example.com/tv_shows.atom')
   end
 
-  it "parses xml with optional elements with embedded attributes" do
-    expect { CurrentWeather.parse(fixture_file('current_weather_missing_elements.xml')) }.to_not raise_error()
+  it 'parses xml with optional elements with embedded attributes' do
+    expect { CurrentWeather.parse(fixture_file('current_weather_missing_elements.xml')) }.to_not raise_error
   end
 
-  it "returns nil rather than empty array for absent values when :single => true" do
-    address = Address.parse('<?xml version="1.0" encoding="UTF-8"?><foo/>', :single => true)
+  it 'returns nil rather than empty array for absent values when :single => true' do
+    address = Address.parse('<?xml version="1.0" encoding="UTF-8"?><foo/>', single: true)
     expect(address).to be_nil
   end
 
-  it "should return same result for absent values when :single => true, regardless of :in_groups_of" do
-    addr1 = Address.parse('<?xml version="1.0" encoding="UTF-8"?><foo/>', :single => true)
-    addr2 = Address.parse('<?xml version="1.0" encoding="UTF-8"?><foo/>', :single => true, :in_groups_of => 10)
+  it 'should return same result for absent values when :single => true, regardless of :in_groups_of' do
+    addr1 = Address.parse('<?xml version="1.0" encoding="UTF-8"?><foo/>', single: true)
+    addr2 = Address.parse('<?xml version="1.0" encoding="UTF-8"?><foo/>', single: true, in_groups_of: 10)
     expect(addr1).to eq(addr2)
   end
 
-  it "should parse xml with nested elements" do
+  it 'should parse xml with nested elements' do
     radars = Radar.parse(fixture_file('radar.xml'))
     first = radars[0]
     expect(first.places.size).to eq(1)
     expect(first.places[0].name).to eq('Store')
     second = radars[1]
@@ -799,53 +799,53 @@
     expect(third.places.size).to eq(2)
     expect(third.places[0].name).to eq('Work')
     expect(third.places[1].name).to eq('Home')
   end
 
-  it "should parse xml with element name different to class name" do
+  it 'should parse xml with element name different to class name' do
     game = QuarterTest::Game.parse(fixture_file('quarters.xml'))
     expect(game.q1.start).to eq('4:40:15 PM')
     expect(game.q2.start).to eq('5:18:53 PM')
   end
 
-  it "should parse xml that has elements with dashes" do
+  it 'should parse xml that has elements with dashes' do
     commit = GitHub::Commit.parse(fixture_file('commit.xml'))
-    expect(commit.message).to eq("move commands.rb and helpers.rb into commands/ dir")
-    expect(commit.url).to eq("http://github.com/defunkt/github-gem/commit/c26d4ce9807ecf57d3f9eefe19ae64e75bcaaa8b")
-    expect(commit.id).to eq("c26d4ce9807ecf57d3f9eefe19ae64e75bcaaa8b")
-    expect(commit.committed_date).to eq(Date.parse("2008-03-02T16:45:41-08:00"))
-    expect(commit.tree).to eq("28a1a1ca3e663d35ba8bf07d3f1781af71359b76")
+    expect(commit.message).to eq('move commands.rb and helpers.rb into commands/ dir')
+    expect(commit.url).to eq('http://github.com/defunkt/github-gem/commit/c26d4ce9807ecf57d3f9eefe19ae64e75bcaaa8b')
+    expect(commit.id).to eq('c26d4ce9807ecf57d3f9eefe19ae64e75bcaaa8b')
+    expect(commit.committed_date).to eq(Date.parse('2008-03-02T16:45:41-08:00'))
+    expect(commit.tree).to eq('28a1a1ca3e663d35ba8bf07d3f1781af71359b76')
   end
 
-  it "should parse xml with no namespace" do
-    product = Product.parse(fixture_file('product_no_namespace.xml'), :single => true)
-    expect(product.title).to eq("A Title")
+  it 'should parse xml with no namespace' do
+    product = Product.parse(fixture_file('product_no_namespace.xml'), single: true)
+    expect(product.title).to eq('A Title')
     expect(product.feature_bullets.bug).to eq('This is a bug')
     expect(product.feature_bullets.features.size).to eq(2)
     expect(product.feature_bullets.features[0].name).to eq('This is feature text 1')
     expect(product.feature_bullets.features[1].name).to eq('This is feature text 2')
   end
 
-  it "should parse xml with default namespace" do
-    product = Product.parse(fixture_file('product_default_namespace.xml'), :single => true)
-    expect(product.title).to eq("A Title")
+  it 'should parse xml with default namespace' do
+    product = Product.parse(fixture_file('product_default_namespace.xml'), single: true)
+    expect(product.title).to eq('A Title')
     expect(product.feature_bullets.bug).to eq('This is a bug')
     expect(product.feature_bullets.features.size).to eq(2)
     expect(product.feature_bullets.features[0].name).to eq('This is feature text 1')
     expect(product.feature_bullets.features[1].name).to eq('This is feature text 2')
   end
 
-  it "should parse xml with single namespace" do
-    product = Product.parse(fixture_file('product_single_namespace.xml'), :single => true)
-    expect(product.title).to eq("A Title")
+  it 'should parse xml with single namespace' do
+    product = Product.parse(fixture_file('product_single_namespace.xml'), single: true)
+    expect(product.title).to eq('A Title')
     expect(product.feature_bullets.bug).to eq('This is a bug')
     expect(product.feature_bullets.features.size).to eq(2)
     expect(product.feature_bullets.features[0].name).to eq('This is feature text 1')
     expect(product.feature_bullets.features[1].name).to eq('This is feature text 2')
   end
 
-  it "should parse xml with multiple namespaces" do
+  it 'should parse xml with multiple namespaces' do
     track = FedEx::TrackReply.parse(fixture_file('multiple_namespaces.xml'))
     expect(track.highest_severity).to eq('SUCCESS')
     expect(track.more_data).to be_falsey
     notification = track.notifications.first
     expect(notification.code).to eq(0)
@@ -883,11 +883,11 @@
     expect(last_event.address.state).to eq('FL')
     expect(last_event.address.zip).to eq('327506398')
     expect(track.tran_detail.cust_tran_id).to eq('20090102-111321')
   end
 
-  it "should be able to parse google analytics api xml" do
+  it 'should be able to parse google analytics api xml' do
     data = Analytics::Feed.parse(fixture_file('analytics.xml'))
     expect(data.id).to eq('http://www.google.com/analytics/feeds/accounts/[e-mail]')
     expect(data.entries.size).to eq(4)
 
     entry = data.entries[0]
@@ -897,21 +897,21 @@
     property = entry.properties[0]
     expect(property.name).to eq('ga:accountId')
     expect(property.value).to eq('85301')
   end
 
-  it "should be able to parse google analytics profile xml with manually declared namespace" do
+  it 'should be able to parse google analytics profile xml with manually declared namespace' do
     data = Analytics::Profile.parse(fixture_file('analytics_profile.xml'))
     expect(data.entries.size).to eq(6)
 
     entry = data.entries[0]
     expect(entry.title).to eq('www.homedepot.com')
     expect(entry.properties.size).to eq(6)
     expect(entry.goals.size).to eq(0)
   end
 
-  it "should allow instantiating with a string" do
+  it 'should allow instantiating with a string' do
     module StringFoo
       class Bar
         include HappyMapper
         has_many :things, 'StringFoo::Thing'
       end
@@ -920,83 +920,83 @@
         include HappyMapper
       end
     end
   end
 
-  it "should parse family search xml" do
+  it 'should parse family search xml' do
     tree = FamilySearch::FamilyTree.parse(fixture_file('family_tree.xml'))
     expect(tree.version).to eq('1.0.20071213.942')
     expect(tree.status_message).to eq('OK')
     expect(tree.status_code).to eq('200')
     expect(tree.persons.person.size).to eq(1)
     expect(tree.persons.person.first.version).to eq('1199378491000')
-    expect(tree.persons.person.first.modified).to eq(Time.utc(2008, 1, 3, 16, 41, 31)) # 2008-01-03T09:41:31-07:00
+    expect(tree.persons.person.first.modified).
+      to eq(Time.utc(2008, 1, 3, 16, 41, 31)) # 2008-01-03T09:41:31-07:00
     expect(tree.persons.person.first.id).to eq('KWQS-BBQ')
     expect(tree.persons.person.first.information.alternateIds.ids).not_to be_kind_of(String)
     expect(tree.persons.person.first.information.alternateIds.ids.size).to eq(8)
   end
 
-  it "should parse multiple images" do
+  it 'should parse multiple images' do
     artist = Artist.parse(fixture_file('multiple_primitives.xml'))
-    expect(artist.name).to eq("value")
+    expect(artist.name).to eq('value')
     expect(artist.images.size).to eq(2)
   end
 
-  it "should parse lastfm namespaces" do
+  it 'should parse lastfm namespaces' do
     l = Location.parse(fixture_file('lastfm.xml'))
-    expect(l.first.latitude).to eq("51.53469")
+    expect(l.first.latitude).to eq('51.53469')
   end
 
-  describe "Parse optional attributes" do
-
-    it "should parse an empty String as empty" do
+  describe 'Parse optional attributes' do
+    it 'should parse an empty String as empty' do
       a = OptionalAttribute.parse(fixture_file('optional_attributes.xml'))
-      expect(a[0].street).to eq("")
+      expect(a[0].street).to eq('')
     end
 
-    it "should parse a String with value" do
+    it 'should parse a String with value' do
       a = OptionalAttribute.parse(fixture_file('optional_attributes.xml'))
-      expect(a[1].street).to eq("Milchstrasse")
+      expect(a[1].street).to eq('Milchstrasse')
     end
 
-    it "should parse a String with value" do
+    it 'should parse a String with value' do
       a = OptionalAttribute.parse(fixture_file('optional_attributes.xml'))
       expect(a[2].street).to be_nil
     end
-
   end
 
-  describe "Default namespace combi" do
+  describe 'Default namespace combi' do
     before(:each) do
       file_contents = fixture_file('default_namespace_combi.xml')
-      @book = DefaultNamespaceCombi.parse(file_contents, :single => true)
+      @book = DefaultNamespaceCombi.parse(file_contents, single: true)
     end
 
-    it "should parse author" do
-      expect(@book.author).to eq("Frank Gilbreth")
+    it 'should parse author' do
+      expect(@book.author).to eq('Frank Gilbreth')
     end
 
-    it "should parse title" do
-      expect(@book.title).to eq("Cheaper by the Dozen")
+    it 'should parse title' do
+      expect(@book.title).to eq('Cheaper by the Dozen')
     end
 
-    it "should parse number" do
-      expect(@book.number).to eq("1568491379")
+    it 'should parse number' do
+      expect(@book.number).to eq('1568491379')
     end
-
   end
 
   describe 'Xml Content' do
     before(:each) do
       file_contents = fixture_file('dictionary.xml')
       @records = Dictionary::Record.parse(file_contents)
     end
 
-    it "should parse XmlContent" do
-      expect(@records.first.definitions.first.text).to eq(
-        'a large common parrot, <bn>Cacatua galerita</bn>, predominantly white, with yellow on the undersides of wings and tail and a forward curving yellow crest, found in Australia, New Guinea and nearby islands.'
-      )
+    it 'should parse XmlContent' do
+      expect(@records.first.definitions.first.text).
+        to eq('a large common parrot, <bn>Cacatua galerita</bn>, predominantly' \
+              ' white, with yellow on the undersides of wings and tail and a' \
+              ' forward curving yellow crest, found in Australia, New Guinea' \
+              ' and nearby islands.')
     end
 
     it "should save object's xml content" do
       expect(@records.first.variants.first.xml_content).to eq(
         'white <tag>cockatoo</tag>'
@@ -1005,95 +1005,91 @@
         '<em>white</em> cockatoo'
       )
     end
   end
 
-  it "should parse ambigous items" do
-    items = AmbigousItems::Item.parse(fixture_file('ambigous_items.xml'), :xpath => '/ambigous/my-items')
-    expect(items.map(&:name)).to eq(%w(first second third).map{|s| "My #{s} item" })
+  it 'should parse ambigous items' do
+    items = AmbigousItems::Item.parse(fixture_file('ambigous_items.xml'), xpath: '/ambigous/my-items')
+    expect(items.map(&:name)).to eq(%w(first second third).map { |s| "My #{s} item" })
   end
 
-
   context Article do
-    it "should parse the publish options for Article and Photo" do
+    it 'should parse the publish options for Article and Photo' do
       expect(@article.title).not_to be_nil
       expect(@article.text).not_to be_nil
       expect(@article.photos).not_to be_nil
       expect(@article.photos.first.title).not_to be_nil
     end
 
-    it "should parse the publish options for Article" do
+    it 'should parse the publish options for Article' do
       expect(@article.publish_options).not_to be_nil
     end
 
-    it "should parse the publish options for Photo" do
+    it 'should parse the publish options for Photo' do
       expect(@article.photos.first.publish_options).not_to be_nil
     end
 
-    it "should only find only items at the parent level" do
+    it 'should only find only items at the parent level' do
       expect(@article.photos.length).to eq(1)
     end
 
     before(:all) do
       @article = Article.parse(fixture_file('subclass_namespace.xml'))
     end
+  end
 
+  context 'Namespace is missing because an optional element that uses it is not present' do
+    it 'should parse successfully' do
+      @article = PartiallyBadArticle.parse(fixture_file('subclass_namespace.xml'))
+      expect(@article).not_to be_nil
+      expect(@article.title).not_to be_nil
+      expect(@article.text).not_to be_nil
+      expect(@article.photos).not_to be_nil
+      expect(@article.photos.first.title).not_to be_nil
+    end
   end
 
-  context "Namespace is missing because an optional element that uses it is not present" do
-     it "should parse successfully" do
-       @article = PartiallyBadArticle.parse(fixture_file('subclass_namespace.xml'))
-       expect(@article).not_to be_nil
-       expect(@article.title).not_to be_nil
-       expect(@article.text).not_to be_nil
-       expect(@article.photos).not_to be_nil
-       expect(@article.photos.first.title).not_to be_nil
-     end
-   end
+  describe 'with limit option' do
+    it 'should return results with limited size: 6' do
+      sizes = []
+      Post.parse(fixture_file('posts.xml'), in_groups_of: 6) do |a|
+        sizes << a.size
+      end
+      expect(sizes).to eq([6, 6, 6, 2])
+    end
 
+    it 'should return results with limited size: 10' do
+      sizes = []
+      Post.parse(fixture_file('posts.xml'), in_groups_of: 10) do |a|
+        sizes << a.size
+      end
+      expect(sizes).to eq([10, 10])
+    end
+  end
 
-   describe "with limit option" do
-     it "should return results with limited size: 6" do
-       sizes = []
-       Post.parse(fixture_file('posts.xml'), :in_groups_of => 6) do |a|
-         sizes << a.size
-       end
-       expect(sizes).to eq([6, 6, 6, 2])
-     end
-
-     it "should return results with limited size: 10" do
-       sizes = []
-       Post.parse(fixture_file('posts.xml'), :in_groups_of => 10) do |a|
-         sizes << a.size
-       end
-       expect(sizes).to eq([10, 10])
-     end
-   end
-
-  context "when letting user set Nokogiri::XML::ParseOptions" do
-    let(:default) {
+  context 'when letting user set Nokogiri::XML::ParseOptions' do
+    let(:default) do
       Class.new do
         include HappyMapper
         element :item, String
       end
-    }
-    let(:custom) {
+    end
+    let(:custom) do
       Class.new do
         include HappyMapper
         element :item, String
-        with_nokogiri_config do |config|
-          config.default_xml
-        end
+        with_nokogiri_config(&:default_xml)
       end
-    }
+    end
 
     it 'initializes @nokogiri_config_callback to nil' do
       expect(default.nokogiri_config_callback).to be_nil
     end
 
     it 'defaults to Nokogiri::XML::ParseOptions::STRICT' do
-     expect { default.parse(fixture_file('set_config_options.xml')) }.to raise_error(Nokogiri::XML::SyntaxError)
+      expect { default.parse(fixture_file('set_config_options.xml')) }.
+        to raise_error(Nokogiri::XML::SyntaxError)
     end
 
     it 'accepts .on_config callback' do
       expect(custom.nokogiri_config_callback).not_to be_nil
     end
@@ -1102,28 +1098,39 @@
       expect { custom.parse(fixture_file('set_config_options.xml')) }.to_not raise_error
     end
 
     it 'can clear @nokogiri_config_callback' do
       custom.with_nokogiri_config {}
-      expect { custom.parse(fixture_file('set_config_options.xml')) }.to raise_error(Nokogiri::XML::SyntaxError)
+      expect { custom.parse(fixture_file('set_config_options.xml')) }.
+        to raise_error(Nokogiri::XML::SyntaxError)
     end
   end
 
   context 'xml_value' do
     it 'does not reformat the xml' do
       xml = fixture_file('unformatted_address.xml')
       address = Address.parse(xml, single: true)
 
-      expect(address.xml_value).to eq %{<address><street>Milchstrasse</street><housenumber>23</housenumber></address>}
+      expect(address.xml_value).
+        to eq %(<address><street>Milchstrasse</street><housenumber>23</housenumber></address>)
     end
   end
 
   context 'xml_content' do
     it 'does not reformat the xml' do
       xml = fixture_file('unformatted_address.xml')
       address = Address.parse(xml)
 
-      expect(address.xml_content).to eq %{<street>Milchstrasse</street><housenumber>23</housenumber>}
+      expect(address.xml_content).to eq %(<street>Milchstrasse</street><housenumber>23</housenumber>)
     end
   end
 
+  describe '#to_xml' do
+    let(:original) { '<foo><bar>baz</bar></foo>' }
+    let(:parsed) { described_class.parse original }
+
+    it 'has UTF-8 encoding by default' do
+      expect(original.encoding).to eq Encoding::UTF_8
+      expect(parsed.to_xml.encoding).to eq Encoding::UTF_8
+    end
+  end
 end