.rubocop.yml in newrelic_rpm-8.10.1 vs .rubocop.yml in newrelic_rpm-8.11.0
- old
+ new
@@ -8,11 +8,14 @@
# Default rake configurations: https://github.com/rubocop/rubocop-rake/blob/master/config/default.yml
<%= '- rubocop-rake' if RUBY_VERSION >= '2.4.0' %>
AllCops:
TargetRubyVersion: 2.7
- Exclude: []
+ # Rubocop shouldn't run on auto generated files.
+ Exclude:
+ - 'test/multiverse/suites/active_record/db/schema.rb'
+ - 'test/multiverse/suites/active_record_pg/db/schema.rb'
NewCops: enable
Bundler/DuplicatedGem:
Enabled: true
Include:
@@ -850,13 +853,10 @@
Enabled: false
Lint/RequireRelativeSelfPath:
Enabled: true
-Metrics/AbcSize:
- Enabled: false
-
Metrics/BlockLength:
Enabled: false
Metrics/BlockNesting:
Enabled: false
@@ -938,177 +938,38 @@
# EnforcedStyle: snake_case
Naming/VariableNumber:
Enabled: false
-Performance/AncestorsInclude:
- Enabled: false
-
-Performance/ArraySemiInfiniteRangeSlice:
- Enabled: false
-
-Performance/BigDecimalWithNumericArgument:
- Enabled: true
-
-# Disabled for support of older ruby versions
+# TODO: OLD RUBIES - Requires 2.7
Performance/BindCall:
Enabled: false
-# Disabling for now
-Performance/BlockGivenWithExplicitBlock:
- Enabled: false
-
-# Disabling for now
-Performance/Caller:
- Enabled: false
-
-Performance/CaseWhenSplat:
- Enabled: false
-
-Performance/Casecmp:
- Enabled: false
-
-Performance/ChainArrayAllocation:
- Enabled: false
-
-Performance/CollectionLiteralInLoop:
- Enabled: false
-
-Performance/CompareWithBlock:
- Enabled: true
-
-Performance/ConcurrentMonotonicTime:
- Enabled: true
-
-# Disabling for now
-Performance/ConstantRegexp:
- Enabled: false
-
-# Disabling for now
-Performance/Count:
- Enabled: false
-
+# TODO: OLD RUBIES - Requites 2.5
Performance/DeletePrefix:
Enabled: false
-Performance/DeleteSuffix:
- Enabled: false
-
-# Disabling for now
-Performance/Detect:
- Enabled: false
-
-# Disabling for now
-Performance/DoubleStartEndWith:
- Enabled: false
- # IncludeActiveSupportAliases: false
-
-Performance/EndWith:
- Enabled: true
-
-Performance/FixedSize:
- Enabled: true
-
-Performance/FlatMap:
- Enabled: true
- EnabledForFlattenWithoutParams: false
-
-# Disabling for now
-Performance/InefficientHashSearch:
- Enabled: false
- # Safe: false
-
-Performance/IoReadlines:
- Enabled: false
-
+# TODO: OLD RUBIES - Requires 2.7
Performance/MapCompact:
Enabled: false
+# TODO: Enable when time can be spent on it (no autocorrect)
Performance/MethodObjectAsBlock:
Enabled: false
-Performance/OpenStruct:
- Enabled: false
-
-Performance/RangeInclude:
- Enabled: true
- Safe: false
-
-Performance/RedundantBlockCall:
- Enabled: false
-
-Performance/RedundantEqualityComparisonBlock:
- Enabled: false
-
-# Disabling for now
-Performance/RedundantMatch:
- Enabled: false
-
-# Disabling for now
-Performance/RedundantMerge:
- Enabled: false
- # MaxKeyValuePairs: 2
-
-Performance/RedundantSortBlock:
- Enabled: true
-
-Performance/RedundantSplitRegexpArgument:
- Enabled: true
-
-Performance/RedundantStringChars:
- Enabled: true
-
-# Disabling for now
+# TODO: OLD RUBIES - Requires 2.4
Performance/RegexpMatch:
Enabled: false
-# Disabling for now
-Performance/ReverseEach:
- Enabled: false
-
-Performance/ReverseFirst:
- Enabled: true
-
-Performance/SelectMap:
- Enabled: false
-
-Performance/Size:
- Enabled: true
-
-Performance/SortReverse:
- Enabled: true
-
-Performance/Squeeze:
- Enabled: true
-
-# Disabling for now
-Performance/StartWith:
- Enabled: false
-
-Performance/StringIdentifierArgument:
- Enabled: true
-
-Performance/StringInclude:
- Enabled: false
-
-# Disabling for now
-Performance/StringReplacement:
- Enabled: false
-
+# TODO: OLD RUBIES - Requires 2.4
Performance/Sum:
Enabled: false
-Performance/TimesMap:
- Enabled: false
-
-# Disabling for now
+# TODO: OLD RUBIES - Requires 2.3
Performance/UnfreezeString:
Enabled: false
-Performance/UriDefaultParser:
- Enabled: true
-
# Disabling for now
Security/Eval:
Enabled: false
# Disabling for now
@@ -1238,13 +1099,10 @@
Style/CommandLiteral:
Enabled: false
# EnforcedStyle: mixed
# AllowInnerBackticks: false
-Style/CommentAnnotation:
- Enabled: false
-
Style/CommentedKeyword:
Enabled: false
# Disabling for now
Style/ConditionalAssignment:
@@ -1316,14 +1174,10 @@
# Disabling for now
Style/EmptyMethod:
Enabled: false
# EnforcedStyle: expanded
-# Disabling for now
-Style/Encoding:
- Enabled: false
-
Style/EndBlock:
Enabled: true
AutoCorrect: true
Style/EndlessMethod:
@@ -1474,18 +1328,21 @@
Enabled: false
Style/MethodCallWithArgsParentheses:
Enabled: true
AllowedMethods:
- - puts
- - require
- - raise
- - include
- - fail
- - print
- add_dependency
- add_development_dependency
+ - expect
+ - fail
+ - include
+ - print
+ - puts
+ - raise
+ - require
+ - skip
+ - stub
AllowedPatterns: [^assert, ^refute]
Style/MethodCallWithoutArgsParentheses:
Enabled: false
AllowedMethods: []
@@ -1536,13 +1393,10 @@
# EnforcedStyle: keyword
Style/MultilineMethodSignature:
Enabled: false
-Style/MultilineTernaryOperator:
- Enabled: false
-
Style/MultilineWhenThen:
Enabled: true
Style/MultipleComparison:
Enabled: false
@@ -1593,23 +1447,13 @@
Style/Next:
Enabled: false
# Disabling for now
-Style/NilComparison:
- Enabled: false
- # EnforcedStyle: predicate
-
-# Disabling for now
Style/NilLambda:
Enabled: false
-# Disabling for now
-Style/NonNilCheck:
- Enabled: false
- # IncludeSemanticChanges: false
-
Style/Not:
Enabled: true
# Disabling for now
Style/NumericLiteralPrefix:
@@ -1639,14 +1483,10 @@
Enabled: true
Style/OptionalBooleanParameter:
Enabled: false
-# Disabling for now
-Style/OrAssignment:
- Enabled: false
-
Style/ParallelAssignment:
Enabled: false
Style/ParenthesesAroundCondition:
Enabled: true
@@ -1670,14 +1510,10 @@
Enabled: false
Style/PreferredHashMethods:
Enabled: false
-# Disabling for now
-Style/Proc:
- Enabled: false
-
Style/QuotedSymbols:
Enabled: false
Style/RaiseArgs:
Enabled: false
@@ -1959,12 +1795,9 @@
Style/WhileUntilDo:
Enabled: true
Style/WhileUntilModifier:
- Enabled: false
-
-Style/WordArray:
Enabled: false
# Disabling for now
Style/YodaCondition:
Enabled: false