.rubocop_todo.yml in net-ldap-0.15.0 vs .rubocop_todo.yml in net-ldap-0.16.0

- old
+ new

@@ -1,19 +1,26 @@ # This configuration was generated by # `rubocop --auto-gen-config` -# on 2016-01-08 11:47:42 -0800 using RuboCop version 0.35.0. +# on 2016-08-17 14:58:12 -0700 using RuboCop version 0.42.0. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new # versions of RuboCop, may require this file to be generated again. # Offense count: 1 # Cop supports --auto-correct. # Configuration parameters: AlignWith, SupportedStyles, AutoCorrect. +# SupportedStyles: keyword, variable, start_of_line Lint/EndAlignment: - Enabled: false + Exclude: + - 'testserver/ldapserver.rb' +# Offense count: 30 +Lint/ImplicitStringConcatenation: + Exclude: + - 'test/test_filter.rb' + # Offense count: 1 Lint/NonLocalExitFromIterator: Exclude: - 'lib/net/ldap/connection.rb' @@ -27,98 +34,121 @@ Exclude: - 'lib/net/ldap/instrumentation.rb' # Offense count: 10 # Cop supports --auto-correct. -# Configuration parameters: IgnoreEmptyBlocks. +# Configuration parameters: IgnoreEmptyBlocks, AllowUnusedKeywordArguments. Lint/UnusedBlockArgument: Exclude: - 'lib/net/ldap.rb' - 'lib/net/snmp.rb' - 'test/support/vm/openldap/Vagrantfile' -# Offense count: 3 +# Offense count: 7 # Cop supports --auto-correct. # Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods. Lint/UnusedMethodArgument: Exclude: - 'lib/net/ldap/entry.rb' - 'lib/net/ldap/pdu.rb' + - 'test/test_ldap.rb' + - 'test/test_ldap_connection.rb' - 'test/test_search.rb' +# Offense count: 1 +# Configuration parameters: ContextCreatingMethods. +Lint/UselessAccessModifier: + Exclude: + - 'lib/net/ldap/connection.rb' + # Offense count: 9 Lint/UselessAssignment: Exclude: - 'lib/net/ldap/connection.rb' - 'lib/net/ldap/password.rb' - 'test/integration/test_add.rb' - 'test/test_ldap_connection.rb' - 'test/test_search.rb' - 'test/test_snmp.rb' -# Offense count: 48 +# Offense count: 47 Metrics/AbcSize: Max: 114 # Offense count: 11 Metrics/BlockNesting: Max: 4 # Offense count: 10 # Configuration parameters: CountComments. Metrics/ClassLength: - Max: 423 + Max: 431 -# Offense count: 21 +# Offense count: 22 Metrics/CyclomaticComplexity: Max: 41 -# Offense count: 229 -# Configuration parameters: AllowURI, URISchemes. +# Offense count: 225 +# Configuration parameters: AllowHeredoc, AllowURI, URISchemes. +# URISchemes: http, https Metrics/LineLength: Max: 360 -# Offense count: 71 +# Offense count: 70 # Configuration parameters: CountComments. Metrics/MethodLength: Max: 130 # Offense count: 1 # Configuration parameters: CountComments. Metrics/ModuleLength: Max: 104 -# Offense count: 13 +# Offense count: 14 Metrics/PerceivedComplexity: Max: 37 # Offense count: 1 Style/AccessorMethodName: Exclude: - 'lib/net/ldap.rb' +# Offense count: 10 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle, SupportedStyles. +# SupportedStyles: prefer_alias, prefer_alias_method +Style/Alias: + Exclude: + - 'lib/net/ber/core_ext/array.rb' + - 'lib/net/ldap.rb' + - 'lib/net/ldap/entry.rb' + - 'lib/net/ldap/filter.rb' + - 'lib/net/ldap/pdu.rb' + # Offense count: 4 # Cop supports --auto-correct. Style/AlignArray: Exclude: - 'lib/net/ldap.rb' - 'lib/net/ldap/auth_adapter/sasl.rb' - 'lib/net/ldap/connection.rb' # Offense count: 10 # Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. +# Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth. +# SupportedStyles: with_first_parameter, with_fixed_indentation Style/AlignParameters: Exclude: - 'test/ber/test_ber.rb' - 'test/integration/test_ber.rb' - 'test/integration/test_bind.rb' - 'test/integration/test_password_modify.rb' # Offense count: 37 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, SupportedStyles. +# SupportedStyles: always, conditionals Style/AndOr: Exclude: - 'lib/net/ber/ber_parser.rb' - 'lib/net/ldap.rb' - 'lib/net/ldap/connection.rb' @@ -128,35 +158,38 @@ - 'testserver/ldapserver.rb' # Offense count: 1 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, SupportedStyles. +# SupportedStyles: percent_q, bare_percent Style/BarePercentLiterals: Exclude: - 'test/test_entry.rb' # Offense count: 1 # Cop supports --auto-correct. Style/BlockComments: Exclude: - 'test/test_rename.rb' -# Offense count: 9 +# Offense count: 6 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, SupportedStyles. +# SupportedStyles: braces, no_braces, context_dependent Style/BracesAroundHashParameters: Exclude: - 'lib/net/ldap/auth_adapter/gss_spnego.rb' - 'lib/net/snmp.rb' - - 'test/test_auth_adapter.rb' - - 'test/test_ldap_connection.rb' + - 'test/test_ldap.rb' # Offense count: 4 # Cop supports --auto-correct. -# Configuration parameters: IndentWhenRelativeTo, SupportedStyles, IndentOneStep. +# Configuration parameters: IndentWhenRelativeTo, SupportedStyles, IndentOneStep, IndentationWidth. +# SupportedStyles: case, end Style/CaseIndentation: - Enabled: false + Exclude: + - 'lib/net/ldap/filter.rb' # Offense count: 4 # Cop supports --auto-correct. Style/CharacterLiteral: Exclude: @@ -168,16 +201,18 @@ Exclude: - 'lib/net/ldap/auth_adapter/gss_spnego.rb' # Offense count: 23 # Configuration parameters: EnforcedStyle, SupportedStyles. +# SupportedStyles: nested, compact Style/ClassAndModuleChildren: Enabled: false # Offense count: 2 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, SupportedStyles. +# SupportedStyles: is_a?, kind_of? Style/ClassCheck: Exclude: - 'lib/net/ber/core_ext/array.rb' - 'lib/net/ldap/error.rb' @@ -189,14 +224,23 @@ - 'test/test_ssl_ber.rb' # Offense count: 1 # Cop supports --auto-correct. # Configuration parameters: Keywords. +# Keywords: TODO, FIXME, OPTIMIZE, HACK, REVIEW Style/CommentAnnotation: Exclude: - 'lib/net/ber.rb' +# Offense count: 1 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle, SupportedStyles, SingleLineConditionsOnly. +# SupportedStyles: assign_to_condition, assign_inside_condition +Style/ConditionalAssignment: + Exclude: + - 'lib/net/ldap/dn.rb' + # Offense count: 88 Style/ConstantName: Exclude: - 'lib/net/ldap.rb' - 'lib/net/ldap/connection.rb' @@ -204,36 +248,36 @@ - 'lib/net/ldap/pdu.rb' - 'lib/net/snmp.rb' - 'test/test_ldif.rb' - 'testserver/ldapserver.rb' -# Offense count: 21 -# Configuration parameters: Exclude. +# Offense count: 17 Style/Documentation: Exclude: - 'spec/**/*' - 'test/**/*' - - 'lib/net/ber.rb' - 'lib/net/ber/core_ext.rb' - 'lib/net/ldap.rb' - 'lib/net/ldap/auth_adapter.rb' - 'lib/net/ldap/auth_adapter/sasl.rb' - 'lib/net/ldap/auth_adapter/simple.rb' - 'lib/net/ldap/connection.rb' - 'lib/net/ldap/error.rb' - 'lib/net/ldap/instrumentation.rb' - 'lib/net/ldap/password.rb' - 'lib/net/ldap/pdu.rb' - - 'lib/net/ldap/version.rb' - 'lib/net/snmp.rb' - 'testserver/ldapserver.rb' -# Offense count: 23 +# Offense count: 19 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, SupportedStyles. +# SupportedStyles: leading, trailing Style/DotPosition: - Enabled: false + Exclude: + - 'test/test_ldap_connection.rb' + - 'test/test_ssl_ber.rb' # Offense count: 1 # Cop supports --auto-correct. Style/ElseAlignment: Exclude: @@ -253,20 +297,23 @@ Style/EmptyLines: Exclude: - 'lib/net/snmp.rb' - 'testserver/ldapserver.rb' -# Offense count: 1 +# Offense count: 2 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, SupportedStyles. +# SupportedStyles: empty_lines, no_empty_lines Style/EmptyLinesAroundClassBody: Exclude: + - 'lib/net/ldap.rb' - 'test/test_snmp.rb' # Offense count: 2 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, SupportedStyles. +# SupportedStyles: empty_lines, no_empty_lines Style/EmptyLinesAroundModuleBody: Exclude: - 'testserver/ldapserver.rb' # Offense count: 3 @@ -274,34 +321,46 @@ Style/EvenOdd: Exclude: - 'lib/net/ldap/dn.rb' # Offense count: 1 -# Configuration parameters: Exclude. +# Configuration parameters: ExpectMatchingDefinition, Regex, IgnoreExecutableScripts. Style/FileName: Exclude: - 'lib/net-ldap.rb' # Offense count: 9 # Configuration parameters: AllowedVariables. Style/GlobalVars: Exclude: - 'testserver/ldapserver.rb' -# Offense count: 4 -# Configuration parameters: MinBodyLength. -Style/GuardClause: +# Offense count: 161 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle, SupportedStyles, UseHashRocketsWithSymbolValues, PreferHashRocketsForNonAlnumEndingSymbols. +# SupportedStyles: ruby19, ruby19_no_mixed_keys, hash_rockets +Style/HashSyntax: Exclude: - 'lib/net/ber.rb' - - 'lib/net/ldap/entry.rb' - - 'lib/net/ldap/filter.rb' + - 'lib/net/ber/ber_parser.rb' + - 'lib/net/ldap.rb' + - 'lib/net/ldap/auth_adapter/gss_spnego.rb' + - 'lib/net/ldap/connection.rb' + - 'lib/net/ldap/pdu.rb' + - 'lib/net/snmp.rb' + - 'test/integration/test_bind.rb' + - 'test/test_auth_adapter.rb' + - 'test/test_ldap.rb' + - 'test/test_ldap_connection.rb' + - 'test/test_search.rb' + - 'test/test_ssl_ber.rb' + - 'testserver/ldapserver.rb' -# Offense count: 149 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles, UseHashRocketsWithSymbolValues. -Style/HashSyntax: - Enabled: false +# Offense count: 1 +Style/IfInsideElse: + Exclude: + - 'lib/net/ldap/instrumentation.rb' # Offense count: 7 # Cop supports --auto-correct. # Configuration parameters: MaxLineLength. Style/IfUnlessModifier: @@ -309,14 +368,23 @@ - 'lib/net/ber.rb' - 'lib/net/ber/core_ext/integer.rb' - 'lib/net/ldap.rb' - 'lib/net/ldap/filter.rb' - 'lib/net/snmp.rb' + - 'test/test_ldap_connection.rb' # Offense count: 2 # Cop supports --auto-correct. -# Configuration parameters: SupportedStyles. +# Configuration parameters: SupportedStyles, IndentationWidth. +# SupportedStyles: special_inside_parentheses, consistent, align_brackets +Style/IndentArray: + EnforcedStyle: consistent + +# Offense count: 2 +# Cop supports --auto-correct. +# Configuration parameters: SupportedStyles, IndentationWidth. +# SupportedStyles: special_inside_parentheses, consistent, align_braces Style/IndentHash: EnforcedStyle: consistent # Offense count: 10 # Cop supports --auto-correct. @@ -338,29 +406,69 @@ - 'lib/net/ldap/connection.rb' # Offense count: 21 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, SupportedStyles. +# SupportedStyles: require_parentheses, require_no_parentheses, require_no_parentheses_except_multiline Style/MethodDefParentheses: - Enabled: false + Exclude: + - 'lib/net/ber.rb' + - 'lib/net/ldap/pdu.rb' + - 'lib/net/snmp.rb' + - 'testserver/ldapserver.rb' +# Offense count: 2 +Style/MethodMissing: + Exclude: + - 'lib/net/ldap/dn.rb' + - 'lib/net/ldap/entry.rb' + # Offense count: 1 # Configuration parameters: EnforcedStyle, SupportedStyles. +# SupportedStyles: snake_case, camelCase Style/MethodName: - Enabled: false + Exclude: + - 'lib/net/ldap/filter.rb' -# Offense count: 5 +# Offense count: 4 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, SupportedStyles. -Style/MultilineOperationIndentation: - Enabled: false +# SupportedStyles: symmetrical, new_line, same_line +Style/MultilineMethodCallBraceLayout: + Exclude: + - 'lib/net/ldap/filter.rb' + - 'test/test_entry.rb' + - 'test/test_ldap_connection.rb' # Offense count: 1 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth. +# SupportedStyles: aligned, indented, indented_relative_to_receiver +Style/MultilineMethodCallIndentation: + Exclude: + - 'test/test_ldap_connection.rb' + +# Offense count: 1 Style/MultilineTernaryOperator: Exclude: - 'lib/net/ldap/connection.rb' +# Offense count: 26 +# Cop supports --auto-correct. +Style/MutableConstant: + Exclude: + - 'lib/net/ber.rb' + - 'lib/net/ldap.rb' + - 'lib/net/ldap/connection.rb' + - 'lib/net/ldap/dn.rb' + - 'lib/net/ldap/filter.rb' + - 'lib/net/ldap/version.rb' + - 'lib/net/snmp.rb' + - 'test/support/vm/openldap/Vagrantfile' + - 'test/test_ldif.rb' + - 'testserver/ldapserver.rb' + # Offense count: 1 # Cop supports --auto-correct. Style/NegatedIf: Exclude: - 'test/test_helper.rb' @@ -372,10 +480,11 @@ - 'lib/net/ldap/filter.rb' # Offense count: 3 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, MinBodyLength, SupportedStyles. +# SupportedStyles: skip_modifier_ifs, always Style/Next: Exclude: - 'lib/net/ldap/connection.rb' - 'testserver/ldapserver.rb' @@ -401,10 +510,20 @@ # Offense count: 11 # Cop supports --auto-correct. Style/NumericLiterals: MinDigits: 8 +# Offense count: 4 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle, SupportedStyles. +# SupportedStyles: predicate, comparison +Style/NumericPredicate: + Exclude: + - 'lib/net/ber/core_ext/integer.rb' + - 'lib/net/ldap/dn.rb' + - 'testserver/ldapserver.rb' + # Offense count: 3 Style/OpMethod: Exclude: - 'lib/net/ldap/filter.rb' @@ -433,31 +552,43 @@ - 'lib/net/ldap/dataset.rb' - 'lib/net/ldap/filter.rb' - 'testserver/ldapserver.rb' # Offense count: 10 +# Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, SupportedStyles. +# SupportedStyles: compact, exploded Style/RaiseArgs: - Enabled: false + Exclude: + - 'lib/net/ldap/connection.rb' + - 'lib/net/ldap/pdu.rb' + - 'lib/net/snmp.rb' # Offense count: 1 # Cop supports --auto-correct. Style/RedundantBegin: Exclude: - 'lib/net/snmp.rb' # Offense count: 4 # Cop supports --auto-correct. +Style/RedundantParentheses: + Exclude: + - 'lib/net/ldap/filter.rb' + - 'test/test_filter.rb' + +# Offense count: 4 +# Cop supports --auto-correct. # Configuration parameters: AllowMultipleReturnValues. Style/RedundantReturn: Exclude: - 'lib/net/ber/core_ext/string.rb' - 'lib/net/ldap/auth_adapter.rb' - 'lib/net/ldap/entry.rb' - 'lib/net/ldap/password.rb' -# Offense count: 6 +# Offense count: 8 # Cop supports --auto-correct. Style/RedundantSelf: Exclude: - 'lib/net/ber/core_ext/array.rb' - 'lib/net/ber/core_ext/string.rb' @@ -465,10 +596,11 @@ - 'lib/net/ldap/filter.rb' # Offense count: 2 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, SupportedStyles, AllowInnerSlashes. +# SupportedStyles: slashes, percent_r, mixed Style/RegexpLiteral: Exclude: - 'lib/net/ldap/filter.rb' - 'net-ldap.gemspec' @@ -485,77 +617,63 @@ Exclude: - 'lib/net/ldap/dn.rb' - 'lib/net/ldap/error.rb' - 'testserver/ldapserver.rb' -# Offense count: 66 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/SignalException: - Exclude: - - 'lib/net/ber/ber_parser.rb' - - 'lib/net/ber/core_ext/array.rb' - - 'lib/net/ldap.rb' - - 'lib/net/ldap/auth_adapter.rb' - - 'lib/net/ldap/auth_adapter/gss_spnego.rb' - - 'lib/net/ldap/auth_adapter/sasl.rb' - - 'lib/net/ldap/auth_adapter/simple.rb' - - 'lib/net/ldap/connection.rb' - - 'lib/net/ldap/dn.rb' - - 'lib/net/ldap/entry.rb' - - 'lib/net/ldap/filter.rb' - - 'lib/net/ldap/password.rb' - - 'lib/net/ldap/pdu.rb' - - 'lib/net/snmp.rb' - # Offense count: 2 # Configuration parameters: Methods. +# Methods: {"reduce"=>["a", "e"]}, {"inject"=>["a", "e"]} Style/SingleLineBlockParams: Exclude: - 'lib/net/ldap/filter.rb' -# Offense count: 2 +# Offense count: 5 # Cop supports --auto-correct. -Style/SingleSpaceBeforeFirstArg: +# Configuration parameters: EnforcedStyle, SupportedStyles. +# SupportedStyles: space, no_space +Style/SpaceAroundEqualsInParameterDefault: Exclude: - - 'lib/net/ldap/dataset.rb' - - 'lib/net/ldap/instrumentation.rb' + - 'lib/net/ldap/connection.rb' + - 'lib/net/snmp.rb' -# Offense count: 2 +# Offense count: 4 # Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/SpaceAroundEqualsInParameterDefault: - Enabled: false +Style/SpaceAroundKeyword: + Exclude: + - 'lib/net/ldap/entry.rb' + - 'lib/net/snmp.rb' # Offense count: 9 # Cop supports --auto-correct. -# Configuration parameters: MultiSpaceAllowedForOperators. +# Configuration parameters: AllowForAlignment. Style/SpaceAroundOperators: Exclude: + - 'lib/net/ber/ber_parser.rb' - 'lib/net/ldap/connection.rb' - 'lib/net/ldap/entry.rb' - 'lib/net/ldap/filter.rb' - 'test/test_entry.rb' - 'test/test_ldap_connection.rb' -# Offense count: 2 +# Offense count: 5 # Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -Style/SpaceBeforeBlockBraces: - Enabled: false - -# Offense count: 18 -# Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, SupportedStyles, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters. +# SupportedStyles: space, no_space Style/SpaceInsideBlockBraces: - Enabled: false + Exclude: + - 'lib/net/ldap/dataset.rb' + - 'test/test_snmp.rb' + - 'testserver/ldapserver.rb' -# Offense count: 1 +# Offense count: 13 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces, SupportedStyles. +# SupportedStyles: space, no_space, compact Style/SpaceInsideHashLiteralBraces: - Enabled: false + Exclude: + - 'lib/net/ldap/dataset.rb' + - 'test/test_ldap.rb' # Offense count: 20 # Cop supports --auto-correct. Style/SpaceInsideParens: Exclude: @@ -564,22 +682,48 @@ - 'test/test_password.rb' - 'testserver/ldapserver.rb' # Offense count: 5 # Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle, SupportedStyles. +# SupportedStyles: use_perl_names, use_english_names Style/SpecialGlobalVars: Exclude: - 'lib/net/snmp.rb' - 'net-ldap.gemspec' - 'testserver/ldapserver.rb' -# Offense count: 663 +# Offense count: 679 # Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. +# Configuration parameters: EnforcedStyle, SupportedStyles, ConsistentQuotesInMultiline. +# SupportedStyles: single_quotes, double_quotes Style/StringLiterals: Enabled: false +# Offense count: 1 +Style/StructInheritance: + Exclude: + - 'test/test_ldap.rb' + +# Offense count: 4 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle, SupportedStyles, AllowSafeAssignment. +# SupportedStyles: require_parentheses, require_no_parentheses +Style/TernaryParentheses: + Exclude: + - 'lib/net/ber/core_ext/integer.rb' + - 'lib/net/ldap/connection.rb' + - 'lib/net/ldap/dataset.rb' + +# Offense count: 1 +# Cop supports --auto-correct. +# Configuration parameters: ExactNameMatch, AllowPredicates, AllowDSLWriters, IgnoreClassMethods, Whitelist. +# Whitelist: to_ary, to_a, to_c, to_enum, to_h, to_hash, to_i, to_int, to_io, to_open, to_path, to_proc, to_r, to_regexp, to_str, to_s, to_sym +Style/TrivialAccessors: + Exclude: + - 'lib/net/ldap/connection.rb' + # Offense count: 5 # Cop supports --auto-correct. Style/UnneededPercentQ: Exclude: - 'net-ldap.gemspec' @@ -592,8 +736,18 @@ Exclude: - 'lib/net/ldap/filter.rb' # Offense count: 1 # Cop supports --auto-correct. -# Configuration parameters: WordRegex. +# Configuration parameters: SupportedStyles, WordRegex. +# SupportedStyles: percent, brackets Style/WordArray: - MinSize: 2 + EnforcedStyle: percent + MinSize: 3 + +# Offense count: 6 +# Cop supports --auto-correct. +Style/ZeroLengthPredicate: + Exclude: + - 'lib/net/ldap/connection.rb' + - 'lib/net/ldap/filter.rb' + - 'testserver/ldapserver.rb'