.rubocop_todo.yml in net-ldap-0.13.0 vs .rubocop_todo.yml in net-ldap-0.14.0

@@ -1,242 +1,343 @@
-# This configuration was generated by `rubocop --auto-gen-config`
-# on 2014-12-19 15:32:44 +1100 using RuboCop version 0.28.0.
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2016-01-08 11:47:42 -0800 using RuboCop version 0.35.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 12
-# Configuration parameters: AllowSafeAssignment.
-Lint/AssignmentInCondition:
-  Enabled: false
-
 # Offense count: 1
-# Configuration parameters: AlignWith, SupportedStyles.
+# Cop supports --auto-correct.
+# Configuration parameters: AlignWith, SupportedStyles, AutoCorrect.
 Lint/EndAlignment:
   Enabled: false
 
 # Offense count: 1
+Lint/NonLocalExitFromIterator:
+  Exclude:
+    - 'lib/net/ldap/connection.rb'
+
+# Offense count: 1
 Lint/RescueException:
-  Enabled: false
+  Exclude:
+    - 'lib/net/ldap/pdu.rb'
 
 # Offense count: 1
 Lint/ShadowingOuterLocalVariable:
-  Enabled: false
+  Exclude:
+    - 'lib/net/ldap/instrumentation.rb'
 
-# Offense count: 9
+# Offense count: 10
 # Cop supports --auto-correct.
+# Configuration parameters: IgnoreEmptyBlocks.
 Lint/UnusedBlockArgument:
-  Enabled: false
+  Exclude:
+    - 'lib/net/ldap.rb'
+    - 'lib/net/snmp.rb'
+    - 'test/support/vm/openldap/Vagrantfile'
 
 # Offense count: 3
 # Cop supports --auto-correct.
+# Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods.
 Lint/UnusedMethodArgument:
-  Enabled: false
+  Exclude:
+    - 'lib/net/ldap/entry.rb'
+    - 'lib/net/ldap/pdu.rb'
+    - 'test/test_search.rb'
 
-# Offense count: 7
+# Offense count: 9
 Lint/UselessAssignment:
-  Enabled: false
+  Exclude:
+    - 'lib/net/ldap/connection.rb'
+    - 'lib/net/ldap/password.rb'
+    - 'test/integration/test_add.rb'
+    - 'test/test_ldap_connection.rb'
+    - 'test/test_search.rb'
+    - 'test/test_snmp.rb'
 
-# Offense count: 47
+# Offense count: 48
 Metrics/AbcSize:
   Max: 114
 
 # Offense count: 11
 Metrics/BlockNesting:
   Max: 4
 
-# Offense count: 9
+# Offense count: 10
 # Configuration parameters: CountComments.
 Metrics/ClassLength:
-  Max: 470
+  Max: 423
 
-# Offense count: 20
+# Offense count: 21
 Metrics/CyclomaticComplexity:
   Max: 41
 
-# Offense count: 193
+# Offense count: 229
 # Configuration parameters: AllowURI, URISchemes.
 Metrics/LineLength:
   Max: 360
 
 # Offense count: 71
 # Configuration parameters: CountComments.
 Metrics/MethodLength:
   Max: 130
 
+# Offense count: 1
+# Configuration parameters: CountComments.
+Metrics/ModuleLength:
+  Max: 104
+
 # Offense count: 13
 Metrics/PerceivedComplexity:
-  Max: 36
+  Max: 37
 
 # Offense count: 1
 Style/AccessorMethodName:
-  Enabled: false
+  Exclude:
+    - 'lib/net/ldap.rb'
 
 # Offense count: 4
 # Cop supports --auto-correct.
 Style/AlignArray:
-  Enabled: false
+  Exclude:
+    - 'lib/net/ldap.rb'
+    - 'lib/net/ldap/auth_adapter/sasl.rb'
+    - 'lib/net/ldap/connection.rb'
 
-# Offense count: 3
+# Offense count: 10
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, SupportedStyles.
 Style/AlignParameters:
-  Enabled: false
+  Exclude:
+    - 'test/ber/test_ber.rb'
+    - 'test/integration/test_ber.rb'
+    - 'test/integration/test_bind.rb'
+    - 'test/integration/test_password_modify.rb'
 
-# Offense count: 36
+# Offense count: 37
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, SupportedStyles.
 Style/AndOr:
-  Enabled: false
+  Exclude:
+    - 'lib/net/ber/ber_parser.rb'
+    - 'lib/net/ldap.rb'
+    - 'lib/net/ldap/connection.rb'
+    - 'lib/net/ldap/dataset.rb'
+    - 'lib/net/ldap/filter.rb'
+    - 'lib/net/ldap/pdu.rb'
+    - 'testserver/ldapserver.rb'
 
 # Offense count: 1
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, SupportedStyles.
 Style/BarePercentLiterals:
-  Enabled: false
+  Exclude:
+    - 'test/test_entry.rb'
 
 # Offense count: 1
 # Cop supports --auto-correct.
 Style/BlockComments:
-  Enabled: false
+  Exclude:
+    - 'test/test_rename.rb'
 
-# Offense count: 20
+# Offense count: 9
 # Cop supports --auto-correct.
-Style/Blocks:
-  Enabled: false
-
-# Offense count: 2
-# Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, SupportedStyles.
 Style/BracesAroundHashParameters:
-  Enabled: false
+  Exclude:
+    - 'lib/net/ldap/auth_adapter/gss_spnego.rb'
+    - 'lib/net/snmp.rb'
+    - 'test/test_auth_adapter.rb'
+    - 'test/test_ldap_connection.rb'
 
 # Offense count: 4
+# Cop supports --auto-correct.
 # Configuration parameters: IndentWhenRelativeTo, SupportedStyles, IndentOneStep.
 Style/CaseIndentation:
   Enabled: false
 
 # Offense count: 4
 # Cop supports --auto-correct.
 Style/CharacterLiteral:
-  Enabled: false
+  Exclude:
+    - 'lib/net/ldap/dataset.rb'
+    - 'lib/net/ldap/entry.rb'
 
-# Offense count: 22
+# Offense count: 1
+Style/ClassAndModuleCamelCase:
+  Exclude:
+    - 'lib/net/ldap/auth_adapter/gss_spnego.rb'
+
+# Offense count: 23
 # Configuration parameters: EnforcedStyle, SupportedStyles.
 Style/ClassAndModuleChildren:
   Enabled: false
 
-# Offense count: 1
+# Offense count: 2
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, SupportedStyles.
 Style/ClassCheck:
-  Enabled: false
+  Exclude:
+    - 'lib/net/ber/core_ext/array.rb'
+    - 'lib/net/ldap/error.rb'
 
 # Offense count: 13
 # Cop supports --auto-correct.
 Style/ColonMethodCall:
-  Enabled: false
+  Exclude:
+    - 'test/test_ldif.rb'
+    - 'test/test_ssl_ber.rb'
 
-# Offense count: 2
+# Offense count: 1
+# Cop supports --auto-correct.
 # Configuration parameters: Keywords.
 Style/CommentAnnotation:
-  Enabled: false
+  Exclude:
+    - 'lib/net/ber.rb'
 
-# Offense count: 86
+# Offense count: 88
 Style/ConstantName:
-  Enabled: false
+  Exclude:
+    - 'lib/net/ldap.rb'
+    - 'lib/net/ldap/connection.rb'
+    - 'lib/net/ldap/filter.rb'
+    - 'lib/net/ldap/pdu.rb'
+    - 'lib/net/snmp.rb'
+    - 'test/test_ldif.rb'
+    - 'testserver/ldapserver.rb'
 
-# Offense count: 18
-# Cop supports --auto-correct.
-Style/DeprecatedHashMethods:
-  Enabled: false
-
-# Offense count: 46
+# Offense count: 21
+# Configuration parameters: Exclude.
 Style/Documentation:
-  Enabled: false
+  Exclude:
+    - 'spec/**/*'
+    - 'test/**/*'
+    - 'lib/net/ber.rb'
+    - 'lib/net/ber/core_ext.rb'
+    - 'lib/net/ldap.rb'
+    - 'lib/net/ldap/auth_adapter.rb'
+    - 'lib/net/ldap/auth_adapter/sasl.rb'
+    - 'lib/net/ldap/auth_adapter/simple.rb'
+    - 'lib/net/ldap/connection.rb'
+    - 'lib/net/ldap/error.rb'
+    - 'lib/net/ldap/instrumentation.rb'
+    - 'lib/net/ldap/password.rb'
+    - 'lib/net/ldap/pdu.rb'
+    - 'lib/net/ldap/version.rb'
+    - 'lib/net/snmp.rb'
+    - 'testserver/ldapserver.rb'
 
 # Offense count: 23
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, SupportedStyles.
 Style/DotPosition:
   Enabled: false
 
 # Offense count: 1
 # Cop supports --auto-correct.
 Style/ElseAlignment:
-  Enabled: false
+  Exclude:
+    - 'testserver/ldapserver.rb'
 
-# Offense count: 4
+# Offense count: 5
 # Cop supports --auto-correct.
 # Configuration parameters: AllowAdjacentOneLineDefs.
 Style/EmptyLineBetweenDefs:
-  Enabled: false
+  Exclude:
+    - 'lib/net/ldap.rb'
+    - 'lib/net/ldap/dataset.rb'
+    - 'lib/net/snmp.rb'
 
-# Offense count: 9
+# Offense count: 8
 # Cop supports --auto-correct.
 Style/EmptyLines:
-  Enabled: false
+  Exclude:
+    - 'lib/net/snmp.rb'
+    - 'testserver/ldapserver.rb'
 
 # Offense count: 1
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, SupportedStyles.
 Style/EmptyLinesAroundClassBody:
-  Enabled: false
+  Exclude:
+    - 'test/test_snmp.rb'
 
 # Offense count: 2
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, SupportedStyles.
 Style/EmptyLinesAroundModuleBody:
-  Enabled: false
+  Exclude:
+    - 'testserver/ldapserver.rb'
 
 # Offense count: 3
+# Cop supports --auto-correct.
 Style/EvenOdd:
-  Enabled: false
+  Exclude:
+    - 'lib/net/ldap/dn.rb'
 
 # Offense count: 1
 # Configuration parameters: Exclude.
 Style/FileName:
-  Enabled: false
+  Exclude:
+    - 'lib/net-ldap.rb'
 
 # Offense count: 9
 # Configuration parameters: AllowedVariables.
 Style/GlobalVars:
-  Enabled: false
+  Exclude:
+    - 'testserver/ldapserver.rb'
 
-# Offense count: 3
+# Offense count: 4
 # Configuration parameters: MinBodyLength.
 Style/GuardClause:
-  Enabled: false
+  Exclude:
+    - 'lib/net/ber.rb'
+    - 'lib/net/ldap/entry.rb'
+    - 'lib/net/ldap/filter.rb'
 
-# Offense count: 150
+# Offense count: 149
 # Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
+# Configuration parameters: EnforcedStyle, SupportedStyles, UseHashRocketsWithSymbolValues.
 Style/HashSyntax:
   Enabled: false
 
-# Offense count: 8
+# Offense count: 7
+# Cop supports --auto-correct.
 # Configuration parameters: MaxLineLength.
 Style/IfUnlessModifier:
-  Enabled: false
+  Exclude:
+    - 'lib/net/ber.rb'
+    - 'lib/net/ber/core_ext/integer.rb'
+    - 'lib/net/ldap.rb'
+    - 'lib/net/ldap/filter.rb'
+    - 'lib/net/snmp.rb'
 
 # Offense count: 2
 # Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
+# Configuration parameters: SupportedStyles.
 Style/IndentHash:
-  Enabled: false
+  EnforcedStyle: consistent
 
-# Offense count: 6
+# Offense count: 10
 # Cop supports --auto-correct.
 # Configuration parameters: Width.
 Style/IndentationWidth:
-  Enabled: false
+  Exclude:
+    - 'lib/net/ber.rb'
+    - 'lib/net/ldap/password.rb'
+    - 'lib/net/snmp.rb'
+    - 'test/test_snmp.rb'
+    - 'testserver/ldapserver.rb'
 
-# Offense count: 2
+# Offense count: 3
 # Cop supports --auto-correct.
 Style/LeadingCommentSpace:
-  Enabled: false
+  Exclude:
+    - 'lib/net/ber/core_ext/array.rb'
+    - 'lib/net/ldap.rb'
+    - 'lib/net/ldap/connection.rb'
 
 # Offense count: 21
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, SupportedStyles.
 Style/MethodDefParentheses:
@@ -253,136 +354,190 @@
 Style/MultilineOperationIndentation:
   Enabled: false
 
 # Offense count: 1
 Style/MultilineTernaryOperator:
-  Enabled: false
+  Exclude:
+    - 'lib/net/ldap/connection.rb'
 
 # Offense count: 1
 # Cop supports --auto-correct.
 Style/NegatedIf:
-  Enabled: false
+  Exclude:
+    - 'test/test_helper.rb'
 
 # Offense count: 1
 # Cop supports --auto-correct.
 Style/NegatedWhile:
-  Enabled: false
+  Exclude:
+    - 'lib/net/ldap/filter.rb'
 
 # Offense count: 3
+# Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, MinBodyLength, SupportedStyles.
 Style/Next:
-  Enabled: false
+  Exclude:
+    - 'lib/net/ldap/connection.rb'
+    - 'testserver/ldapserver.rb'
 
 # Offense count: 1
 # Cop supports --auto-correct.
 Style/NilComparison:
-  Enabled: false
+  Exclude:
+    - 'lib/net/ldap/connection.rb'
 
 # Offense count: 1
 # Cop supports --auto-correct.
 # Configuration parameters: IncludeSemanticChanges.
 Style/NonNilCheck:
-  Enabled: false
+  Exclude:
+    - 'lib/net/ber/ber_parser.rb'
 
 # Offense count: 1
 # Cop supports --auto-correct.
 Style/Not:
-  Enabled: false
+  Exclude:
+    - 'lib/net/ldap/filter.rb'
 
-# Offense count: 10
+# Offense count: 11
 # Cop supports --auto-correct.
 Style/NumericLiterals:
   MinDigits: 8
 
 # Offense count: 3
 Style/OpMethod:
-  Enabled: false
+  Exclude:
+    - 'lib/net/ldap/filter.rb'
 
 # Offense count: 6
 # Cop supports --auto-correct.
 # Configuration parameters: AllowSafeAssignment.
 Style/ParenthesesAroundCondition:
-  Enabled: false
+  Exclude:
+    - 'lib/net/ldap.rb'
+    - 'lib/net/ldap/auth_adapter/gss_spnego.rb'
+    - 'lib/net/ldap/auth_adapter/sasl.rb'
+    - 'lib/net/ldap/auth_adapter/simple.rb'
 
 # Offense count: 3
 # Cop supports --auto-correct.
 # Configuration parameters: PreferredDelimiters.
 Style/PercentLiteralDelimiters:
-  Enabled: false
+  Exclude:
+    - 'net-ldap.gemspec'
+    - 'test/test_entry.rb'
 
 # Offense count: 11
 # Cop supports --auto-correct.
 Style/PerlBackrefs:
-  Enabled: false
+  Exclude:
+    - 'lib/net/ldap/dataset.rb'
+    - 'lib/net/ldap/filter.rb'
+    - 'testserver/ldapserver.rb'
 
-# Offense count: 9
+# Offense count: 10
 # Configuration parameters: EnforcedStyle, SupportedStyles.
 Style/RaiseArgs:
   Enabled: false
 
 # Offense count: 1
 # Cop supports --auto-correct.
 Style/RedundantBegin:
-  Enabled: false
+  Exclude:
+    - 'lib/net/snmp.rb'
 
-# Offense count: 3
+# Offense count: 4
 # Cop supports --auto-correct.
 # Configuration parameters: AllowMultipleReturnValues.
 Style/RedundantReturn:
-  Enabled: false
+  Exclude:
+    - 'lib/net/ber/core_ext/string.rb'
+    - 'lib/net/ldap/auth_adapter.rb'
+    - 'lib/net/ldap/entry.rb'
+    - 'lib/net/ldap/password.rb'
 
-# Offense count: 7
+# Offense count: 6
 # Cop supports --auto-correct.
 Style/RedundantSelf:
-  Enabled: false
+  Exclude:
+    - 'lib/net/ber/core_ext/array.rb'
+    - 'lib/net/ber/core_ext/string.rb'
+    - 'lib/net/ldap/dn.rb'
+    - 'lib/net/ldap/filter.rb'
 
-# Offense count: 1
-# Configuration parameters: MaxSlashes.
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles, AllowInnerSlashes.
 Style/RegexpLiteral:
-  Enabled: false
+  Exclude:
+    - 'lib/net/ldap/filter.rb'
+    - 'net-ldap.gemspec'
 
-# Offense count: 2
+# Offense count: 1
+# Cop supports --auto-correct.
 Style/RescueModifier:
-  Enabled: false
+  Exclude:
+    - 'test/ber/core_ext/test_string.rb'
 
-# Offense count: 7
+# Offense count: 8
 # Cop supports --auto-correct.
 # Configuration parameters: AllowAsExpressionSeparator.
 Style/Semicolon:
-  Enabled: false
+  Exclude:
+    - 'lib/net/ldap/dn.rb'
+    - 'lib/net/ldap/error.rb'
+    - 'testserver/ldapserver.rb'
 
-# Offense count: 61
+# Offense count: 66
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, SupportedStyles.
 Style/SignalException:
-  Enabled: false
+  Exclude:
+    - 'lib/net/ber/ber_parser.rb'
+    - 'lib/net/ber/core_ext/array.rb'
+    - 'lib/net/ldap.rb'
+    - 'lib/net/ldap/auth_adapter.rb'
+    - 'lib/net/ldap/auth_adapter/gss_spnego.rb'
+    - 'lib/net/ldap/auth_adapter/sasl.rb'
+    - 'lib/net/ldap/auth_adapter/simple.rb'
+    - 'lib/net/ldap/connection.rb'
+    - 'lib/net/ldap/dn.rb'
+    - 'lib/net/ldap/entry.rb'
+    - 'lib/net/ldap/filter.rb'
+    - 'lib/net/ldap/password.rb'
+    - 'lib/net/ldap/pdu.rb'
+    - 'lib/net/snmp.rb'
 
 # Offense count: 2
 # Configuration parameters: Methods.
 Style/SingleLineBlockParams:
-  Enabled: false
+  Exclude:
+    - 'lib/net/ldap/filter.rb'
 
 # Offense count: 2
 # Cop supports --auto-correct.
 Style/SingleSpaceBeforeFirstArg:
-  Enabled: false
+  Exclude:
+    - 'lib/net/ldap/dataset.rb'
+    - 'lib/net/ldap/instrumentation.rb'
 
-# Offense count: 24
-# Cop supports --auto-correct.
-Style/SpaceAfterComma:
-  Enabled: false
-
 # Offense count: 2
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, SupportedStyles.
 Style/SpaceAroundEqualsInParameterDefault:
   Enabled: false
 
-# Offense count: 8
+# Offense count: 9
 # Cop supports --auto-correct.
+# Configuration parameters: MultiSpaceAllowedForOperators.
 Style/SpaceAroundOperators:
-  Enabled: false
+  Exclude:
+    - 'lib/net/ldap/connection.rb'
+    - 'lib/net/ldap/entry.rb'
+    - 'lib/net/ldap/filter.rb'
+    - 'test/test_entry.rb'
+    - 'test/test_ldap_connection.rb'
 
 # Offense count: 2
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, SupportedStyles.
 Style/SpaceBeforeBlockBraces:
@@ -392,69 +547,51 @@
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, SupportedStyles, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters.
 Style/SpaceInsideBlockBraces:
   Enabled: false
 
-# Offense count: 37
-# Cop supports --auto-correct.
-Style/SpaceInsideBrackets:
-  Enabled: false
-
 # Offense count: 1
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces, SupportedStyles.
 Style/SpaceInsideHashLiteralBraces:
   Enabled: false
 
 # Offense count: 20
 # Cop supports --auto-correct.
 Style/SpaceInsideParens:
-  Enabled: false
+  Exclude:
+    - 'lib/net/ldap/entry.rb'
+    - 'lib/net/snmp.rb'
+    - 'test/test_password.rb'
+    - 'testserver/ldapserver.rb'
 
 # Offense count: 5
 # Cop supports --auto-correct.
 Style/SpecialGlobalVars:
-  Enabled: false
+  Exclude:
+    - 'lib/net/snmp.rb'
+    - 'net-ldap.gemspec'
+    - 'testserver/ldapserver.rb'
 
-# Offense count: 645
+# Offense count: 663
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, SupportedStyles.
 Style/StringLiterals:
   Enabled: false
 
-# Offense count: 10
-# Cop supports --auto-correct.
-# Configuration parameters: IgnoredMethods.
-Style/SymbolProc:
-  Enabled: false
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/TrailingBlankLines:
-  Enabled: false
-
-# Offense count: 9
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyleForMultiline, SupportedStyles.
-Style/TrailingComma:
-  Enabled: false
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: ExactNameMatch, AllowPredicates, AllowDSLWriters, Whitelist.
-Style/TrivialAccessors:
-  Enabled: false
-
 # Offense count: 5
 # Cop supports --auto-correct.
 Style/UnneededPercentQ:
-  Enabled: false
+  Exclude:
+    - 'net-ldap.gemspec'
+    - 'test/test_entry.rb'
 
 # Offense count: 1
+# Cop supports --auto-correct.
 # Configuration parameters: MaxLineLength.
 Style/WhileUntilModifier:
-  Enabled: false
+  Exclude:
+    - 'lib/net/ldap/filter.rb'
 
 # Offense count: 1
 # Cop supports --auto-correct.
 # Configuration parameters: WordRegex.
 Style/WordArray: