vendor/v8/src/handles.cc in mustang-0.0.1 vs vendor/v8/src/handles.cc in mustang-0.1.0

- old
+ new

@@ -43,61 +43,66 @@ namespace v8 { namespace internal { -v8::ImplementationUtilities::HandleScopeData HandleScope::current_ = - { NULL, NULL, 0 }; - - int HandleScope::NumberOfHandles() { - int n = HandleScopeImplementer::instance()->blocks()->length(); + Isolate* isolate = Isolate::Current(); + HandleScopeImplementer* impl = isolate->handle_scope_implementer(); + int n = impl->blocks()->length(); if (n == 0) return 0; return ((n - 1) * kHandleBlockSize) + static_cast<int>( - (current_.next - HandleScopeImplementer::instance()->blocks()->last())); + (isolate->handle_scope_data()->next - impl->blocks()->last())); } Object** HandleScope::Extend() { - Object** result = current_.next; + Isolate* isolate = Isolate::Current(); + v8::ImplementationUtilities::HandleScopeData* current = + isolate->handle_scope_data(); - ASSERT(result == current_.limit); + Object** result = current->next; + + ASSERT(result == current->limit); // Make sure there's at least one scope on the stack and that the // top of the scope stack isn't a barrier. - if (current_.level == 0) { + if (current->level == 0) { Utils::ReportApiFailure("v8::HandleScope::CreateHandle()", "Cannot create a handle without a HandleScope"); return NULL; } - HandleScopeImplementer* impl = HandleScopeImplementer::instance(); + HandleScopeImplementer* impl = isolate->handle_scope_implementer(); // If there's more room in the last block, we use that. This is used // for fast creation of scopes after scope barriers. if (!impl->blocks()->is_empty()) { Object** limit = &impl->blocks()->last()[kHandleBlockSize]; - if (current_.limit != limit) { - current_.limit = limit; - ASSERT(limit - current_.next < kHandleBlockSize); + if (current->limit != limit) { + current->limit = limit; + ASSERT(limit - current->next < kHandleBlockSize); } } // If we still haven't found a slot for the handle, we extend the // current handle scope by allocating a new handle block. - if (result == current_.limit) { + if (result == current->limit) { // If there's a spare block, use it for growing the current scope. result = impl->GetSpareOrNewBlock(); // Add the extension to the global list of blocks, but count the // extension as part of the current scope. impl->blocks()->Add(result); - current_.limit = &result[kHandleBlockSize]; + current->limit = &result[kHandleBlockSize]; } return result; } -void HandleScope::DeleteExtensions() { - HandleScopeImplementer::instance()->DeleteExtensions(current_.limit); +void HandleScope::DeleteExtensions(Isolate* isolate) { + ASSERT(isolate == Isolate::Current()); + v8::ImplementationUtilities::HandleScopeData* current = + isolate->handle_scope_data(); + isolate->handle_scope_implementer()->DeleteExtensions(current->limit); } void HandleScope::ZapRange(Object** start, Object** end) { ASSERT(end - start <= kHandleBlockSize); @@ -106,41 +111,48 @@ } } Address HandleScope::current_level_address() { - return reinterpret_cast<Address>(&current_.level); + return reinterpret_cast<Address>( + &Isolate::Current()->handle_scope_data()->level); } Address HandleScope::current_next_address() { - return reinterpret_cast<Address>(&current_.next); + return reinterpret_cast<Address>( + &Isolate::Current()->handle_scope_data()->next); } Address HandleScope::current_limit_address() { - return reinterpret_cast<Address>(&current_.limit); + return reinterpret_cast<Address>( + &Isolate::Current()->handle_scope_data()->limit); } Handle<FixedArray> AddKeysFromJSArray(Handle<FixedArray> content, Handle<JSArray> array) { - CALL_HEAP_FUNCTION(content->AddKeysFromJSArray(*array), FixedArray); + CALL_HEAP_FUNCTION(content->GetIsolate(), + content->AddKeysFromJSArray(*array), FixedArray); } Handle<FixedArray> UnionOfKeys(Handle<FixedArray> first, Handle<FixedArray> second) { - CALL_HEAP_FUNCTION(first->UnionOfKeys(*second), FixedArray); + CALL_HEAP_FUNCTION(first->GetIsolate(), + first->UnionOfKeys(*second), FixedArray); } Handle<JSGlobalProxy> ReinitializeJSGlobalProxy( Handle<JSFunction> constructor, Handle<JSGlobalProxy> global) { - CALL_HEAP_FUNCTION(Heap::ReinitializeJSGlobalProxy(*constructor, *global), - JSGlobalProxy); + CALL_HEAP_FUNCTION( + constructor->GetIsolate(), + constructor->GetHeap()->ReinitializeJSGlobalProxy(*constructor, *global), + JSGlobalProxy); } void SetExpectedNofProperties(Handle<JSFunction> func, int nof) { // If objects constructed from this function exist then changing @@ -151,19 +163,21 @@ if (func->shared()->live_objects_may_exist()) return; func->shared()->set_expected_nof_properties(nof); if (func->has_initial_map()) { Handle<Map> new_initial_map = - Factory::CopyMapDropTransitions(Handle<Map>(func->initial_map())); + func->GetIsolate()->factory()->CopyMapDropTransitions( + Handle<Map>(func->initial_map())); new_initial_map->set_unused_property_fields(nof); func->set_initial_map(*new_initial_map); } } void SetPrototypeProperty(Handle<JSFunction> func, Handle<JSObject> value) { - CALL_HEAP_FUNCTION_VOID(func->SetPrototype(*value)); + CALL_HEAP_FUNCTION_VOID(func->GetIsolate(), + func->SetPrototype(*value)); } static int ExpectedNofPropertiesFromEstimate(int estimate) { // If no properties are added in the constructor, they are more likely @@ -191,153 +205,186 @@ void NormalizeProperties(Handle<JSObject> object, PropertyNormalizationMode mode, int expected_additional_properties) { - CALL_HEAP_FUNCTION_VOID(object->NormalizeProperties( - mode, - expected_additional_properties)); + CALL_HEAP_FUNCTION_VOID(object->GetIsolate(), + object->NormalizeProperties( + mode, + expected_additional_properties)); } void NormalizeElements(Handle<JSObject> object) { - CALL_HEAP_FUNCTION_VOID(object->NormalizeElements()); + CALL_HEAP_FUNCTION_VOID(object->GetIsolate(), + object->NormalizeElements()); } void TransformToFastProperties(Handle<JSObject> object, int unused_property_fields) { CALL_HEAP_FUNCTION_VOID( + object->GetIsolate(), object->TransformToFastProperties(unused_property_fields)); } void NumberDictionarySet(Handle<NumberDictionary> dictionary, uint32_t index, Handle<Object> value, PropertyDetails details) { - CALL_HEAP_FUNCTION_VOID(dictionary->Set(index, *value, details)); + CALL_HEAP_FUNCTION_VOID(dictionary->GetIsolate(), + dictionary->Set(index, *value, details)); } void FlattenString(Handle<String> string) { - CALL_HEAP_FUNCTION_VOID(string->TryFlatten()); + CALL_HEAP_FUNCTION_VOID(string->GetIsolate(), string->TryFlatten()); } Handle<String> FlattenGetString(Handle<String> string) { - CALL_HEAP_FUNCTION(string->TryFlatten(), String); + CALL_HEAP_FUNCTION(string->GetIsolate(), string->TryFlatten(), String); } Handle<Object> SetPrototype(Handle<JSFunction> function, Handle<Object> prototype) { ASSERT(function->should_have_prototype()); - CALL_HEAP_FUNCTION(Accessors::FunctionSetPrototype(*function, + CALL_HEAP_FUNCTION(function->GetIsolate(), + Accessors::FunctionSetPrototype(*function, *prototype, NULL), Object); } Handle<Object> SetProperty(Handle<JSObject> object, Handle<String> key, Handle<Object> value, - PropertyAttributes attributes) { - CALL_HEAP_FUNCTION(object->SetProperty(*key, *value, attributes), Object); + PropertyAttributes attributes, + StrictModeFlag strict_mode) { + CALL_HEAP_FUNCTION(object->GetIsolate(), + object->SetProperty(*key, *value, attributes, strict_mode), + Object); } Handle<Object> SetProperty(Handle<Object> object, Handle<Object> key, Handle<Object> value, - PropertyAttributes attributes) { + PropertyAttributes attributes, + StrictModeFlag strict_mode) { + Isolate* isolate = Isolate::Current(); CALL_HEAP_FUNCTION( - Runtime::SetObjectProperty(object, key, value, attributes), Object); + isolate, + Runtime::SetObjectProperty( + isolate, object, key, value, attributes, strict_mode), + Object); } Handle<Object> ForceSetProperty(Handle<JSObject> object, Handle<Object> key, Handle<Object> value, PropertyAttributes attributes) { + Isolate* isolate = object->GetIsolate(); CALL_HEAP_FUNCTION( - Runtime::ForceSetObjectProperty(object, key, value, attributes), Object); + isolate, + Runtime::ForceSetObjectProperty( + isolate, object, key, value, attributes), + Object); } Handle<Object> SetNormalizedProperty(Handle<JSObject> object, Handle<String> key, Handle<Object> value, PropertyDetails details) { - CALL_HEAP_FUNCTION(object->SetNormalizedProperty(*key, *value, details), + CALL_HEAP_FUNCTION(object->GetIsolate(), + object->SetNormalizedProperty(*key, *value, details), Object); } Handle<Object> ForceDeleteProperty(Handle<JSObject> object, Handle<Object> key) { - CALL_HEAP_FUNCTION(Runtime::ForceDeleteObjectProperty(object, key), Object); + Isolate* isolate = object->GetIsolate(); + CALL_HEAP_FUNCTION(isolate, + Runtime::ForceDeleteObjectProperty(isolate, object, key), + Object); } Handle<Object> SetLocalPropertyIgnoreAttributes( Handle<JSObject> object, Handle<String> key, Handle<Object> value, PropertyAttributes attributes) { - CALL_HEAP_FUNCTION(object-> - SetLocalPropertyIgnoreAttributes(*key, *value, attributes), Object); + CALL_HEAP_FUNCTION( + object->GetIsolate(), + object->SetLocalPropertyIgnoreAttributes(*key, *value, attributes), + Object); } void SetLocalPropertyNoThrow(Handle<JSObject> object, Handle<String> key, Handle<Object> value, PropertyAttributes attributes) { - ASSERT(!Top::has_pending_exception()); + Isolate* isolate = object->GetIsolate(); + ASSERT(!isolate->has_pending_exception()); CHECK(!SetLocalPropertyIgnoreAttributes( object, key, value, attributes).is_null()); - CHECK(!Top::has_pending_exception()); + CHECK(!isolate->has_pending_exception()); } Handle<Object> SetPropertyWithInterceptor(Handle<JSObject> object, Handle<String> key, Handle<Object> value, - PropertyAttributes attributes) { - CALL_HEAP_FUNCTION(object->SetPropertyWithInterceptor(*key, + PropertyAttributes attributes, + StrictModeFlag strict_mode) { + CALL_HEAP_FUNCTION(object->GetIsolate(), + object->SetPropertyWithInterceptor(*key, *value, - attributes), + attributes, + strict_mode), Object); } Handle<Object> GetProperty(Handle<JSObject> obj, const char* name) { - Handle<String> str = Factory::LookupAsciiSymbol(name); - CALL_HEAP_FUNCTION(obj->GetProperty(*str), Object); + Isolate* isolate = obj->GetIsolate(); + Handle<String> str = isolate->factory()->LookupAsciiSymbol(name); + CALL_HEAP_FUNCTION(isolate, obj->GetProperty(*str), Object); } Handle<Object> GetProperty(Handle<Object> obj, Handle<Object> key) { - CALL_HEAP_FUNCTION(Runtime::GetObjectProperty(obj, key), Object); + Isolate* isolate = Isolate::Current(); + CALL_HEAP_FUNCTION(isolate, + Runtime::GetObjectProperty(isolate, obj, key), Object); } Handle<Object> GetElement(Handle<Object> obj, uint32_t index) { - CALL_HEAP_FUNCTION(Runtime::GetElement(obj, index), Object); + Isolate* isolate = Isolate::Current(); + CALL_HEAP_FUNCTION(isolate, Runtime::GetElement(obj, index), Object); } Handle<Object> GetPropertyWithInterceptor(Handle<JSObject> receiver, Handle<JSObject> holder, Handle<String> name, PropertyAttributes* attributes) { - CALL_HEAP_FUNCTION(holder->GetPropertyWithInterceptor(*receiver, + Isolate* isolate = receiver->GetIsolate(); + CALL_HEAP_FUNCTION(isolate, + holder->GetPropertyWithInterceptor(*receiver, *name, attributes), Object); } @@ -348,109 +395,131 @@ } Handle<Object> SetPrototype(Handle<JSObject> obj, Handle<Object> value) { const bool skip_hidden_prototypes = false; - CALL_HEAP_FUNCTION(obj->SetPrototype(*value, skip_hidden_prototypes), Object); + CALL_HEAP_FUNCTION(obj->GetIsolate(), + obj->SetPrototype(*value, skip_hidden_prototypes), Object); } +Handle<Object> PreventExtensions(Handle<JSObject> object) { + CALL_HEAP_FUNCTION(object->GetIsolate(), object->PreventExtensions(), Object); +} + + Handle<Object> GetHiddenProperties(Handle<JSObject> obj, bool create_if_needed) { + Isolate* isolate = obj->GetIsolate(); Object* holder = obj->BypassGlobalProxy(); - if (holder->IsUndefined()) return Factory::undefined_value(); - obj = Handle<JSObject>(JSObject::cast(holder)); + if (holder->IsUndefined()) return isolate->factory()->undefined_value(); + obj = Handle<JSObject>(JSObject::cast(holder), isolate); if (obj->HasFastProperties()) { // If the object has fast properties, check whether the first slot // in the descriptor array matches the hidden symbol. Since the // hidden symbols hash code is zero (and no other string has hash // code zero) it will always occupy the first entry if present. DescriptorArray* descriptors = obj->map()->instance_descriptors(); if ((descriptors->number_of_descriptors() > 0) && - (descriptors->GetKey(0) == Heap::hidden_symbol()) && + (descriptors->GetKey(0) == isolate->heap()->hidden_symbol()) && descriptors->IsProperty(0)) { ASSERT(descriptors->GetType(0) == FIELD); - return Handle<Object>(obj->FastPropertyAt(descriptors->GetFieldIndex(0))); + return Handle<Object>(obj->FastPropertyAt(descriptors->GetFieldIndex(0)), + isolate); } } // Only attempt to find the hidden properties in the local object and not // in the prototype chain. Note that HasLocalProperty() can cause a GC in // the general case in the presence of interceptors. if (!obj->HasHiddenPropertiesObject()) { // Hidden properties object not found. Allocate a new hidden properties // object if requested. Otherwise return the undefined value. if (create_if_needed) { - Handle<Object> hidden_obj = Factory::NewJSObject(Top::object_function()); - CALL_HEAP_FUNCTION(obj->SetHiddenPropertiesObject(*hidden_obj), Object); + Handle<Object> hidden_obj = + isolate->factory()->NewJSObject(isolate->object_function()); + CALL_HEAP_FUNCTION(isolate, + obj->SetHiddenPropertiesObject(*hidden_obj), Object); } else { - return Factory::undefined_value(); + return isolate->factory()->undefined_value(); } } - return Handle<Object>(obj->GetHiddenPropertiesObject()); + return Handle<Object>(obj->GetHiddenPropertiesObject(), isolate); } Handle<Object> DeleteElement(Handle<JSObject> obj, uint32_t index) { - CALL_HEAP_FUNCTION(obj->DeleteElement(index, JSObject::NORMAL_DELETION), + CALL_HEAP_FUNCTION(obj->GetIsolate(), + obj->DeleteElement(index, JSObject::NORMAL_DELETION), Object); } Handle<Object> DeleteProperty(Handle<JSObject> obj, Handle<String> prop) { - CALL_HEAP_FUNCTION(obj->DeleteProperty(*prop, JSObject::NORMAL_DELETION), + CALL_HEAP_FUNCTION(obj->GetIsolate(), + obj->DeleteProperty(*prop, JSObject::NORMAL_DELETION), Object); } Handle<Object> LookupSingleCharacterStringFromCode(uint32_t index) { - CALL_HEAP_FUNCTION(Heap::LookupSingleCharacterStringFromCode(index), Object); + Isolate* isolate = Isolate::Current(); + CALL_HEAP_FUNCTION( + isolate, + isolate->heap()->LookupSingleCharacterStringFromCode(index), Object); } Handle<String> SubString(Handle<String> str, int start, int end, PretenureFlag pretenure) { - CALL_HEAP_FUNCTION(str->SubString(start, end, pretenure), String); + CALL_HEAP_FUNCTION(str->GetIsolate(), + str->SubString(start, end, pretenure), String); } Handle<Object> SetElement(Handle<JSObject> object, uint32_t index, - Handle<Object> value) { - if (object->HasPixelElements() || object->HasExternalArrayElements()) { + Handle<Object> value, + StrictModeFlag strict_mode) { + if (object->HasExternalArrayElements()) { if (!value->IsSmi() && !value->IsHeapNumber() && !value->IsUndefined()) { bool has_exception; Handle<Object> number = Execution::ToNumber(value, &has_exception); if (has_exception) return Handle<Object>(); value = number; } } - CALL_HEAP_FUNCTION(object->SetElement(index, *value), Object); + CALL_HEAP_FUNCTION(object->GetIsolate(), + object->SetElement(index, *value, strict_mode), Object); } Handle<Object> SetOwnElement(Handle<JSObject> object, uint32_t index, - Handle<Object> value) { - ASSERT(!object->HasPixelElements()); + Handle<Object> value, + StrictModeFlag strict_mode) { ASSERT(!object->HasExternalArrayElements()); - CALL_HEAP_FUNCTION(object->SetElement(index, *value, false), Object); + CALL_HEAP_FUNCTION(object->GetIsolate(), + object->SetElement(index, *value, strict_mode, false), + Object); } Handle<JSObject> Copy(Handle<JSObject> obj) { - CALL_HEAP_FUNCTION(Heap::CopyJSObject(*obj), JSObject); + Isolate* isolate = obj->GetIsolate(); + CALL_HEAP_FUNCTION(isolate, + isolate->heap()->CopyJSObject(*obj), JSObject); } Handle<Object> SetAccessor(Handle<JSObject> obj, Handle<AccessorInfo> info) { - CALL_HEAP_FUNCTION(obj->DefineAccessor(*info), Object); + CALL_HEAP_FUNCTION(obj->GetIsolate(), obj->DefineAccessor(*info), Object); } // Wrappers for scripts are kept alive and cached in weak global // handles referred from proxy objects held by the scripts as long as @@ -467,71 +536,76 @@ Handle<Object> cache = Utils::OpenHandle(*handle); JSValue* wrapper = JSValue::cast(*cache); Proxy* proxy = Script::cast(wrapper->value())->wrapper(); ASSERT(proxy->proxy() == reinterpret_cast<Address>(cache.location())); proxy->set_proxy(0); - GlobalHandles::Destroy(cache.location()); - Counters::script_wrappers.Decrement(); + Isolate* isolate = Isolate::Current(); + isolate->global_handles()->Destroy(cache.location()); + isolate->counters()->script_wrappers()->Decrement(); } Handle<JSValue> GetScriptWrapper(Handle<Script> script) { if (script->wrapper()->proxy() != NULL) { // Return the script wrapper directly from the cache. return Handle<JSValue>( reinterpret_cast<JSValue**>(script->wrapper()->proxy())); } - + Isolate* isolate = Isolate::Current(); // Construct a new script wrapper. - Counters::script_wrappers.Increment(); - Handle<JSFunction> constructor = Top::script_function(); + isolate->counters()->script_wrappers()->Increment(); + Handle<JSFunction> constructor = isolate->script_function(); Handle<JSValue> result = - Handle<JSValue>::cast(Factory::NewJSObject(constructor)); + Handle<JSValue>::cast(isolate->factory()->NewJSObject(constructor)); result->set_value(*script); // Create a new weak global handle and use it to cache the wrapper // for future use. The cache will automatically be cleared by the // garbage collector when it is not used anymore. - Handle<Object> handle = GlobalHandles::Create(*result); - GlobalHandles::MakeWeak(handle.location(), NULL, &ClearWrapperCache); + Handle<Object> handle = isolate->global_handles()->Create(*result); + isolate->global_handles()->MakeWeak(handle.location(), NULL, + &ClearWrapperCache); script->wrapper()->set_proxy(reinterpret_cast<Address>(handle.location())); return result; } // Init line_ends array with code positions of line ends inside script // source. void InitScriptLineEnds(Handle<Script> script) { if (!script->line_ends()->IsUndefined()) return; + Isolate* isolate = script->GetIsolate(); + if (!script->source()->IsString()) { ASSERT(script->source()->IsUndefined()); - Handle<FixedArray> empty = Factory::NewFixedArray(0); + Handle<FixedArray> empty = isolate->factory()->NewFixedArray(0); script->set_line_ends(*empty); ASSERT(script->line_ends()->IsFixedArray()); return; } - Handle<String> src(String::cast(script->source())); + Handle<String> src(String::cast(script->source()), isolate); Handle<FixedArray> array = CalculateLineEnds(src, true); - if (*array != Heap::empty_fixed_array()) { - array->set_map(Heap::fixed_cow_array_map()); + if (*array != isolate->heap()->empty_fixed_array()) { + array->set_map(isolate->heap()->fixed_cow_array_map()); } script->set_line_ends(*array); ASSERT(script->line_ends()->IsFixedArray()); } template <typename SourceChar> -static void CalculateLineEnds(List<int>* line_ends, +static void CalculateLineEnds(Isolate* isolate, + List<int>* line_ends, Vector<const SourceChar> src, bool with_last_line) { const int src_len = src.length(); - StringSearch<char, SourceChar> search(CStrVector("\n")); + StringSearch<char, SourceChar> search(isolate, CStrVector("\n")); // Find and record line ends. int position = 0; while (position != -1 && position < src_len) { position = search.Search(src, position); @@ -552,21 +626,28 @@ src = FlattenGetString(src); // Rough estimate of line count based on a roughly estimated average // length of (unpacked) code. int line_count_estimate = src->length() >> 4; List<int> line_ends(line_count_estimate); + Isolate* isolate = src->GetIsolate(); { AssertNoAllocation no_heap_allocation; // ensure vectors stay valid. // Dispatch on type of strings. if (src->IsAsciiRepresentation()) { - CalculateLineEnds(&line_ends, src->ToAsciiVector(), with_last_line); + CalculateLineEnds(isolate, + &line_ends, + src->ToAsciiVector(), + with_last_line); } else { - CalculateLineEnds(&line_ends, src->ToUC16Vector(), with_last_line); + CalculateLineEnds(isolate, + &line_ends, + src->ToUC16Vector(), + with_last_line); } } int line_count = line_ends.length(); - Handle<FixedArray> array = Factory::NewFixedArray(line_count); + Handle<FixedArray> array = isolate->factory()->NewFixedArray(line_count); for (int i = 0; i < line_count; i++) { array->set(i, Smi::FromInt(line_ends[i])); } return array; } @@ -628,42 +709,44 @@ // Compute the property keys from the interceptor. v8::Handle<v8::Array> GetKeysForNamedInterceptor(Handle<JSObject> receiver, Handle<JSObject> object) { + Isolate* isolate = receiver->GetIsolate(); Handle<InterceptorInfo> interceptor(object->GetNamedInterceptor()); - CustomArguments args(interceptor->data(), *receiver, *object); + CustomArguments args(isolate, interceptor->data(), *receiver, *object); v8::AccessorInfo info(args.end()); v8::Handle<v8::Array> result; if (!interceptor->enumerator()->IsUndefined()) { v8::NamedPropertyEnumerator enum_fun = v8::ToCData<v8::NamedPropertyEnumerator>(interceptor->enumerator()); - LOG(ApiObjectAccess("interceptor-named-enum", *object)); + LOG(isolate, ApiObjectAccess("interceptor-named-enum", *object)); { // Leaving JavaScript. - VMState state(EXTERNAL); + VMState state(isolate, EXTERNAL); result = enum_fun(info); } } return result; } // Compute the element keys from the interceptor. v8::Handle<v8::Array> GetKeysForIndexedInterceptor(Handle<JSObject> receiver, Handle<JSObject> object) { + Isolate* isolate = receiver->GetIsolate(); Handle<InterceptorInfo> interceptor(object->GetIndexedInterceptor()); - CustomArguments args(interceptor->data(), *receiver, *object); + CustomArguments args(isolate, interceptor->data(), *receiver, *object); v8::AccessorInfo info(args.end()); v8::Handle<v8::Array> result; if (!interceptor->enumerator()->IsUndefined()) { v8::IndexedPropertyEnumerator enum_fun = v8::ToCData<v8::IndexedPropertyEnumerator>(interceptor->enumerator()); - LOG(ApiObjectAccess("interceptor-indexed-enum", *object)); + LOG(isolate, ApiObjectAccess("interceptor-indexed-enum", *object)); { // Leaving JavaScript. - VMState state(EXTERNAL); + VMState state(isolate, EXTERNAL); result = enum_fun(info); } } return result; } @@ -680,35 +763,37 @@ Handle<FixedArray> GetKeysInFixedArrayFor(Handle<JSObject> object, KeyCollectionType type) { USE(ContainsOnlyValidKeys); - Handle<FixedArray> content = Factory::empty_fixed_array(); - Handle<JSObject> arguments_boilerplate = - Handle<JSObject>( - Top::context()->global_context()->arguments_boilerplate()); - Handle<JSFunction> arguments_function = - Handle<JSFunction>( - JSFunction::cast(arguments_boilerplate->map()->constructor())); + Isolate* isolate = object->GetIsolate(); + Handle<FixedArray> content = isolate->factory()->empty_fixed_array(); + Handle<JSObject> arguments_boilerplate = Handle<JSObject>( + isolate->context()->global_context()->arguments_boilerplate(), + isolate); + Handle<JSFunction> arguments_function = Handle<JSFunction>( + JSFunction::cast(arguments_boilerplate->map()->constructor()), + isolate); // Only collect keys if access is permitted. for (Handle<Object> p = object; - *p != Heap::null_value(); - p = Handle<Object>(p->GetPrototype())) { - Handle<JSObject> current(JSObject::cast(*p)); + *p != isolate->heap()->null_value(); + p = Handle<Object>(p->GetPrototype(), isolate)) { + Handle<JSObject> current(JSObject::cast(*p), isolate); // Check access rights if required. if (current->IsAccessCheckNeeded() && - !Top::MayNamedAccess(*current, Heap::undefined_value(), - v8::ACCESS_KEYS)) { - Top::ReportFailedAccessCheck(*current, v8::ACCESS_KEYS); + !isolate->MayNamedAccess(*current, + isolate->heap()->undefined_value(), + v8::ACCESS_KEYS)) { + isolate->ReportFailedAccessCheck(*current, v8::ACCESS_KEYS); break; } // Compute the element keys. Handle<FixedArray> element_keys = - Factory::NewFixedArray(current->NumberOfEnumElements()); + isolate->factory()->NewFixedArray(current->NumberOfEnumElements()); current->GetEnumElementKeys(*element_keys); content = UnionOfKeys(content, element_keys); ASSERT(ContainsOnlyValidKeys(content)); // Add the element keys from the interceptor. @@ -758,32 +843,35 @@ return content; } Handle<JSArray> GetKeysFor(Handle<JSObject> object) { - Counters::for_in.Increment(); + Isolate* isolate = object->GetIsolate(); + isolate->counters()->for_in()->Increment(); Handle<FixedArray> elements = GetKeysInFixedArrayFor(object, INCLUDE_PROTOS); - return Factory::NewJSArrayWithElements(elements); + return isolate->factory()->NewJSArrayWithElements(elements); } Handle<FixedArray> GetEnumPropertyKeys(Handle<JSObject> object, bool cache_result) { int index = 0; + Isolate* isolate = object->GetIsolate(); if (object->HasFastProperties()) { if (object->map()->instance_descriptors()->HasEnumCache()) { - Counters::enum_cache_hits.Increment(); + isolate->counters()->enum_cache_hits()->Increment(); DescriptorArray* desc = object->map()->instance_descriptors(); - return Handle<FixedArray>(FixedArray::cast(desc->GetEnumCache())); + return Handle<FixedArray>(FixedArray::cast(desc->GetEnumCache()), + isolate); } - Counters::enum_cache_misses.Increment(); + isolate->counters()->enum_cache_misses()->Increment(); int num_enum = object->NumberOfEnumProperties(); - Handle<FixedArray> storage = Factory::NewFixedArray(num_enum); - Handle<FixedArray> sort_array = Factory::NewFixedArray(num_enum); + Handle<FixedArray> storage = isolate->factory()->NewFixedArray(num_enum); + Handle<FixedArray> sort_array = isolate->factory()->NewFixedArray(num_enum); Handle<DescriptorArray> descs = - Handle<DescriptorArray>(object->map()->instance_descriptors()); + Handle<DescriptorArray>(object->map()->instance_descriptors(), isolate); for (int i = 0; i < descs->number_of_descriptors(); i++) { if (descs->IsProperty(i) && !descs->IsDontEnum(i)) { (*storage)->set(index, descs->GetKey(i)); PropertyDetails details(descs->GetDetails(i)); (*sort_array)->set(index, Smi::FromInt(details.index())); @@ -791,20 +879,21 @@ } } (*storage)->SortPairs(*sort_array, sort_array->length()); if (cache_result) { Handle<FixedArray> bridge_storage = - Factory::NewFixedArray(DescriptorArray::kEnumCacheBridgeLength); + isolate->factory()->NewFixedArray( + DescriptorArray::kEnumCacheBridgeLength); DescriptorArray* desc = object->map()->instance_descriptors(); desc->SetEnumCache(*bridge_storage, *storage); } ASSERT(storage->length() == index); return storage; } else { int num_enum = object->NumberOfEnumProperties(); - Handle<FixedArray> storage = Factory::NewFixedArray(num_enum); - Handle<FixedArray> sort_array = Factory::NewFixedArray(num_enum); + Handle<FixedArray> storage = isolate->factory()->NewFixedArray(num_enum); + Handle<FixedArray> sort_array = isolate->factory()->NewFixedArray(num_enum); object->property_dictionary()->CopyEnumKeysTo(*storage, *sort_array); return storage; } } @@ -817,14 +906,16 @@ static bool CompileLazyHelper(CompilationInfo* info, ClearExceptionFlag flag) { // Compile the source information to a code object. ASSERT(info->IsOptimizing() || !info->shared_info()->is_compiled()); - ASSERT(!Top::has_pending_exception()); + ASSERT(!info->isolate()->has_pending_exception()); bool result = Compiler::CompileLazy(info); - ASSERT(result != Top::has_pending_exception()); - if (!result && flag == CLEAR_EXCEPTION) Top::clear_pending_exception(); + ASSERT(result != Isolate::Current()->has_pending_exception()); + if (!result && flag == CLEAR_EXCEPTION) { + info->isolate()->clear_pending_exception(); + } return result; } bool CompileLazyShared(Handle<SharedFunctionInfo> shared, @@ -861,42 +952,14 @@ ClearExceptionFlag flag) { return CompileLazyFunction(function, flag, IN_LOOP); } -bool CompileOptimized(Handle<JSFunction> function, int osr_ast_id) { +bool CompileOptimized(Handle<JSFunction> function, + int osr_ast_id, + ClearExceptionFlag flag) { CompilationInfo info(function); info.SetOptimizing(osr_ast_id); - return CompileLazyHelper(&info, KEEP_EXCEPTION); -} - - -OptimizedObjectForAddingMultipleProperties:: -OptimizedObjectForAddingMultipleProperties(Handle<JSObject> object, - int expected_additional_properties, - bool condition) { - object_ = object; - if (condition && object_->HasFastProperties() && !object->IsJSGlobalProxy()) { - // Normalize the properties of object to avoid n^2 behavior - // when extending the object multiple properties. Indicate the number of - // properties to be added. - unused_property_fields_ = object->map()->unused_property_fields(); - NormalizeProperties(object_, - KEEP_INOBJECT_PROPERTIES, - expected_additional_properties); - has_been_transformed_ = true; - - } else { - has_been_transformed_ = false; - } -} - - -OptimizedObjectForAddingMultipleProperties:: -~OptimizedObjectForAddingMultipleProperties() { - // Reoptimize the object to allow fast property access. - if (has_been_transformed_) { - TransformToFastProperties(object_, unused_property_fields_); - } + return CompileLazyHelper(&info, flag); } } } // namespace v8::internal