relations_spec.rb in musicbrainz-0.8.0

- old
+ new
@@ -1,44 +1,63 @@
-# -*- encoding: utf-8 -*-
-
 require "spec_helper"
 
 describe MusicBrainz::Bindings::Relations do
   describe '.parse' do
     describe 'attributes' do
       describe 'urls' do
         context '1 url for relation type' do
+          let(:response) {
+            <<-XML
+              <artist>
+                <relation-list target-type="url">
+                  <relation type="social network" type-id="99429741-f3f6-484b-84f8-23af51991770">
+                    <target id="4f4068cb-7001-47a3-a2fe-9146eb6b5d16">https://plus.google.com/+Madonna</target>
+                  </relation>
+                </relation-list>
+              </artist>
+            XML
+          }
+          let(:xml) {
+            Nokogiri::XML.parse(response)
+          }
+          let(:artist) {
+            described_class.parse(xml.xpath('./artist'))
+          }
+
           it 'returns a string' do
-            xml = Nokogiri::XML.parse(
-              %Q{<artist><relation-list target-type="url">
-                <relation type-id="99429741-f3f6-484b-84f8-23af51991770" type="social network">
-                  <target id="4f4068cb-7001-47a3-a2fe-9146eb6b5d16">https://plus.google.com/+Madonna</target>
-                </relation>
-              </relation-list></artist>}
-            )
-            
-            described_class.parse(xml.xpath('./artist'))[:urls][:social_network].should == 'https://plus.google.com/+Madonna'
+            expect(artist[:urls][:social_network]).to eq 'https://plus.google.com/+Madonna'
           end
         end
-        
+
         context 'multiple urls for relation types' do
-          it 'returns an array' do
-            xml = Nokogiri::XML.parse(
-              %Q{<artist><relation-list target-type="url">
-                <relation type-id="99429741-f3f6-484b-84f8-23af51991770" type="social network">
-                  <target id="4f4068cb-7001-47a3-a2fe-9146eb6b5d16">https://plus.google.com/+Madonna</target>
-                </relation>
-                <relation type-id="99429741-f3f6-484b-84f8-23af51991770" type="social network">
-                  <target id="1dc9e14d-ebfb-448c-a005-e3481d320595">https://www.facebook.com/madonna</target>
-                </relation>
-              </relation-list></artist>}
-            )
+          let(:response) {
+            <<-XML
+              <artist>
+                <relation-list target-type="url">
+                  <relation type="social network" type-id="99429741-f3f6-484b-84f8-23af51991770">
+                    <target id="4f4068cb-7001-47a3-a2fe-9146eb6b5d16">https://plus.google.com/+Madonna</target>
+                  </relation>
+                  <relation type="social network" type-id="99429741-f3f6-484b-84f8-23af51991770">
+                    <target id="1dc9e14d-ebfb-448c-a005-e3481d320595">https://www.facebook.com/madonna</target>
+                  </relation>
+                </relation-list>
+              </artist>
+            XML
+          }
+          let(:xml) {
+            Nokogiri::XML.parse(response)
+          }
+          let(:artist) {
+            described_class.parse(xml.xpath('./artist'))
+          }
 
-            described_class.parse(xml.xpath('./artist'))[:urls][:social_network].should == [
-              'https://plus.google.com/+Madonna', 'https://www.facebook.com/madonna'
+          it 'returns an array' do
+            expect(artist[:urls][:social_network]).to eq [
+              'https://plus.google.com/+Madonna',
+              'https://www.facebook.com/madonna',
             ]
           end
         end
       end
     end
   end
-end
\ No newline at end of file
+end