cases_controller.rb in museum-0.5.0

- old
+ new

@@ -1,39 +1,31 @@
 module Museum
   class CasesController < ApplicationController
+    before_action :load_case, except: [:index]
 
     # GET /cases
     def index
       @cases = Museum::Case.all
     end
 
-    # GET /cases/1
+    # GET /cases/gem-name
     def show
-      if load_case
-        @case.freshen_if_expired
-      end
+      @case.freshen_if_expired
     end
 
-    # PATCH/PUT /cases/1/refresh
+    # PATCH/PUT /cases/gem-name/refresh
     def refresh
-      if load_case
-        if @case.freshen
-          redirect_to @case.reload, notice: :success.l
-        else
-          redirect_to @case, error: :failure.l
-        end
+      if @case.freshen
+        redirect_to @case.reload, notice: :success.l
+      else
+        redirect_to @case, error: :failure.l
       end
     end
 
     private
 
-    def not_found
-      render :file => "#{Rails.root}/public/404", :status => :not_found
-      false #return false so things will fail
-    end
-
     def load_case
-      @case = Museum::Case.find_by(name: params[:id]) or not_found
+      @case = Museum::Case.find_by!(name: params[:id])
     end
 
   end
 end
\ No newline at end of file