lib/mojo_magick.rb in mojo_magick-0.5.7 vs lib/mojo_magick.rb in mojo_magick-0.6.0

- old
+ new

@@ -1,17 +1,16 @@ cwd = File.dirname(__FILE__) -require 'open3' -initializers_dir = File.expand_path(File.join(cwd, 'initializers')) -Dir.glob(File.join(initializers_dir, '*.rb')).each { |f| require f } -require File.join(cwd, 'mojo_magick/util/parser') -require File.join(cwd, 'mojo_magick/errors') -require File.join(cwd, 'mojo_magick/command_status') -require File.join(cwd, 'image_magick/resource_limits') -require File.join(cwd, 'image_magick/fonts') -require File.join(cwd, 'mojo_magick/opt_builder') -require File.join(cwd, 'mojo_magick/font') -require 'tempfile' +require "open3" +initializers_dir = File.expand_path(File.join(cwd, "initializers")) +Dir.glob(File.join(initializers_dir, "*.rb")).sort.each { |f| require f } +require File.join(cwd, "mojo_magick/util/parser") +require File.join(cwd, "mojo_magick/errors") +require File.join(cwd, "mojo_magick/command_status") +require File.join(cwd, "image_magick/fonts") +require File.join(cwd, "mojo_magick/opt_builder") +require File.join(cwd, "mojo_magick/font") +require "tempfile" # MojoMagick is a stateless set of module methods which present a convient interface # for accessing common tasks for ImageMagick command line library. # # MojoMagick is specifically designed to be efficient and simple and most importantly @@ -33,11 +32,12 @@ # c.set 'comment', 'my favorite file' # end # # Equivalent to: # -# MojoMagick::raw_command('convert', 'source.jpg -crop 250x250+0+0 +repage -strip -set comment "my favorite file" dest.jpg') +# MojoMagick::raw_command('convert', 'source.jpg -crop 250x250+0+0\ +# +repage -strip -set comment "my favorite file" dest.jpg') # # Example #mogrify usage: # # MojoMagick::mogrify('image.jpg') {|i| i.shave '10x10'} # @@ -59,36 +59,31 @@ # Use .file to specify file names, .blob to create and include a tempfile. The # bang (!) can be appended to command names to use the '+' versions # instead of '-' versions. # module MojoMagick - # enable resource limiting functionality - extend ImageMagick::ResourceLimits extend ImageMagick::Fonts def self.windows? !(RUBY_PLATFORM =~ /win32/).nil? end - def self.execute(command, args, _options = {}) - # this suppress error messages to the console - # err_pipe = windows? ? "2>nul" : "2>/dev/null" - - execute = "#{command} #{get_limits_as_params} #{args}" - out, outerr, status = Open3.capture3(execute) + def self.execute(command, *args) + execute = "#{command} #{args}" + out, outerr, status = Open3.capture3(command, *args.map(&:to_s)) CommandStatus.new execute, out, outerr, status rescue Exception => e raise MojoError, "#{e.class}: #{e.message}" end - def self.execute!(command, args, options = {}) - # this suppress error messages to the console - # err_pipe = windows? ? "2>nul" : "2>/dev/null" - status = execute(command, args, options) + def self.execute!(command, *args) + status = execute(command, *args) unless status.success? - err_msg = options[:err_msg] || "MojoMagick command failed: #{command}." - raise(MojoFailed, "#{err_msg} (Exit status: #{status.exit_code})\n Command: #{status.command}\n Error: #{status.error}") + err_msg = "MojoMagick command failed: #{command}." + raise(MojoFailed, "#{err_msg} (Exit status: #{status.exit_code})\n" + + " Command: #{status.command}\n" + + " Error: #{status.error}") end status.return_value end def self.raw_command(*args) @@ -112,14 +107,14 @@ # :width / :height => scale to these dimensions # :scale => pass scale options such as ">" to force shrink scaling only or "!" to force absolute width/height scaling (do not preserve aspect ratio) # :percent => scale image to this percentage (do not specify :width/:height in this case) def self.resize(source_file, dest_file, options) scale_options = [] - scale_options << '>' unless options[:shrink_only].nil? - scale_options << '<' unless options[:expand_only].nil? - scale_options << '!' unless options[:absolute_aspect].nil? - scale_options << '^' unless options[:fill].nil? + scale_options << ">" unless options[:shrink_only].nil? + scale_options << "<" unless options[:expand_only].nil? + scale_options << "!" unless options[:absolute_aspect].nil? + scale_options << "^" unless options[:fill].nil? scale_options = scale_options.join extras = [] if !options[:width].nil? && !options[:height].nil? geometry = "#{options[:width]}X#{options[:height]}" @@ -127,31 +122,36 @@ geometry = "#{options[:percent]}%" else raise MojoMagickError, "Unknown options for method resize: #{options.inspect}" end if !options[:fill].nil? && !options[:crop].nil? - extras << '-gravity Center' - extras << "-extent #{geometry}" + extras << "-gravity" + extras << "Center" + extras << "-extent" + extras << geometry.to_s end - raw_command('convert', "\"#{source_file}\" -resize \"#{geometry}#{scale_options}\" #{extras.join(' ')} \"#{dest_file}\"") + raw_command("convert", + source_file, + "-resize", "#{geometry}#{scale_options}", + *extras, dest_file) dest_file end def self.available_fonts # returns width, height of image if available, nil if not Font.all end def self.get_format(source_file, format_string) - raw_command('identify', "-format \"#{format_string}\" \"#{source_file}\"") + raw_command("identify", "-format", format_string, source_file) end # returns an empty hash or a hash with :width and :height set (e.g. {:width => INT, :height => INT}) # raises MojoFailed when results are indeterminate (width and height could not be determined) def self.get_image_size(source_file) # returns width, height of image if available, nil if not - retval = get_format(source_file, 'w:%w h:%h') + retval = get_format(source_file, "w:%w h:%h") return {} unless retval width = retval.match(/w:([0-9]+) /) width = width ? width[1].to_i : nil height = retval.match(/h:([0-9]+)/) @@ -164,27 +164,28 @@ def self.convert(source = nil, dest = nil) opts = OptBuilder.new opts.file source if source yield opts opts.file dest if dest - raw_command('convert', opts.to_s) + + raw_command("convert", *opts.to_a) end def self.mogrify(dest = nil) opts = OptBuilder.new yield opts opts.file dest if dest - raw_command('mogrify', opts.to_s) + raw_command("mogrify", *opts.to_a) end def self.tempfile(*opts) data = opts[0] rest = opts[1] ext = rest && rest[:format] - file = Tempfile.new(['mojo', ext ? '.' + ext.to_s : '']) + file = Tempfile.new(["mojo", ext ? ".#{ext}" : ""]) file.binmode file.write(data) file.path ensure file.close end -end # MojoMagick +end