spec/fields/note_spec.rb in mods_display-0.3.3 vs spec/fields/note_spec.rb in mods_display-0.3.4

@@ -1,59 +1,72 @@
-require "spec_helper"
+require 'spec_helper'
 
 def mods_display_note(mods_record)
-  ModsDisplay::Note.new(mods_record, ModsDisplay::Configuration::Base.new, double("controller"))
+  ModsDisplay::Note.new(mods_record, ModsDisplay::Configuration::Base.new, double('controller'))
 end
 
 describe ModsDisplay::Note do
   before(:all) do
-    @note = Stanford::Mods::Record.new.from_str("<mods><note>Note Field</note></mods>", false).note
-    @display_label = Stanford::Mods::Record.new.from_str("<mods><note displayLabel='Special Label'>Note Field</note></mods>", false).note
-    @sor_label = Stanford::Mods::Record.new.from_str("<mods><note type='statement of responsibility'>Note Field</note></mods>", false).note
-    @contact_note = Stanford::Mods::Record.new.from_str("<mods><note type='contact'>[e-mail]</note><note>Note Field</note></mods>", false).note
-    @type_label = Stanford::Mods::Record.new.from_str("<mods><note type='some other Type'>Note Field</note></mods>", false).note
-    @complex_label = Stanford::Mods::Record.new.from_str("<mods><note>Note Field</note><note>2nd Note Field</note><note type='statement of responsibility'>SoR</note><note>Another Note</note></mods>", false).note
+    @note = Stanford::Mods::Record.new.from_str('<mods><note>Note Field</note></mods>', false).note
+    @display_label = Stanford::Mods::Record.new.from_str(
+      "<mods><note displayLabel='Special Label'>Note Field</note></mods>", false
+    ).note
+    @sor_label = Stanford::Mods::Record.new.from_str(
+      "<mods><note type='statement of responsibility'>Note Field</note></mods>", false
+    ).note
+    @contact_note = Stanford::Mods::Record.new.from_str(
+      "<mods><note type='contact'>[e-mail]</note><note>Note Field</note></mods>", false
+    ).note
+    @type_label = Stanford::Mods::Record.new.from_str(
+      "<mods><note type='some other Type'>Note Field</note></mods>", false
+    ).note
+    @complex_label = Stanford::Mods::Record.new.from_str(
+      "<mods>
+        <note>Note Field</note><note>2nd Note Field</note>
+        <note type='statement of responsibility'>SoR</note>
+        <note>Another Note</note>
+      </mods>", false
+    ).note
   end
-  describe "label" do
-    it "should have a default label" do
-      mods_display_note(@note).fields.first.label.should == "Note:"
+  describe 'label' do
+    it 'should have a default label' do
+      expect(mods_display_note(@note).fields.first.label).to eq('Note:')
     end
-    it "should use the displayLabel attribute when one is available" do
-      mods_display_note(@display_label).fields.first.label.should == "Special Label:"
+    it 'should use the displayLabel attribute when one is available' do
+      expect(mods_display_note(@display_label).fields.first.label).to eq('Special Label:')
     end
-    it "should use get a label from a list of translations" do
-      mods_display_note(@sor_label).fields.first.label.should == "Statement of responsibility:"
+    it 'should use get a label from a list of translations' do
+      expect(mods_display_note(@sor_label).fields.first.label).to eq('Statement of responsibility:')
     end
-    it "should use use the capitalized type attribute if one is present" do
-      mods_display_note(@type_label).fields.first.label.should == "Some other type:"
+    it 'should use use the capitalized type attribute if one is present' do
+      expect(mods_display_note(@type_label).fields.first.label).to eq('Some other type:')
     end
   end
-  
-  describe "fields" do
-    it "should handle single values" do
+
+  describe 'fields' do
+    it 'should handle single values' do
       fields = mods_display_note(@note).fields
-      fields.length.should == 1
-      fields.first.values.should == ["Note Field"]
+      expect(fields.length).to eq(1)
+      expect(fields.first.values).to eq(['Note Field'])
     end
-    it "should handle complex grouping" do
+    it 'should handle complex grouping' do
       fields = mods_display_note(@complex_label).fields
-      fields.length.should == 3
-      fields.first.label.should == "Note:"
-      fields.first.values.length == 2
-      fields.first.values.should == ["Note Field", "2nd Note Field"]
-      
-      fields[1].label == "Statement of responsibility"
-      fields[1].values.length == 1
-      fields[1].values.should == ["SoR"]
-      
-      fields.last.label.should == "Note:"
-      fields.last.values.length == 1
-      fields.last.values.should == ["Another Note"]
+      expect(fields.length).to eq(3)
+      expect(fields.first.label).to eq('Note:')
+      expect(fields.first.values.length).to eq 2
+      expect(fields.first.values).to eq(['Note Field', '2nd Note Field'])
+
+      expect(fields[1].label).to eq 'Statement of responsibility:'
+      expect(fields[1].values.length).to eq 1
+      expect(fields[1].values).to eq(['SoR'])
+
+      expect(fields.last.label).to eq('Note:')
+      expect(fields.last.values.length).to eq 1
+      expect(fields.last.values).to eq(['Another Note'])
     end
-    it "should not include any contact fields" do
+    it 'should not include any contact fields' do
       fields = mods_display_note(@contact_note).fields
-      fields.length.should == 1
-      fields.first.values.should == ["Note Field"]
+      expect(fields.length).to eq(1)
+      expect(fields.first.values).to eq(['Note Field'])
     end
   end
-  
-end
\ No newline at end of file
+end