spec/fields/location_spec.rb in mods_display-0.3.5 vs spec/fields/location_spec.rb in mods_display-0.4.0

@@ -1,59 +1,80 @@
 require 'spec_helper'
 
-def mods_display_location(mods_record)
-  ModsDisplay::Location.new(mods_record, ModsDisplay::Configuration::Base.new, double('controller'))
-end
+describe ModsDisplay::Location do
+  let(:location_mods) do
+    <<-XML
+      <mods>
+        <location>
+          <shelfLocation>On Shelf A</shelfLocation>
+        </location>
+      </mods>
+    XML
+  end
 
-describe ModsDisplay::Note do
-  before(:all) do
-    @location = Stanford::Mods::Record.new.from_str(
-      '<mods><location><physicalLocation>The Location</physicalLocation></location></mods>', false
-    ).location
-    @urls = Stanford::Mods::Record.new.from_str(
-      "<mods>
+  let(:url_mods) do
+    <<-XML
+      <mods>
         <location>
           <url displayLabel='Stanford University Library'>http://library.stanford.edu</url>
         </location>
         <location displayLabel='PURL'>
           <url>http://purl.stanford.edu</url>
         </location>
-      </mods>",
-      false
-    ).location
-    @display_label = Stanford::Mods::Record.new.from_str(
-      "<mods><location displayLabel='Special Label'><shelfLocation>On Shelf A</shelfLocation></location></mods>", false
-    ).location
-    @repository_label = Stanford::Mods::Record.new.from_str(
-      "<mods><location><physicalLocation type='repository'>Location Field</physicalLocation></location></mods>", false
-    ).location
+      </mods>
+    XML
   end
+
+  let(:repository_mods) do
+    <<-XML
+      <mods>
+        <location>
+          <physicalLocation type='repository'>Location Field</physicalLocation>
+        </location>
+      </mods>
+    XML
+  end
+
+  let(:location) do
+    mods = Stanford::Mods::Record.new.from_str(location_mods, false).location
+    described_class.new(mods, ModsDisplay::Configuration::Base.new, double('controller')).fields
+  end
+
+  let(:urls) do
+    mods = Stanford::Mods::Record.new.from_str(url_mods, false).location
+    described_class.new(mods, ModsDisplay::Configuration::Base.new, double('controller')).fields
+  end
+
+  let(:repository_label) do
+    mods = Stanford::Mods::Record.new.from_str(repository_mods, false).location
+    described_class.new(mods, ModsDisplay::Configuration::Base.new, double('controller')).fields
+  end
+
   describe 'label' do
     it 'should have a default label' do
-      expect(mods_display_location(@location).fields.first.label).to eq('Location:')
+      expect(location.first.label).to eq 'Location:'
     end
-    it 'should use the displayLabel attribute when one is available' do
-      expect(mods_display_location(@display_label).fields.first.label).to eq('Special Label:')
-    end
+
     it 'should handle the URL labels correctly' do
-      expect(mods_display_location(@urls).fields.map(&:label)).to eq(['Location:', 'PURL:'])
+      expect(urls.map(&:label)).to eq ['Location:', 'PURL:']
     end
+
     it 'should use get a label from a list of translations' do
-      expect(mods_display_location(@repository_label).fields.first.label).to eq('Repository:')
+      expect(repository_label.first.label).to eq 'Repository:'
     end
   end
+
   describe 'fields' do
     describe 'URLs' do
       it 'should link and use the displayLabel as text' do
-        fields = mods_display_location(@urls).fields
-        expect(fields.length).to eq(2)
-        field = fields.find { |f| f.label == 'Location:' }
+        expect(urls.length).to eq(2)
+        field = urls.find { |f| f.label == 'Location:' }
         expect(field.values).to eq(["<a href='http://library.stanford.edu'>Stanford University Library</a>"])
       end
+
       it 'should link the URL itself in the absence of a displayLabel on the url element' do
-        fields = mods_display_location(@urls).fields
-        expect(fields.length).to eq(2)
-        field = fields.find { |f| f.label == 'PURL:' }
+        expect(urls.length).to eq(2)
+        field = urls.find { |f| f.label == 'PURL:' }
         expect(field.values).to eq(["<a href='http://purl.stanford.edu'>http://purl.stanford.edu</a>"])
       end
     end
   end
 end