lib/missile_emitter.rb in missile_emitter-0.3.16 vs lib/missile_emitter.rb in missile_emitter-0.3.17

@@ -1,5 +1,6 @@
+require "active_support/core_ext/string"
 require "missile_emitter/version"
 require "missile_emitter/battle_field"
 
 begin 
   require "pry" 
@@ -14,15 +15,15 @@
 
   class << self
     attr_accessor :mapping
 
     def exec(namespace, &block)
-      raise Error.new("需要提供代码块") unless block_given?
+      raise Error, '需要提供代码块' unless block
 
       context = block.binding.receiver
 
-      raise Error.new("只能再具名模块中调用") unless context.instance_of?(Module) && context.name
+      raise Error, '只能再具名模块中调用' unless context.instance_of?(Module) && context.name
 
       mimic_method context, namespace: namespace
 
       mapping[context] = block
     end
@@ -30,62 +31,22 @@
     private
 
     def mimic_method(context, namespace: true)
       path = context.name
 
-      ns = deconstantize path
-      name = demodulize path
+      ns = path.deconstantize
+      name = path.demodulize
 
       # 处理嵌套模块
-      container = !ns.empty? && namespace ? constantize(ns) : Kernel
+      container = !ns.empty? && namespace ? ns.constantize : Kernel
       action = container == Kernel ? 'define_method' : 'define_singleton_method'
 
       container.send action, name do |*args, &missile|
         klass = missile.binding.receiver
         battle_field = BattleField.new klass, *args, MissileEmitter.mapping[context]
-        battle_field.emit! &missile
+        battle_field.emit!(&missile)
 
         context
-      end
-    end
-
-    def demodulize(path)
-      path = path.to_s
-
-      if i = path.rindex("::")
-        path[(i + 2)..-1]
-      else
-        path
-      end
-    end
-
-    def deconstantize(path)
-      path.to_s[0, path.rindex("::") || 0]
-    end
-
-    def constantize(camel_cased_word)
-      names = camel_cased_word.split("::")
-
-      Object.const_get(camel_cased_word) if names.empty?
-
-      names.shift if names.size > 1 && names.first.empty?
-
-      names.inject(Object) do |constant, name|
-        if constant == Object
-          constant.const_get(name)
-        else
-          candidate = constant.const_get(name)
-          next candidate if constant.const_defined?(name, false)
-          next candidate unless Object.const_defined?(name)
-
-          constant = constant.ancestors.inject(constant) do |const, ancestor|
-            break const    if ancestor == Object
-            break ancestor if ancestor.const_defined?(name, false)
-            const
-          end
-
-          constant.const_get(name, false)
-        end
       end
     end
 
   end