lib/middleman-robots/group.rb in middleman-robots-1.3.2 vs lib/middleman-robots/group.rb in middleman-robots-1.3.3

@@ -13,38 +13,39 @@
       end
 
       def text
         group = []
         group << "User-Agent: #{@user_agent}" unless @user_agent.empty?
-        group << @disallow.collect{|item| "Disallow: #{item}" }.join("\n") if @disallow.length > 0
-        group << @allow.collect{|item| "Allow: #{item}" }.join("\n") if @allow.length > 0
+        group << @disallow.collect { |item| "Disallow: #{item}" }.join("\n") if @disallow.length.positive?
+        group << @allow.collect { |item| "Allow: #{item}" }.join("\n") if @allow.length.positive?
         group.join("\n") + "\n"
       end
 
       private
-        def generate_user_agent(rule)
-          return '*' unless rule.key?('user-agent') || rule.key?(:user_agent)
-          rule[:user_agent] || rule['user-agent']
-        end
 
-        def generate_disallow(rule)
-          paths = []
-          return paths unless rule.has_key?(:disallow)
+      def generate_user_agent(rule)
+        return '*' unless rule.key?('user-agent') || rule.key?(:user_agent)
+        rule[:user_agent] || rule['user-agent']
+      end
 
-          rule[:disallow].each do |path|
-            paths << File.join('/', path)
-          end
-          paths
+      def generate_disallow(rule)
+        paths = []
+        return paths unless rule.key?(:disallow)
+
+        rule[:disallow].each do |path|
+          paths << File.join('/', path)
         end
+        paths
+      end
 
-        def generate_allow(rule)
-          paths = []
-          return paths unless rule.has_key?(:allow)
+      def generate_allow(rule)
+        paths = []
+        return paths unless rule.key?(:allow)
 
-          rule[:allow].each do |path|
-            paths << File.join('/', path)
-          end
-          paths
+        rule[:allow].each do |path|
+          paths << File.join('/', path)
         end
+        paths
+      end
     end
   end
 end