lib/meibo/converter.rb in meibo-0.24.0 vs lib/meibo/converter.rb in meibo-0.25.0

@@ -36,12 +36,12 @@
         build_converter(fields: fields, converters: converters, write_or_parser: "write")
       end
 
       private
 
-      def build_converter(fields:, converters:, write_or_parser:)
-        converter_list = TYPES.filter_map do |converter_type|
+      def build_converter_list(fields:, converters:, write_or_parser:)
+        TYPES.filter_map do |converter_type|
           fields_to_be_converted = converters[converter_type]
           method_name = "build_#{converter_type}_field_#{write_or_parser}_converter"
           if fields_to_be_converted && respond_to?(method_name, true)
             if converter_type == :enum
               enum_definition = fields_to_be_converted.transform_keys { |field| fields.index(field) }
@@ -50,15 +50,23 @@
               indexes = fields_to_be_converted.map { |field| fields.index(field) }
               send(method_name, indexes)
             end
           end
         end
+      end
+
+      def converter_list_to_convert_proc(converter_list)
         lambda do |field, field_info|
           # NOTE: convert blank sourcedId to nil
-          field = nil if field.respond_to?(:empty?) && field.empty?
+          field = nil if field == "NULL" || field == "" # rubocop:disable Style/MultipleComparison
           converter_list.each { |converter| field = converter[field, field_info] }
           field
         end
+      end
+
+      def build_converter(fields:, converters:, write_or_parser:)
+        converter_list = build_converter_list(fields: fields, converters: converters, write_or_parser: write_or_parser).freeze
+        converter_list_to_convert_proc(converter_list)
       end
 
       def build_boolean_field_parser_converter(boolean_field_indexes)
         boolean_field_indexes = boolean_field_indexes.dup.freeze
         lambda do |field, field_info|