test/services/recommender_test.rb in meducation_sdk-1.6.3 vs test/services/recommender_test.rb in meducation_sdk-1.6.4

@@ -1,10 +1,18 @@
 require_relative '../test_helper'
 
 module MeducationSDK
   class RecommenderTest < Minitest::Test
 
+    def setup
+      @per_result = mock
+      @per_result.stubs(where: @per_result)
+      @per_result.stubs(order: @per_result)
+      @per_result.stubs(per: @per_result)
+      @per_result.stubs(to_a: [])
+    end
+
     def empty_response
       mock(body: '[]')
     end
 
     def item
@@ -13,10 +21,14 @@
 
     def item2
       @item2 ||= MediaFile.new({id: 56})
     end
 
+    def item3
+      @item3 ||= MediaFile.new({id: 57})
+    end
+
     def test_should_call_new
       Recommender.expects(:new).with(item, {}).returns(mock(recommend: nil))
       Recommender.recommend(item)
     end
 
@@ -24,39 +36,96 @@
       Recommender.any_instance.expects(:recommend)
       Recommender.recommend(nil)
     end
 
     def test_should_call_the_recommender_service
+      @per_result.expects(:per).with(5).returns(@per_result)
       Net::HTTP.expects(:get_response).with("recommender.meducation.net", "/MediaFile/#{item.id}", 4567).returns(empty_response)
+      MediaFile.expects(:where).with('rating > 2').returns(@per_result)
       Recommender.new(item).recommend
     end
 
     def test_should_call_parse_results_of_recommendation_service
       json = [
         {"type" => "MediaFile", "id" => item.id, "score" => 0.0097},
         {"type" => "MediaFile", "id" => item2.id, "score" => 0.0078}
       ].to_json
 
+      @per_result.expects(:per).with(3).returns(@per_result)
       Net::HTTP.expects(:get_response).returns(mock(body: json))
       MediaFile.expects(:where).with({id: [item.id, item2.id]}).returns([item, item2])
+      MediaFile.expects(:where).with('rating > 2').returns(@per_result)
       items = Recommender.new(item).recommend
       assert_equal [item, item2], items
     end
 
+    def test_should_not_get_more_resources_if_enough_recommendations
+      json = [
+        {"type" => "MediaFile", "id" => item.id, "score" => 0.0097},
+        {"type" => "MediaFile", "id" => item2.id, "score" => 0.0078}
+      ].to_json
+
+      Net::HTTP.expects(:get_response).returns(mock(body: json))
+      MediaFile.expects(:where).with({id: [item.id, item2.id]}).returns([item, item2])
+      MediaFile.expects(:where).with('rating > 2').never
+      items = Recommender.new(item, limit: 2).recommend
+      assert_equal [item, item2], items
+    end
+
+    def test_should_get_more_resources_if_too_few_recommendations
+      json = [
+        {"type" => "MediaFile", "id" => item.id, "score" => 0.0097},
+        {"type" => "MediaFile", "id" => item2.id, "score" => 0.0078}
+      ].to_json
+
+      limit = 5
+
+      @per_result.expects(:per).with(3).returns(@per_result)
+      @per_result.stubs(to_a: [item3])
+
+      Net::HTTP.expects(:get_response).returns(mock(body: json))
+      MediaFile.expects(:where).with({id: [item.id, item2.id]}).returns([item, item2])
+      good_resources = mock
+      MediaFile.expects(:where).with('rating > 2').returns(@per_result)
+      items = Recommender.new(item, limit: limit).recommend
+      assert_equal [item, item2, item3], items
+    end
+
     def test_should_limit_correctly
       items = 6.times.map { |x| MediaFile.new({id: x}) }
       json = items.map {|item| {"type" => "MediaFile", "id" => item.id, "score" => 0.0097} }.to_json
 
       Net::HTTP.expects(:get_response).returns(mock(body: json))
       MediaFile.expects(:where).with({id: items[0..2].map(&:id)}).returns(items[0..2])
       results = Recommender.new(item, limit: 3).recommend
     end
 
-    def test_should_log_an_exception
+    def test_should_log_recommender_exception
+      @per_result.expects(:per).with(5).returns(@per_result)
+      @per_result.stubs(to_a: [item3])
       Net::HTTP.expects(:get_response).raises(StandardError)
       MeducationSDK.config.logger.expects(:error).with("!!Recommender Error!!")
       MeducationSDK.config.logger.expects(:error).with("StandardError")
+      MediaFile.stubs(:where).with('rating > 2').returns(@per_result)
       Recommender.new(item).recommend
+    end
+
+    def test_should_get_good_resources_if_error_from_recommender
+      @per_result.expects(:per).with(5).returns(@per_result)
+      @per_result.stubs(to_a: [item3])
+      Net::HTTP.expects(:get_response).raises(StandardError)
+      MediaFile.stubs(:where).with('rating > 2').returns(@per_result)
+      items = Recommender.new(item).recommend
+      assert_equal [item3], items
+    end
+
+    def test_should_get_good_resources_if_error_from_recommender
+      @per_result.expects(:per).with(5).returns(@per_result)
+      @per_result.stubs(to_a: [item3])
+      Net::HTTP.expects(:get_response).raises(StandardError)
+      MediaFile.stubs(:where).with('rating > 2').returns(@per_result)
+      items = Recommender.new(item).recommend
+      assert_equal [item3], items
     end
 
     def test_should_catch_an_exception_and_render_backup_recommendations
       skip
       recommendation = Item::Recommendation.create!(