unit_system_test.rb in measured-2.0.0.pre2

- old
+ new

@@ -1,22 +1,23 @@
 require "test_helper"
 
 class Measured::UnitSystemTest < ActiveSupport::TestCase
   setup do
-    @conversion = Measured::UnitSystem.new([
-      Measured::Unit.new(:m),
-      Measured::Unit.new(:in, aliases: [:Inch], value: "0.0254 m"),
-      Measured::Unit.new(:ft, aliases: [:Feet, :Foot], value: "0.3048 m"),
-    ])
+    @unit_fireball = CaseSensitiveMagic.unit_system.unit_for!(:fireball)
+
+    @unit_m = Measured::Unit.new(:m)
+    @unit_in = Measured::Unit.new(:in, aliases: [:Inch], value: "0.0254 m")
+    @unit_ft = Measured::Unit.new(:ft, aliases: %w(Feet Foot), value: "0.3048 m")
+    @conversion = Measured::UnitSystem.new([@unit_m, @unit_in, @unit_ft])
   end
 
   test "#unit_names_with_aliases lists all allowed unit names" do
-    assert_equal ["Feet", "Foot", "Inch", "ft", "in", "m"], @conversion.unit_names_with_aliases
+    assert_equal %w(Feet Foot Inch ft in m), @conversion.unit_names_with_aliases
   end
 
   test "#unit_names lists all unit names without aliases" do
-    assert_equal ["ft", "in", "m"], @conversion.unit_names
+    assert_equal %w(ft in m), @conversion.unit_names
   end
 
   test "#unit? checks if the unit is part of the units but not aliases" do
     assert @conversion.unit?(:in)
     assert @conversion.unit?("m")
@@ -42,58 +43,60 @@
   test "#unit_or_alias? with blank and nil arguments" do
     refute @conversion.unit_or_alias?("")
     refute @conversion.unit_or_alias?(nil)
   end
 
-  test "#to_unit_name converts a unit name to its base unit" do
-    assert_equal "fireball", CaseSensitiveMagic.unit_system.to_unit_name("fire")
+  test "#unit_for converts a unit name to its base unit" do
+    assert_equal @unit_fireball, CaseSensitiveMagic.unit_system.unit_for("fire")
   end
 
-  test "#to_unit_name does not care about string or symbol" do
-    assert_equal "fireball", CaseSensitiveMagic.unit_system.to_unit_name(:fire)
+  test "#unit_for does not care about string or symbol" do
+    assert_equal @unit_fireball, CaseSensitiveMagic.unit_system.unit_for(:fire)
   end
 
-  test "#to_unit_name passes through if already base unit name" do
-    assert_equal "fireball", CaseSensitiveMagic.unit_system.to_unit_name("fireball")
+  test "#unit_for passes through if already base unit name" do
+    assert_equal @unit_fireball, CaseSensitiveMagic.unit_system.unit_for("fireball")
   end
 
-  test "#to_unit_name returns nil if not found" do
-    assert_nil CaseSensitiveMagic.unit_system.to_unit_name("thunder")
+  test "#unit_for returns nil if not found" do
+    assert_nil CaseSensitiveMagic.unit_system.unit_for("thunder")
   end
 
-  test "#to_unit_name! converts a unit name to its base unit" do
-    assert_equal "fireball", CaseSensitiveMagic.unit_system.to_unit_name!("fire")
+  test "#unit_for! converts a unit name to its base unit" do
+    assert_equal @unit_fireball, CaseSensitiveMagic.unit_system.unit_for!("fire")
   end
 
-  test "#to_unit_name! does not care about string or symbol" do
-    assert_equal "fireball", CaseSensitiveMagic.unit_system.to_unit_name!(:fire)
+  test "#unit_for! does not care about string or symbol" do
+    assert_equal @unit_fireball, CaseSensitiveMagic.unit_system.unit_for!(:fire)
   end
 
-  test "#to_unit_name! passes through if already base unit name" do
-    assert_equal "fireball", CaseSensitiveMagic.unit_system.to_unit_name!("fireball")
+  test "#unit_for! passes through if already base unit name" do
+    assert_equal @unit_fireball, CaseSensitiveMagic.unit_system.unit_for!("fireball")
   end
 
-  test "#to_unit_name! raises if not found" do
+  test "#unit_for! raises if not found" do
     assert_raises_with_message(Measured::UnitError, "Unit 'thunder' does not exist") do
-      CaseSensitiveMagic.unit_system.to_unit_name!("thunder")
+      CaseSensitiveMagic.unit_system.unit_for!("thunder")
     end
   end
 
   test "#convert raises if either unit is not found" do
+    unit_bad = Measured::Unit.new(:doesnt_exist)
+
     assert_raises Measured::UnitError do
-      CaseSensitiveMagic.unit_system.convert(1, from: "fire", to: "doesnt_exist")
+      CaseSensitiveMagic.unit_system.convert(1, from: @unit_fireball, to: unit_bad)
     end
 
     assert_raises Measured::UnitError do
-      CaseSensitiveMagic.unit_system.convert(1, from: "doesnt_exist", to: "fire")
+      CaseSensitiveMagic.unit_system.convert(1, from: unit_bad, to: @unit_fireball)
     end
   end
 
   test "#convert converts between two known units" do
-    assert_equal BigDecimal("3"), @conversion.convert(BigDecimal("36"), from: "in", to: "ft")
-    assert_equal BigDecimal("18"), @conversion.convert(BigDecimal("1.5"), from: "ft", to: "in")
+    assert_equal 3, @conversion.convert(36, from: @unit_in, to: @unit_ft)
+    assert_equal 18, @conversion.convert(Rational(3, 2), from: @unit_ft, to: @unit_in)
   end
 
   test "#convert handles the same unit" do
-    assert_equal BigDecimal("2"), @conversion.convert(BigDecimal("2"), from: "in", to: "in")
+    assert_equal 2, @conversion.convert(2, from: @unit_in, to: @unit_in)
   end
 end