sms_response_spec.rb in mblox-0.4.1

- old
+ new
@@ -1,26 +1,61 @@
 require "spec_helper"
 
 describe Mblox::SmsResponse do
-  let(:args) { { :request => Mblox::SmsResponse::Result.new(9, "SomeRequest"), :result => Mblox::SmsResponse::Result.new(10, "SomeResult") , :subscriber_result => Mblox::SmsResponse::Result.new(11, "SomeSubscriberResult")  } }
+  describe "validation" do
+    let(:args) { { :request => Mblox::SmsResponse::Result.new(9, "SomeRequest"), :result => Mblox::SmsResponse::Result.new(10, "SomeResult") , :subscriber_result => Mblox::SmsResponse::Result.new(11, "SomeSubscriberResult")  } }
 
-  [:request, :result, :subscriber_result].each do |attr|
-    describe attr do
-      it "cannot be blank" do
-        expect{described_class.new(args.merge(:"#{attr}" => nil))}.to raise_error(Mblox::ValidationError, "#{attr} cannot be blank")
+    [:request, :result, :subscriber_result].each do |attr|
+      describe attr do
+        it "must be a Result" do
+          expect{described_class.new(args.merge(:"#{attr}" => 123))}.to raise_error(Mblox::ValidationError, "#{attr} must be of type Mblox::SmsResponse::Result")
+        end
       end
-      it "must be a Result" do
-        expect{described_class.new(args.merge(:"#{attr}" => 123))}.to raise_error(Mblox::ValidationError, "#{attr} must be of type Mblox::SmsResponse::Result")
+    end
+    [:request, :result].each do |attr|
+      describe attr do
+        it "cannot be blank" do
+          expect{described_class.new(args.merge(:"#{attr}" => nil))}.to raise_error(Mblox::ValidationError, "#{attr} cannot be blank")
+        end
       end
     end
-  end
 
-  it "should raise an error if request, result and subscriber_result are missing" do
-    expect{described_class.new({})}.to raise_error(Mblox::ValidationError, "The following fields cannot be blank: request, result, subscriber_result")
+    describe :subscriber_result do
+      it "cannot be blank if result is ok" do
+        expect{described_class.new(args.merge(:subscriber_result => nil))}.to_not raise_error
+      end
+
+      it "can be blank if result is not ok" do
+        expect{described_class.new(args.merge(:subscriber_result => nil, :result => Mblox::SmsResponse::Result.new(0,'Thumbs Up!')))}.to raise_error(Mblox::ValidationError, "subscriber_result cannot be blank")
+      end
+    end
+
+
+    it "should raise an error if request, result and subscriber_result are missing" do
+      expect{described_class.new({})}.to raise_error(Mblox::ValidationError, "The following fields cannot be blank: request, result")
+    end
+    it "should raise an error if request, result and subscriber_result are the wrong types" do
+      expect{described_class.new(:request => 'A', :result => Time.now, :subscriber_result => 32)}.to raise_error(Mblox::ValidationError, "The following fields must be of type Mblox::SmsResponse::Result: request, result, subscriber_result")
+    end
+    it "should raise an error if an unrecognized attribute is present" do
+      expect{described_class.new(args.merge(:extra_attribute => 'ABC'))}.to raise_error(::ArgumentError, 'Unrecognized attributes: {:extra_attribute=>"ABC"}')
+    end
   end
-  it "should raise an error if request, result and subscriber_result are the wrong types" do
-    expect{described_class.new(:request => 'A', :result => Time.now, :subscriber_result => 32)}.to raise_error(Mblox::ValidationError, "The following fields must be of type Mblox::SmsResponse::Result: request, result, subscriber_result")
-  end
-  it "should raise an error if an unrecognized attribute is present" do
-    expect{described_class.new(args.merge(:extra_attribute => 'ABC'))}.to raise_error(::ArgumentError, 'Unrecognized attributes: {:extra_attribute=>"ABC"}')
+
+  describe "ok/unroutable" do
+    let(:args) { { :request => Mblox::SmsResponse::Result.new(0, "OKRequest"), :result => Mblox::SmsResponse::Result.new(0, "OKResult") , :subscriber_result => Mblox::SmsResponse::Result.new(0, "OKSubscriberResult")  } }
+
+    it "should be ok if all attributes are ok" do
+      described_class.new(args).should be_ok
+    end
+
+    [:request, :result, :subscriber_result].each do |attr|
+      it "should not be ok if #{attr} is not ok" do
+        described_class.new(args.merge(:"#{attr}" => Mblox::SmsResponse::Result.new(1,"NotOK"))).should_not be_ok
+      end
+    end
+
+    it "should be unroutable if subscriber_result is unroutable and other attirbutes are ok" do
+      described_class.new(args.merge(:subscriber_result => Mblox::SmsResponse::Result::UNROUTABLE)).should be_unroutable
+    end
   end
 end