spec/matrioska/app_runner_spec.rb in matrioska-0.2.1 vs spec/matrioska/app_runner_spec.rb in matrioska-0.3.0

@@ -16,31 +16,43 @@
         call.do_stuff_from_a_class
       end
     end
 
     describe "#start" do
+      before do
+        subject.map_app("34*") { call.do_stuff_from_a_block }
+        subject.map_app(5, MockController)
+      end
+
       let(:grxml) {
-        RubySpeech::GRXML.draw mode: 'dtmf', root: 'inputdigits' do
-          rule id: 'inputdigits', scope: 'public' do
+        RubySpeech::GRXML.draw mode: :dtmf, root: 'options' do
+          rule id: 'options', scope: 'public' do
             one_of do
-              0.upto(9) { |d| item { d.to_s } }
-              item { "#" }
-              item { "*" }
+              item { "34*" }
+              item { "5" }
             end
           end
         end
       }
 
       let(:input_component) {
-        Punchblock::Component::Input.new mode: :dtmf, grammar: { value: grxml }
+        Punchblock::Component::Input.new mode: :dtmf, inter_digit_timeout: Adhearsion.config[:matrioska].timeout.to_i * 1_000, grammar: { value: grxml }
       }
 
       it "should start the appropriate component" do
         call.should_receive(:write_and_await_response).with(input_component)
         subject.start
         subject.status.should == :started
       end
+
+      it "should do nothing if #start is called twice" do
+        call.should_receive(:write_and_await_response).once.with(input_component)
+        subject.should_receive(:running?).once.and_return(true)
+        subject.start
+        subject.start
+      end
+
     end
 
     describe "#stop!" do
       let(:mock_component) { double Punchblock::Component::Input, register_event_handler: true }
 
@@ -58,18 +70,21 @@
       end
     end
 
     describe "#map_app" do
       context "with invalid input" do
-        let(:too_long) { "ab" }
-        let(:wrong) { "a" }
+        let(:long_pattern) { "*99" }
+        let(:wrong) { "a12" }
 
-        it "should raise if the first argument is not a single digit string in the range" do
-          expect { subject.map_app(too_long) {} }.to raise_error ArgumentError, "The first argument should be a single digit String or number in the range 1234567890*#"
-          expect { subject.map_app(wrong) {} }.to raise_error ArgumentError, "The first argument should be a single digit String or number in the range 1234567890*#"
+        it "should raise if the first argument has invalid characters" do
+          expect { subject.map_app(wrong) {} }.to raise_error ArgumentError, "The first argument should be a String or number containing only 1234567890*#"
         end
 
+        it "should not raise if the first argument has multiple valid digits" do
+          expect { subject.map_app(long_pattern) {} }.to_not raise_error
+        end
+
         it "raises if called without either a class or a block" do
           expect { subject.map_app 1 }.to raise_error ArgumentError, "You need to provide a block or a controller name."
         end
 
         it "raises if passed both a class and a block" do
@@ -82,11 +97,11 @@
       def mock_event(digit)
         double 'Event', reason: double('Reason', utterance: "dtmf-#{digit}")
       end
 
       before do
-        subject.map_app(3) { call.do_stuff_from_a_block }
+        subject.map_app("34*") { call.do_stuff_from_a_block }
         subject.map_app(5, MockController)
       end
 
       context "if there is no match" do
         it "does nothing, and restarts the launcher" do
@@ -104,16 +119,18 @@
         end
       end
 
       it "executes the block if the payload is a Proc" do
         call.should_receive(:do_stuff_from_a_block).once
+        subject.should_receive(:started?).and_return true
         subject.should_receive(:start).once
-        subject.handle_input_complete mock_event("3")
+        subject.handle_input_complete mock_event("34*")
         sleep 0.1 # Give the controller time to finish and the callback to fire
       end
 
       it "executes the controller if the payload is a Class" do
         call.should_receive(:do_stuff_from_a_class).once
+        subject.should_receive(:started?).and_return true
         subject.should_receive(:start).once
         subject.handle_input_complete mock_event("5")
         sleep 0.1 # Give the controller time to finish and the callback to fire
       end
     end