.rubocop_todo.yml in longleaf-0.2.0.pre.1 vs .rubocop_todo.yml in longleaf-0.3.0

- old
+ new

@@ -1,234 +1,152 @@ # This configuration was generated by # `rubocop --auto-gen-config` -# on 2019-02-14 11:35:09 -0500 using RuboCop version 0.63.1. +# on 2019-05-30 14:23:53 -0400 using RuboCop version 0.70.0. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new # versions of RuboCop, may require this file to be generated again. +# Offense count: 108 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle, IndentationWidth. +# SupportedStyles: with_first_argument, with_fixed_indentation +Layout/AlignArguments: + Enabled: false + # Offense count: 1 # Cop supports --auto-correct. Layout/AlignArray: Exclude: - 'lib/longleaf/preservation_services/rsync_replication_service.rb' -# Offense count: 41 +# Offense count: 60 # Cop supports --auto-correct. -# Configuration parameters: EnforcedHashRocketStyle, EnforcedColonStyle, EnforcedLastArgumentHashStyle. +# Configuration parameters: AllowMultipleStyles, EnforcedHashRocketStyle, EnforcedColonStyle, EnforcedLastArgumentHashStyle. # SupportedHashRocketStyles: key, separator, table # SupportedColonStyles: key, separator, table # SupportedLastArgumentHashStyles: always_inspect, always_ignore, ignore_implicit, ignore_explicit Layout/AlignHash: - Exclude: - - 'lib/longleaf/cli.rb' - - 'lib/longleaf/commands/register_command.rb' - - 'lib/longleaf/logging.rb' - - 'lib/longleaf/preservation_services/rsync_replication_service.rb' - - 'lib/longleaf/services/metadata_deserializer.rb' - - 'lib/longleaf/specs/file_helpers.rb' - - 'spec/longleaf/events/deregister_event_spec.rb' - - 'spec/longleaf/events/preserve_event_spec.rb' - - 'spec/longleaf/events/register_event_spec.rb' - - 'spec/longleaf/services/metadata_serializer_spec.rb' - - 'spec/longleaf/services/service_definition_manager_spec.rb' + Enabled: false -# Offense count: 111 +# Offense count: 3 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, IndentationWidth. # SupportedStyles: with_first_parameter, with_fixed_indentation Layout/AlignParameters: - Enabled: false + Exclude: + - 'lib/longleaf/models/metadata_record.rb' + - 'lib/longleaf/specs/config_builder.rb' + - 'lib/longleaf/specs/metadata_builder.rb' -# Offense count: 192 +# Offense count: 2 # Cop supports --auto-correct. -Layout/BlockEndNewline: - Enabled: false - -# Offense count: 1 -# Cop supports --auto-correct. Layout/ClosingParenthesisIndentation: Exclude: - - 'spec/longleaf/events/deregister_event_spec.rb' + - 'spec/longleaf/services/metadata_persistence_manager_spec.rb' # Offense count: 13 # Cop supports --auto-correct. -Layout/EmptyLinesAroundAccessModifier: +Layout/EmptyLineAfterGuardClause: Exclude: - 'lib/longleaf/candidates/file_selector.rb' - - 'lib/longleaf/candidates/service_candidate_filesystem_iterator.rb' - - 'lib/longleaf/events/register_event.rb' - - 'lib/longleaf/logging/redirecting_logger.rb' - - 'lib/longleaf/preservation_services/fixity_check_service.rb' + - 'lib/longleaf/helpers/digest_helper.rb' + - 'lib/longleaf/indexing/sequel_index_driver.rb' + - 'lib/longleaf/models/file_record.rb' - 'lib/longleaf/preservation_services/rsync_replication_service.rb' - - 'lib/longleaf/services/application_config_deserializer.rb' - - 'lib/longleaf/services/configuration_validator.rb' - - 'lib/longleaf/services/service_class_cache.rb' + - 'lib/longleaf/services/service_manager.rb' - 'lib/longleaf/services/service_mapping_validator.rb' - - 'lib/longleaf/services/storage_location_validator.rb' - - 'spec/longleaf/preservation_services/fixity_check_service_spec.rb' - - 'spec/longleaf/preservation_services/rsync_replication_service_spec.rb' + - 'lib/longleaf/services/storage_location_manager.rb' + - 'lib/longleaf/specs/custom_matchers.rb' + - 'spec/features/deregister_command_spec.rb' -# Offense count: 2 +# Offense count: 16 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. -# SupportedStyles: empty_lines, no_empty_lines -Layout/EmptyLinesAroundBlockBody: - Exclude: - - 'spec/longleaf/models/service_definition_spec.rb' - - 'spec/longleaf/models/storage_location_spec.rb' +# SupportedStyles: around, only_before +Layout/EmptyLinesAroundAccessModifier: + Enabled: false -# Offense count: 3 +# Offense count: 23 # Cop supports --auto-correct. -# Configuration parameters: AllowForAlignment, ForceEqualSignAlignment. -Layout/ExtraSpacing: - Exclude: - - 'spec/longleaf/models/metadata_record_spec.rb' - -# Offense count: 28 -# Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, IndentationWidth. # SupportedStyles: consistent, consistent_relative_to_receiver, special_for_inner_method_call, special_for_inner_method_call_in_parentheses -Layout/FirstParameterIndentation: +Layout/IndentFirstArgument: Exclude: - 'lib/longleaf/candidates/service_candidate_filesystem_iterator.rb' + - 'lib/longleaf/cli.rb' + - 'lib/longleaf/indexing/sequel_index_driver.rb' - 'lib/longleaf/services/application_config_deserializer.rb' - 'lib/longleaf/services/application_config_manager.rb' - - 'lib/longleaf/services/metadata_deserializer.rb' - 'lib/longleaf/services/service_definition_manager.rb' - 'lib/longleaf/services/storage_location_validator.rb' + - 'lib/longleaf/specs/metadata_builder.rb' - 'spec/features/deregister_command_spec.rb' - 'spec/features/register_command_spec.rb' - 'spec/features/validate_application_config_spec.rb' - - 'spec/longleaf/candidates/file_selector_spec.rb' - 'spec/longleaf/logging/redirecting_logger_spec.rb' - - 'spec/longleaf/services/metadata_serializer_spec.rb' -# Offense count: 10 +# Offense count: 19 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, IndentationWidth. # SupportedStyles: special_inside_parentheses, consistent, align_braces -Layout/IndentHash: +Layout/IndentFirstHashElement: Exclude: + - 'lib/longleaf/cli.rb' + - 'lib/longleaf/indexing/sequel_index_driver.rb' - 'spec/longleaf/candidates/service_candidate_filesystem_iterator_spec.rb' - 'spec/longleaf/preservation_services/fixity_check_service_spec.rb' - 'spec/longleaf/preservation_services/rsync_replication_service_spec.rb' -# Offense count: 1 +# Offense count: 11 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. -# SupportedStyles: normal, rails -Layout/IndentationConsistency: - Exclude: - - 'spec/longleaf/services/application_config_deserializer_spec.rb' - -# Offense count: 13 -# Cop supports --auto-correct. -# Configuration parameters: Width, IgnoredPatterns. -Layout/IndentationWidth: - Exclude: - - 'lib/longleaf/candidates/file_selector.rb' - - 'lib/longleaf/candidates/service_candidate_filesystem_iterator.rb' - - 'lib/longleaf/events/register_event.rb' - - 'lib/longleaf/logging/redirecting_logger.rb' - - 'lib/longleaf/preservation_services/fixity_check_service.rb' - - 'lib/longleaf/preservation_services/rsync_replication_service.rb' - - 'lib/longleaf/services/application_config_deserializer.rb' - - 'lib/longleaf/services/configuration_validator.rb' - - 'lib/longleaf/services/service_class_cache.rb' - - 'lib/longleaf/services/service_mapping_validator.rb' - - 'lib/longleaf/services/storage_location_validator.rb' - - 'spec/longleaf/preservation_services/fixity_check_service_spec.rb' - - 'spec/longleaf/preservation_services/rsync_replication_service_spec.rb' - -# Offense count: 192 -# Cop supports --auto-correct. -Layout/MultilineBlockLayout: - Enabled: false - -# Offense count: 2 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle. # SupportedStyles: symmetrical, new_line, same_line Layout/MultilineHashBraceLayout: Exclude: + - 'lib/longleaf/cli.rb' + - 'lib/longleaf/indexing/sequel_index_driver.rb' - 'spec/longleaf/preservation_services/fixity_check_service_spec.rb' - 'spec/longleaf/preservation_services/rsync_replication_service_spec.rb' -# Offense count: 31 +# Offense count: 47 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: symmetrical, new_line, same_line Layout/MultilineMethodCallBraceLayout: - Exclude: - - 'lib/longleaf/candidates/service_candidate_filesystem_iterator.rb' - - 'lib/longleaf/services/application_config_deserializer.rb' - - 'lib/longleaf/services/application_config_manager.rb' - - 'lib/longleaf/services/metadata_deserializer.rb' - - 'lib/longleaf/services/service_definition_manager.rb' - - 'lib/longleaf/services/storage_location_validator.rb' - - 'spec/features/deregister_command_spec.rb' - - 'spec/features/register_command_spec.rb' - - 'spec/features/validate_application_config_spec.rb' - - 'spec/longleaf/events/deregister_event_spec.rb' - - 'spec/longleaf/logging/redirecting_logger_spec.rb' - - 'spec/longleaf/services/metadata_serializer_spec.rb' + Enabled: false -# Offense count: 261 +# Offense count: 422 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, IndentationWidth. # SupportedStyles: aligned, indented, indented_relative_to_receiver Layout/MultilineMethodCallIndentation: Enabled: false -# Offense count: 18 +# Offense count: 26 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces. -# SupportedStyles: space, no_space -# SupportedStylesForEmptyBraces: space, no_space -Layout/SpaceBeforeBlockBraces: - Exclude: - - 'lib/longleaf/services/service_manager.rb' - - 'spec/longleaf/candidates/file_selector_spec.rb' - - 'spec/longleaf/helpers/service_date_helper_spec.rb' - - 'spec/longleaf/services/service_class_cache_spec.rb' - - 'spec/longleaf/services/service_manager_spec.rb' - -# Offense count: 14 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters. -# SupportedStyles: space, no_space -# SupportedStylesForEmptyBraces: space, no_space -Layout/SpaceInsideBlockBraces: - Exclude: - - 'spec/longleaf/candidates/file_selector_spec.rb' - - 'spec/longleaf/logging/redirecting_logger_spec.rb' - - 'spec/longleaf/models/metadata_record_spec.rb' - - 'spec/longleaf/models/storage_location_spec.rb' - - 'spec/longleaf/services/metadata_serializer_spec.rb' - - 'spec/longleaf/services/service_class_cache_spec.rb' - - 'spec/longleaf/services/service_manager_spec.rb' - -# Offense count: 23 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces. # SupportedStyles: space, no_space, compact # SupportedStylesForEmptyBraces: space, no_space Layout/SpaceInsideHashLiteralBraces: Exclude: + - 'lib/longleaf/commands/reindex_command.rb' + - 'spec/features/rsync_replication_feature_spec.rb' - 'spec/longleaf/candidates/service_candidate_filesystem_iterator_spec.rb' - 'spec/longleaf/models/metadata_record_spec.rb' - 'spec/longleaf/models/service_record_spec.rb' - 'spec/longleaf/preservation_services/fixity_check_service_spec.rb' - 'spec/longleaf/services/metadata_serializer_spec.rb' -# Offense count: 38 +# Offense count: 41 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: space, no_space Layout/SpaceInsideParens: Exclude: + - 'lib/longleaf/indexing/sequel_index_driver.rb' + - 'spec/features/rsync_replication_feature_spec.rb' - 'spec/longleaf/events/deregister_event_spec.rb' - 'spec/longleaf/events/preserve_event_spec.rb' - 'spec/longleaf/events/register_event_spec.rb' - 'spec/longleaf/models/metadata_record_spec.rb' - 'spec/longleaf/models/service_definition_spec.rb' @@ -237,253 +155,350 @@ - 'spec/longleaf/preservation_services/rsync_replication_service_spec.rb' - 'spec/longleaf/services/metadata_serializer_spec.rb' - 'spec/longleaf/services/service_definition_validator_spec.rb' - 'spec/longleaf/services/storage_location_validator_spec.rb' -# Offense count: 70 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle. -# SupportedStyles: final_newline, final_blank_line -Layout/TrailingBlankLines: - Enabled: false - -# Offense count: 1158 -# Cop supports --auto-correct. -# Configuration parameters: AllowInHeredoc. -Layout/TrailingWhitespace: - Enabled: false - -# Offense count: 4 -Lint/IneffectiveAccessModifier: +# Offense count: 1 +Lint/EmptyWhen: Exclude: - - 'lib/longleaf/services/application_config_deserializer.rb' - - 'lib/longleaf/services/configuration_validator.rb' - - 'lib/longleaf/services/service_mapping_validator.rb' - - 'lib/longleaf/services/storage_location_validator.rb' + - 'lib/longleaf/candidates/service_candidate_index_iterator.rb' -# Offense count: 1 +# Offense count: 11 Lint/ParenthesesAsGroupedExpression: Exclude: + - 'spec/features/metadata_indexing_spec.rb' + - 'spec/features/reindex_command_spec.rb' - 'spec/longleaf/models/metadata_record_spec.rb' -# Offense count: 2 +# Offense count: 10 # Cop supports --auto-correct. -Lint/StringConversionInInterpolation: - Exclude: - - 'lib/longleaf/logging/redirecting_logger.rb' - - 'lib/longleaf/preservation_services/fixity_check_service.rb' - -# Offense count: 7 -# Cop supports --auto-correct. # Configuration parameters: IgnoreEmptyBlocks, AllowUnusedKeywordArguments. Lint/UnusedBlockArgument: Exclude: - 'lib/longleaf/commands/validate_config_command.rb' - 'lib/longleaf/logging/redirecting_logger.rb' + - 'lib/longleaf/services/application_config_deserializer.rb' - 'lib/longleaf/services/service_mapping_manager.rb' - 'lib/longleaf/services/storage_location_manager.rb' -# Offense count: 3 +# Offense count: 4 # Cop supports --auto-correct. # Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods. Lint/UnusedMethodArgument: Exclude: + - 'lib/longleaf/preservation_services/file_check_service.rb' - 'lib/longleaf/preservation_services/fixity_check_service.rb' - 'lib/longleaf/preservation_services/rsync_replication_service.rb' -# Offense count: 4 -# Configuration parameters: ContextCreatingMethods, MethodCreatingMethods. -Lint/UselessAccessModifier: - Exclude: - - 'lib/longleaf/services/application_config_deserializer.rb' - - 'lib/longleaf/services/configuration_validator.rb' - - 'lib/longleaf/services/service_mapping_validator.rb' - - 'lib/longleaf/services/storage_location_validator.rb' - -# Offense count: 11 +# Offense count: 6 Lint/UselessAssignment: Exclude: - 'lib/longleaf/cli.rb' - - 'lib/longleaf/commands/preserve_command.rb' + - 'lib/longleaf/indexing/sequel_index_driver.rb' - 'lib/longleaf/preservation_services/rsync_replication_service.rb' - 'lib/longleaf/services/application_config_deserializer.rb' - - 'lib/longleaf/services/service_class_cache.rb' - - 'lib/longleaf/services/service_definition_validator.rb' - - 'lib/longleaf/services/service_mapping_validator.rb' - 'spec/longleaf/events/register_event_spec.rb' -# Offense count: 6 +# Offense count: 44 Metrics/AbcSize: - Max: 43 + Max: 45 -# Offense count: 88 +# Offense count: 1 # Configuration parameters: CountComments, ExcludedMethods. # ExcludedMethods: refine Metrics/BlockLength: - Max: 309 + Max: 36 -# Offense count: 1 +# Offense count: 2 # Configuration parameters: CountBlocks. Metrics/BlockNesting: Max: 4 -# Offense count: 2 +# Offense count: 3 # Configuration parameters: CountComments. Metrics/ClassLength: - Max: 118 + Max: 212 -# Offense count: 13 +# Offense count: 16 Metrics/CyclomaticComplexity: - Max: 10 + Max: 11 -# Offense count: 2 -# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns. +# Offense count: 4 +# Cop supports --auto-correct. +# Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns. # URISchemes: http, https Metrics/LineLength: - Max: 249 + Max: 299 -# Offense count: 21 +# Offense count: 56 # Configuration parameters: CountComments, ExcludedMethods. Metrics/MethodLength: - Max: 38 + Max: 40 # Offense count: 7 # Configuration parameters: CountKeywordArgs. Metrics/ParameterLists: Max: 7 -# Offense count: 8 +# Offense count: 13 Metrics/PerceivedComplexity: - Max: 12 + Max: 13 # Offense count: 2 +Naming/AccessorMethodName: + Exclude: + - 'lib/longleaf/specs/metadata_builder.rb' + - 'spec/features/reindex_command_spec.rb' + +# Offense count: 1 +Naming/BinaryOperatorParameterName: + Exclude: + - 'lib/longleaf/models/file_record.rb' + +# Offense count: 4 # Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist, MethodDefinitionMacros. # NamePrefix: is_, has_, have_ # NamePrefixBlacklist: is_, has_, have_ # NameWhitelist: is_a? # MethodDefinitionMacros: define_method, define_singleton_method Naming/PredicateName: Exclude: - 'spec/**/*' + - 'lib/longleaf/indexing/sequel_index_driver.rb' + - 'lib/longleaf/preservation_services/file_check_service.rb' - 'lib/longleaf/preservation_services/fixity_check_service.rb' - 'lib/longleaf/preservation_services/rsync_replication_service.rb' +# Offense count: 22 +# Cop supports --auto-correct. +# Configuration parameters: PreferredName. +Naming/RescuedExceptionsVariableName: + Exclude: + - 'lib/longleaf/cli.rb' + - 'lib/longleaf/commands/deregister_command.rb' + - 'lib/longleaf/commands/preserve_command.rb' + - 'lib/longleaf/commands/register_command.rb' + - 'lib/longleaf/commands/reindex_command.rb' + - 'lib/longleaf/commands/validate_config_command.rb' + - 'lib/longleaf/commands/validate_metadata_command.rb' + - 'lib/longleaf/events/deregister_event.rb' + - 'lib/longleaf/events/register_event.rb' + - 'lib/longleaf/services/application_config_deserializer.rb' + - 'lib/longleaf/services/metadata_deserializer.rb' + - 'lib/longleaf/services/storage_location_validator.rb' + - 'spec/longleaf/logging/redirecting_logger_spec.rb' + # Offense count: 4 +# Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames. +# AllowedNames: io, id, to, by, on, in, at, ip, db +Naming/UncommunicativeMethodParamName: + Exclude: + - 'lib/longleaf/logging/redirecting_logger.rb' + +# Offense count: 4 # Configuration parameters: EnforcedStyle. # SupportedStyles: snake_case, camelCase Naming/VariableName: Exclude: - 'lib/longleaf/logging/redirecting_logger.rb' # Offense count: 1 # Cop supports --auto-correct. -Performance/RedundantMatch: +Performance/RedundantBlockCall: Exclude: - - 'lib/longleaf/cli.rb' + - 'lib/longleaf/indexing/sequel_index_driver.rb' # Offense count: 1 # Cop supports --auto-correct. -Performance/ReverseEach: +Performance/RedundantMatch: Exclude: - - 'lib/longleaf/candidates/file_selector.rb' + - 'lib/longleaf/cli.rb' -# Offense count: 4 +# Offense count: 2 +RSpec/BeforeAfterAll: + Exclude: + - 'spec/spec_helper.rb' + - 'spec/rails_helper.rb' + - 'spec/support/**/*.rb' + - 'spec/features/metadata_indexing_spec.rb' + - 'spec/features/reindex_command_spec.rb' + +# Offense count: 308 +# Configuration parameters: Prefixes. +# Prefixes: when, with, without +RSpec/ContextWording: + Enabled: false + +# Offense count: 12 RSpec/DescribeClass: Exclude: + - 'spec/features/cli_spec.rb' - 'spec/features/deregister_command_spec.rb' + - 'spec/features/file_check_feature_spec.rb' + - 'spec/features/fixity_check_feature_spec.rb' + - 'spec/features/metadata_digests_spec.rb' + - 'spec/features/metadata_indexing_spec.rb' - 'spec/features/preserve_command_spec.rb' - 'spec/features/register_command_spec.rb' + - 'spec/features/reindex_command_spec.rb' + - 'spec/features/rsync_replication_feature_spec.rb' - 'spec/features/validate_application_config_spec.rb' + - 'spec/features/validate_metadata_command_spec.rb' -# Offense count: 49 +# Offense count: 57 # Cop supports --auto-correct. # Configuration parameters: SkipBlocks, EnforcedStyle. # SupportedStyles: described_class, explicit RSpec/DescribedClass: Enabled: false -# Offense count: 18 +# Offense count: 2 +# Cop supports --auto-correct. +RSpec/EmptyLineAfterExampleGroup: + Exclude: + - 'spec/longleaf/models/storage_location_spec.rb' + +# Offense count: 31 +# Cop supports --auto-correct. +RSpec/EmptyLineAfterFinalLet: + Exclude: + - 'spec/longleaf/candidates/service_candidate_filesystem_iterator_spec.rb' + - 'spec/longleaf/indexing/sequel_index_driver_spec.rb' + - 'spec/longleaf/models/metadata_record_spec.rb' + - 'spec/longleaf/preservation_services/fixity_check_service_spec.rb' + - 'spec/longleaf/services/metadata_deserializer_spec.rb' + - 'spec/longleaf/services/storage_location_validator_spec.rb' + - 'spec/support/shared_examples/file_selector_examples.rb' + +# Offense count: 5 +# Cop supports --auto-correct. +RSpec/EmptyLineAfterHook: + Exclude: + - 'spec/features/register_command_spec.rb' + - 'spec/longleaf/services/service_class_cache_spec.rb' + +# Offense count: 33 # Configuration parameters: Max. RSpec/ExampleLength: + Enabled: false + +# Offense count: 2 +RSpec/ExpectInHook: Exclude: - - 'spec/features/deregister_command_spec.rb' - - 'spec/longleaf/events/deregister_event_spec.rb' - - 'spec/longleaf/events/preserve_event_spec.rb' + - 'spec/features/metadata_indexing_spec.rb' - 'spec/longleaf/events/register_event_spec.rb' - - 'spec/longleaf/logging/redirecting_logger_spec.rb' - - 'spec/longleaf/preservation_services/rsync_replication_service_spec.rb' - - 'spec/longleaf/services/metadata_deserializer_spec.rb' - - 'spec/longleaf/services/metadata_serializer_spec.rb' - - 'spec/longleaf/services/service_definition_manager_spec.rb' -# Offense count: 14 +# Offense count: 31 +# Configuration parameters: CustomTransform, IgnoreMethods. +RSpec/FilePath: + Enabled: false + +# Offense count: 19 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: implicit, each, example RSpec/HookArgument: Exclude: + - 'spec/features/metadata_digests_spec.rb' + - 'spec/features/validate_application_config_spec.rb' - 'spec/longleaf/models/storage_location_spec.rb' - 'spec/longleaf/preservation_services/rsync_replication_service_spec.rb' - 'spec/longleaf/services/application_config_deserializer_spec.rb' - 'spec/longleaf/services/application_config_validator_spec.rb' - 'spec/longleaf/services/metadata_deserializer_spec.rb' - 'spec/longleaf/services/service_manager_spec.rb' -# Offense count: 8 +# Offense count: 10 +# Configuration parameters: AssignmentOnly. +RSpec/InstanceVariable: + Exclude: + - 'spec/features/metadata_indexing_spec.rb' + - 'spec/features/reindex_command_spec.rb' + - 'spec/longleaf/indexing/sequel_index_driver_spec.rb' + +# Offense count: 1 +# Cop supports --auto-correct. +RSpec/LetBeforeExamples: + Exclude: + - 'spec/longleaf/models/metadata_record_spec.rb' + +# Offense count: 15 RSpec/LetSetup: Exclude: + - 'spec/features/metadata_indexing_spec.rb' - 'spec/features/preserve_command_spec.rb' - 'spec/longleaf/candidates/service_candidate_filesystem_iterator_spec.rb' + - 'spec/longleaf/candidates/service_candidate_index_iterator_spec.rb' + - 'spec/longleaf/indexing/sequel_index_driver_spec.rb' -# Offense count: 4 +# Offense count: 11 # Configuration parameters: . # SupportedStyles: have_received, receive RSpec/MessageSpies: EnforcedStyle: receive -# Offense count: 63 +# Offense count: 187 +# Configuration parameters: AggregateFailuresByDefault. +RSpec/MultipleExpectations: + Max: 9 + +# Offense count: 126 +RSpec/NestedGroups: + Max: 5 + +# Offense count: 84 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: not_to, to_not RSpec/NotToNot: Enabled: false +# Offense count: 12 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle. +# SupportedStyles: and_return, block +RSpec/ReturnFromStub: + Exclude: + - 'spec/longleaf/events/preserve_event_spec.rb' + +# Offense count: 42 +RSpec/ScatteredLet: + Exclude: + - 'spec/features/fixity_check_feature_spec.rb' + - 'spec/features/metadata_indexing_spec.rb' + - 'spec/features/reindex_command_spec.rb' + - 'spec/features/rsync_replication_feature_spec.rb' + - 'spec/longleaf/candidates/service_candidate_filesystem_iterator_spec.rb' + - 'spec/longleaf/candidates/service_candidate_index_iterator_spec.rb' + - 'spec/longleaf/candidates/service_candidate_locator_spec.rb' + - 'spec/longleaf/events/deregister_event_spec.rb' + - 'spec/longleaf/indexing/sequel_index_driver_spec.rb' + - 'spec/longleaf/models/metadata_record_spec.rb' + - 'spec/longleaf/services/service_manager_spec.rb' + - 'spec/support/shared_examples/file_selector_examples.rb' + # Offense count: 3 # Configuration parameters: IgnoreNameless, IgnoreSymbolicNames. RSpec/VerifiedDoubles: Exclude: - 'spec/longleaf/preservation_services/fixity_check_service_spec.rb' - 'spec/longleaf/services/service_class_cache_spec.rb' - 'spec/longleaf/services/service_manager_spec.rb' -# Offense count: 7 -# Configuration parameters: Include. -# Include: app/**/*.rb, config/**/*.rb, lib/**/*.rb -Rails/Exit: +# Offense count: 1 +RSpec/VoidExpect: Exclude: - - 'lib/**/*.rake' - - 'lib/longleaf/cli.rb' + - 'spec/longleaf/indexing/sequel_index_driver_spec.rb' -# Offense count: 8 -# Configuration parameters: EnforcedStyle. -# SupportedStyles: strict, flexible -Rails/TimeZone: - Exclude: - - 'lib/longleaf/helpers/service_date_helper.rb' - - 'spec/features/preserve_command_spec.rb' - - 'spec/longleaf/events/deregister_event_spec.rb' - - 'spec/longleaf/events/preserve_event_spec.rb' - - 'spec/longleaf/logging/redirecting_logger_spec.rb' - - 'spec/longleaf/models/metadata_record_spec.rb' - -# Offense count: 1 +# Offense count: 2 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: always, conditionals Style/AndOr: Exclude: - 'lib/longleaf/candidates/file_selector.rb' + - 'lib/longleaf/candidates/registered_file_selector.rb' # Offense count: 1 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: percent_q, bare_percent @@ -495,51 +510,76 @@ # Cop supports --auto-correct. Style/BlockComments: Exclude: - 'spec/spec_helper.rb' -# Offense count: 134 +# Offense count: 200 # Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, ProceduralMethods, FunctionalMethods, IgnoredMethods. -# SupportedStyles: line_count_based, semantic, braces_for_chaining +# Configuration parameters: EnforcedStyle, ProceduralMethods, FunctionalMethods, IgnoredMethods, AllowBracesOnProceduralOneLiners. +# SupportedStyles: line_count_based, semantic, braces_for_chaining, always_braces # ProceduralMethods: benchmark, bm, bmbm, create, each_with_object, measure, new, realtime, tap, with_object # FunctionalMethods: let, let!, subject, watch # IgnoredMethods: lambda, proc, it Style/BlockDelimiters: Enabled: false -# Offense count: 66 +# Offense count: 10 # Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle. +# SupportedStyles: braces, no_braces, context_dependent +Style/BracesAroundHashParameters: + Exclude: + - 'lib/longleaf/cli.rb' + - 'lib/longleaf/indexing/sequel_index_driver.rb' + +# Offense count: 1 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle. +# SupportedStyles: is_a?, kind_of? +Style/ClassCheck: + Exclude: + - 'lib/longleaf/specs/metadata_builder.rb' + +# Offense count: 82 +# Cop supports --auto-correct. Style/ColonMethodCall: + Enabled: false + +# Offense count: 1 +# Cop supports --auto-correct. +# Configuration parameters: Keywords. +# Keywords: TODO, FIXME, OPTIMIZE, HACK, REVIEW +Style/CommentAnnotation: Exclude: - - 'lib/longleaf/events/deregister_event.rb' - - 'lib/longleaf/events/preserve_event.rb' - - 'lib/longleaf/events/register_event.rb' - - 'lib/longleaf/models/storage_location.rb' - - 'lib/longleaf/services/application_config_validator.rb' - - 'lib/longleaf/services/storage_location_validator.rb' - - 'spec/features/deregister_command_spec.rb' - - 'spec/features/register_command_spec.rb' - - 'spec/longleaf/events/register_event_spec.rb' - - 'spec/longleaf/services/application_config_deserializer_spec.rb' - - 'spec/longleaf/services/application_config_validator_spec.rb' - - 'spec/longleaf/services/service_definition_validator_spec.rb' - - 'spec/longleaf/services/service_mapping_validator_spec.rb' - - 'spec/longleaf/services/storage_location_validator_spec.rb' - - 'spec/longleaf/services/storage_path_validator_spec.rb' + - 'spec/longleaf/candidates/service_candidate_index_iterator_spec.rb' -# Offense count: 4 +# Offense count: 11 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, SingleLineConditionsOnly, IncludeTernaryExpressions. # SupportedStyles: assign_to_condition, assign_inside_condition Style/ConditionalAssignment: Exclude: - 'lib/longleaf/events/event_status_tracking.rb' + - 'lib/longleaf/indexing/sequel_index_driver.rb' - 'lib/longleaf/logging/redirecting_logger.rb' + - 'lib/longleaf/models/storage_location.rb' - 'lib/longleaf/preservation_services/rsync_replication_service.rb' + - 'lib/longleaf/services/application_config_deserializer.rb' + - 'lib/longleaf/services/metadata_deserializer.rb' + - 'lib/longleaf/services/metadata_serializer.rb' + - 'lib/longleaf/specs/metadata_builder.rb' + - 'spec/features/reindex_command_spec.rb' -# Offense count: 41 +# Offense count: 2 +Style/Documentation: + Exclude: + - 'spec/**/*' + - 'test/**/*' + - 'lib/longleaf.rb' + - 'lib/longleaf/specs/custom_matchers.rb' + +# Offense count: 52 # Cop supports --auto-correct. Style/EmptyLiteral: Enabled: false # Offense count: 1 @@ -548,208 +588,247 @@ # SupportedStyles: format, sprintf, percent Style/FormatString: Exclude: - 'lib/longleaf/logging/redirecting_logger.rb' -# Offense count: 93 +# Offense count: 119 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. -# SupportedStyles: when_needed, always, never +# SupportedStyles: always, never Style/FrozenStringLiteralComment: Enabled: false -# Offense count: 8 +# Offense count: 13 # Configuration parameters: MinBodyLength. Style/GuardClause: Exclude: - 'lib/longleaf/candidates/file_selector.rb' + - 'lib/longleaf/candidates/registered_file_selector.rb' + - 'lib/longleaf/candidates/service_candidate_index_iterator.rb' - 'lib/longleaf/cli.rb' - 'lib/longleaf/helpers/service_date_helper.rb' + - 'lib/longleaf/indexing/sequel_index_driver.rb' + - 'lib/longleaf/preservation_services/file_check_service.rb' - 'lib/longleaf/preservation_services/fixity_check_service.rb' + - 'lib/longleaf/services/metadata_persistence_manager.rb' - 'lib/longleaf/services/storage_location_manager.rb' -# Offense count: 50 +# Offense count: 59 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, UseHashRocketsWithSymbolValues, PreferHashRocketsForNonAlnumEndingSymbols. # SupportedStyles: ruby19, hash_rockets, no_mixed_keys, ruby19_no_mixed_keys Style/HashSyntax: - Exclude: - - 'Rakefile' - - 'lib/longleaf/cli.rb' - - 'lib/longleaf/logging/redirecting_logger.rb' - - 'spec/features/deregister_command_spec.rb' - - 'spec/features/preserve_command_spec.rb' - - 'spec/features/register_command_spec.rb' - - 'spec/features/validate_application_config_spec.rb' - - 'spec/longleaf/events/preserve_event_spec.rb' - - 'spec/longleaf/services/metadata_serializer_spec.rb' + Enabled: false # Offense count: 3 Style/IfInsideElse: Exclude: - 'lib/longleaf/preservation_services/fixity_check_service.rb' - 'lib/longleaf/preservation_services/rsync_replication_service.rb' -# Offense count: 23 +# Offense count: 32 # Cop supports --auto-correct. Style/IfUnlessModifier: + Enabled: false + +# Offense count: 1 +# Cop supports --auto-correct. +# Configuration parameters: InverseMethods, InverseBlocks. +Style/InverseMethods: Exclude: - - 'lib/longleaf/candidates/file_selector.rb' - - 'lib/longleaf/candidates/service_candidate_filesystem_iterator.rb' - - 'lib/longleaf/cli.rb' - - 'lib/longleaf/commands/deregister_command.rb' - - 'lib/longleaf/events/deregister_event.rb' - - 'lib/longleaf/events/preserve_event.rb' - - 'lib/longleaf/events/register_event.rb' - - 'lib/longleaf/preservation_services/fixity_check_service.rb' - - 'lib/longleaf/preservation_services/rsync_replication_service.rb' - - 'lib/longleaf/services/metadata_deserializer.rb' - - 'lib/longleaf/services/service_class_cache.rb' + - 'lib/longleaf/helpers/digest_helper.rb' # Offense count: 3 # Cop supports --auto-correct. # Configuration parameters: IgnoredMethods. Style/MethodCallWithoutArgsParentheses: Exclude: - - 'spec/longleaf/candidates/file_selector_spec.rb' - 'spec/longleaf/services/metadata_deserializer_spec.rb' + - 'spec/support/shared_examples/file_selector_examples.rb' -# Offense count: 2 +# Offense count: 1 # Cop supports --auto-correct. Style/MultilineIfModifier: Exclude: - 'lib/longleaf/preservation_services/rsync_replication_service.rb' -# Offense count: 48 +# Offense count: 2 +Style/MultipleComparison: + Exclude: + - 'lib/longleaf/candidates/file_selector.rb' + - 'lib/longleaf/candidates/registered_file_selector.rb' + +# Offense count: 59 # Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle. +# SupportedStyles: literals, strict Style/MutableConstant: Exclude: + - 'lib/longleaf/candidates/file_selector.rb' - 'lib/longleaf/events/event_names.rb' + - 'lib/longleaf/helpers/digest_helper.rb' + - 'lib/longleaf/indexing/sequel_index_driver.rb' - 'lib/longleaf/models/app_fields.rb' - 'lib/longleaf/models/md_fields.rb' - 'lib/longleaf/models/service_fields.rb' + - 'lib/longleaf/models/system_config_fields.rb' - 'lib/longleaf/preservation_services/fixity_check_service.rb' - 'lib/longleaf/preservation_services/rsync_replication_service.rb' - 'lib/longleaf/services/service_class_cache.rb' - 'lib/longleaf/version.rb' + - 'spec/features/fixity_check_feature_spec.rb' - 'spec/longleaf/preservation_services/fixity_check_service_spec.rb' -# Offense count: 4 +# Offense count: 9 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: both, prefix, postfix Style/NegatedIf: Exclude: + - 'lib/longleaf/candidates/file_selector.rb' - 'lib/longleaf/candidates/service_candidate_filesystem_iterator.rb' - - 'lib/longleaf/cli.rb' + - 'lib/longleaf/commands/reindex_command.rb' + - 'lib/longleaf/events/preserve_event.rb' + - 'lib/longleaf/indexing/sequel_index_driver.rb' + - 'lib/longleaf/preservation_services/file_check_service.rb' - 'lib/longleaf/preservation_services/rsync_replication_service.rb' - 'lib/longleaf/services/service_class_cache.rb' -# Offense count: 1 +# Offense count: 2 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, MinBodyLength. # SupportedStyles: skip_modifier_ifs, always Style/Next: Exclude: + - 'lib/longleaf/indexing/sequel_index_driver.rb' - 'lib/longleaf/services/storage_location_validator.rb' -# Offense count: 3 +# Offense count: 5 # Cop supports --auto-correct. # Configuration parameters: AutoCorrect, EnforcedStyle, IgnoredMethods. # SupportedStyles: predicate, comparison Style/NumericPredicate: Exclude: - 'spec/**/*' - - 'lib/longleaf/candidates/service_candidate_filesystem_iterator.rb' + - 'lib/longleaf/commands/reindex_command.rb' - 'lib/longleaf/events/event_status_tracking.rb' + - 'lib/longleaf/indexing/sequel_index_driver.rb' -# Offense count: 3 +# Offense count: 8 # Cop supports --auto-correct. # Configuration parameters: PreferredDelimiters. Style/PercentLiteralDelimiters: Exclude: - 'lib/longleaf/cli.rb' - - 'longleaf.gemspec' + - 'spec/features/file_check_feature_spec.rb' + - 'spec/features/fixity_check_feature_spec.rb' # Offense count: 2 # Cop supports --auto-correct. Style/PerlBackrefs: Exclude: - 'lib/longleaf/helpers/service_date_helper.rb' -# Offense count: 72 +# Offense count: 93 # Cop supports --auto-correct. # Configuration parameters: . # SupportedStyles: compact, exploded Style/RaiseArgs: EnforcedStyle: compact -# Offense count: 2 +# Offense count: 3 # Cop supports --auto-correct. Style/RedundantBegin: Exclude: - 'lib/longleaf/cli.rb' - 'lib/longleaf/services/application_config_deserializer.rb' -# Offense count: 1 +# Offense count: 11 # Cop supports --auto-correct. Style/RedundantParentheses: Exclude: + - 'spec/features/metadata_indexing_spec.rb' + - 'spec/features/reindex_command_spec.rb' - 'spec/longleaf/models/metadata_record_spec.rb' -# Offense count: 6 +# Offense count: 9 # Cop supports --auto-correct. # Configuration parameters: AllowMultipleReturnValues. Style/RedundantReturn: Exclude: - - 'lib/longleaf/preservation_services/fixity_check_service.rb' + - 'lib/longleaf/candidates/registered_file_selector.rb' + - 'lib/longleaf/helpers/digest_helper.rb' + - 'lib/longleaf/indexing/sequel_index_driver.rb' - 'lib/longleaf/specs/file_helpers.rb' -# Offense count: 3 +# Offense count: 1 # Cop supports --auto-correct. +Style/RedundantSelf: + Exclude: + - 'lib/longleaf/services/metadata_serializer.rb' + +# Offense count: 21 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle, AllowInnerSlashes. +# SupportedStyles: slashes, percent_r, mixed +Style/RegexpLiteral: + Exclude: + - 'lib/longleaf/preservation_services/rsync_replication_service.rb' + - 'spec/features/file_check_feature_spec.rb' + - 'spec/features/fixity_check_feature_spec.rb' + - 'spec/longleaf/logging/redirecting_logger_spec.rb' + +# Offense count: 9 +# Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle. +# SupportedStyles: implicit, explicit +Style/RescueStandardError: + Exclude: + - 'lib/longleaf/commands/deregister_command.rb' + - 'lib/longleaf/commands/preserve_command.rb' + - 'lib/longleaf/commands/register_command.rb' + - 'lib/longleaf/commands/reindex_command.rb' + - 'lib/longleaf/commands/validate_config_command.rb' + - 'lib/longleaf/commands/validate_metadata_command.rb' + - 'lib/longleaf/services/application_config_deserializer.rb' + - 'lib/longleaf/services/metadata_deserializer.rb' + +# Offense count: 1 +# Cop supports --auto-correct. # Configuration parameters: ConvertCodeThatCanStartToReturnNil, Whitelist. # Whitelist: present?, blank?, presence, try, try! Style/SafeNavigation: Exclude: - - 'lib/longleaf/cli.rb' - - 'lib/longleaf/services/metadata_deserializer.rb' - - 'spec/longleaf/candidates/service_candidate_filesystem_iterator_spec.rb' + - 'lib/longleaf/services/metadata_serializer.rb' # Offense count: 2 # Cop supports --auto-correct. Style/SelfAssignment: Exclude: - 'lib/longleaf/logging/redirecting_logger.rb' - 'lib/longleaf/preservation_services/rsync_replication_service.rb' -# Offense count: 1 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle. -# SupportedStyles: single_quotes, double_quotes -Style/StringLiteralsInInterpolation: - Exclude: - - 'lib/longleaf/preservation_services/rsync_replication_service.rb' - # Offense count: 3 # Cop supports --auto-correct. Style/UnneededInterpolation: Exclude: - 'lib/longleaf/logging/redirecting_logger.rb' -# Offense count: 3 +# Offense count: 1 # Cop supports --auto-correct. Style/UnneededPercentQ: Exclude: - 'lib/longleaf/specs/file_helpers.rb' - - 'longleaf.gemspec' -# Offense count: 1 +# Offense count: 2 # Cop supports --auto-correct. Style/WhileUntilDo: Exclude: - 'lib/longleaf/candidates/file_selector.rb' + - 'lib/longleaf/candidates/registered_file_selector.rb' -# Offense count: 1 +# Offense count: 33 # Cop supports --auto-correct. -Style/ZeroLengthPredicate: - Exclude: - - 'lib/longleaf/candidates/service_candidate_filesystem_iterator.rb' +# Configuration parameters: EnforcedStyle, MinSize, WordRegex. +# SupportedStyles: percent, brackets +Style/WordArray: + Enabled: false