lib/logstash/inputs/snmp/base_client.rb in logstash-input-snmp-0.1.0.beta5 vs lib/logstash/inputs/snmp/base_client.rb in logstash-input-snmp-1.0.0

@@ -1,8 +1,10 @@
 require "java"
 require "logstash-input-snmp_jars.rb"
 
+require "logstash/util/loggable"
+
 java_import "org.snmp4j.CommunityTarget"
 java_import "org.snmp4j.PDU"
 java_import "org.snmp4j.ScopedPDU"
 java_import "org.snmp4j.Snmp"
 java_import "org.snmp4j.Target"
@@ -23,10 +25,11 @@
 module LogStash
   class SnmpClientError < StandardError
   end
 
   class BaseSnmpClient
+    include LogStash::Util::Loggable
 
     def initialize(protocol, address, port, retries, timeout, mib)
       transport = case protocol.to_s
         when "udp"
           DefaultUdpTransportMapping.new
@@ -122,13 +125,15 @@
           variable.toString
         when BER::NULL
           NULL_STRING
         when BER::OPAQUE
           variable.toString
-        when BER::NOSUCHOBJECT
-          "Error: No Such Instance currently exists at this OID"
+        when BER::NOSUCHOBJECT, BER::NOSUCHINSTANCE
+          "error: no such instance currently exists at this OID"
         else
-          raise(SnmpClientError, "unknown variable syntax #{variable_syntax}, #{variable.getSyntaxString}")
+          msg = "error: unknown variable syntax #{variable_syntax}, #{variable.getSyntaxString}"
+          logger.error(msg)
+          msg
       end
     end
 
 
     def parse_version(version)