test/better_test.rb in logger-better-0.1.0 vs test/better_test.rb in logger-better-0.1.1

@@ -1,52 +1,54 @@
 require_relative 'test_helper'
 require 'logger/better'
 require 'stringio'
 
 class BetterTest < MiniTest::Unit::TestCase
-  def test_uses_the_iso_8601_times
-    formatter = Logger::Formatter.new
+  attr_reader :formatter
 
+  def setup
+    @formatter = Logger::Formatter.new
+  end
+
+  def test_uses_utc_iso_8601_times
     time = Time.now
     log = formatter.call 'info', time, 'app', 'hi'
-    assert_includes log, time.iso8601
+    assert_includes log, time.utc.iso8601
   end
 
   def test_starts_with_the_time
-    formatter = Logger::Formatter.new
-
     time = Time.now
     log = formatter.call 'info', time, 'app', 'hi'
     assert_equal 0, log.index(time.iso8601)
   end
 
   def test_progname_comes_after_time
-    formatter = Logger::Formatter.new
-
     time = Time.now
     log = formatter.call 'info', time, 'app', 'hi'
     assert_before log, 'app', time.iso8601
   end
 
   def test_pid_comes_after_progname
-    formatter = Logger::Formatter.new
-
     log = formatter.call 'info', Time.now, 'app', 'hi'
     assert_before log, $$.to_s, 'app'
   end
 
   def test_level_comes_after_progname
-    formatter = Logger::Formatter.new
-
     log = formatter.call 'info', Time.now, 'app', 'hi'
     assert_before log, 'info',  $$.to_s
   end
 
   def test_message_comes_last
-    formatter = Logger::Formatter.new
-
     log = formatter.call 'info', Time.now, 'app', 'hi'
     assert_before log, 'hi', 'info'
+  end
+
+  def test_removes_extra_new_lines_from_end_of_message
+    message = "!\n\n"
+
+    log = formatter.call 'info', Time.now, 'app', message
+    # strip here because all lines will have a new line.
+    assert_equal '!', log.strip[-1]
   end
 
   def test_can_set_level_with_symbol
     logger = Logger.new StringIO.new