lib/locker/label.rb in lita-locker-1.0.10 vs lib/locker/label.rb in lita-locker-1.1.0

@@ -1,5 +1,7 @@
+# frozen_string_literal: true
+
 # Locker subsystem
 module Locker
   # Label helpers
   module Label
     # Proper Resource class
@@ -38,11 +40,11 @@
         l
       end
 
       def self.delete(key)
         raise 'Unknown label key' unless Label.exists?(key)
-        %w(state, owner_id, membership, wait_queue, journal, observer_ids).each do |item|
+        %w[state owner_id membership wait_queue journal observer_ids].each do |item|
           redis.del("label:#{key}:#{item}")
         end
         redis.srem('label-list', Label.normalize(key))
       end
 
@@ -91,11 +93,11 @@
           end
         end
         log('Unlocked')
 
         # FIXME: Possible race condition where resources become unavailable between unlock and relock
-        if wait_queue.count > 0
+        if wait_queue.count.positive?
           next_user = wait_queue.shift
           lock!(next_user)
         end
         true
       end
@@ -205,12 +207,10 @@
       msg = failed(t('label.dependency')) + "\n"
       deps = []
       l = Label.new(name)
       l.membership.each do |resource_name|
         resource = Locker::Resource::Resource.new(resource_name)
-        if resource.state.value == 'locked'
-          deps.push "#{resource_name} - #{resource.owner.name}"
-        end
+        deps.push "#{resource_name} - #{resource.owner.name}" if resource.state.value == 'locked'
       end
       msg += deps.join("\n")
       msg
     end
   end