github_commits_spec.rb in lita-github-commits-0.2.5

- old
+ new

@@ -21,73 +21,153 @@
     let(:params) { double("Hash") }
 
     context "request with commits" do
       before do
         Lita.config.handlers.github_commits.repos["octokitty/testing"] = "#baz"
-        allow(params).to receive(:[]).with("payload").and_return(valid_payload)
+        allow(request).to receive(:body).and_return(valid_payload)
       end
 
       it "sends a notification message to the applicable rooms" do
         expect(robot).to receive(:send_message) do |target, message|
           expect(target.room).to eq("#baz")
           expect(message).to eq(<<-RESPONSE.chomp
 [GitHub] Got 3 new commits from Garen Torikian on octokitty/testing on the master branch
-  * Test
-  * This is me testing the windows client.
-  * Rename madame-bovary.txt to words/madame-bovary.txt
+  * c441029: Test
+  * 36c5f22: This is me testing the windows client.
+  * 1481a2d: Rename madame-bovary.txt to words/madame-bovary.txt
                                 RESPONSE
                                )
         end
+        expect(subject.redis).to receive(:setex).exactly(3).times
         subject.receive(request, response)
       end
     end
 
     context "request with one commit" do
       before do
         Lita.config.handlers.github_commits.repos["octokitty/testing"] = "#baz"
-        allow(params).to receive(:[]).with("payload").and_return(
-          valid_payload_one_commit)
+        Lita.config.handlers.github_commits.remember_commits_for = 1
+        allow(request).to receive(:body).and_return(valid_payload_one_commit)
       end
 
       it "sends a singular commit notification message to the applicable rooms" do
         expect(robot).to receive(:send_message) do |target, message|
           expect(target.room).to eq("#baz")
           expect(message).to eq(<<-RESPONSE.chomp
 [GitHub] Got 1 new commit from Garen Torikian on octokitty/testing on the master branch
-  * Test
+  * c441029: Test
                                 RESPONSE
                                )
         end
+        expect(subject.redis).to receive(:setex).once
         subject.receive(request, response)
       end
+
+      it "stores the message to redis with ttl" do
+        expect(subject.redis).to receive(:setex).once.with(Lita::Handlers::GithubCommits::REDIS_KEY_PREFIX + "c441029",86400,anything)
+        subject.receive(request, response)
+      end
+
+      it { is_expected.to route_command("zzcommit/1234567").to(:check_for_commit) }
+      it { is_expected.to route_command("abf commit/1234567").to(:check_for_commit) }
+      it { is_expected.to route_command("__commit/abcdef1?").to(:check_for_commit) }
+      it { is_expected.to_not route_command("commit/").to(:check_for_commit) }
+      it { is_expected.to_not route_command("commit/123456").to(:check_for_commit) }
+      it { is_expected.to_not route_command("commit/ornottocommit").to(:check_for_commit) }
+
+
+      it "stores the message to redis and can retrieve it from redis" do
+        subject.receive(request, response)
+        expect(subject.redis.ttl(Lita::Handlers::GithubCommits::REDIS_KEY_PREFIX + "c441029")).to be 
+        expect(subject.redis.get(Lita::Handlers::GithubCommits::REDIS_KEY_PREFIX + "c441029")).to eq first_commit.merge({:branch=>"master"}).to_json
+        expect(subject.redis.get(Lita::Handlers::GithubCommits::REDIS_KEY_PREFIX + "c44102")).to be nil
+      end
     end
 
+    context "request without memory" do
+      before do
+        Lita.config.handlers.github_commits.repos["octokitty/testing"] = "#baz"
+        Lita.config.handlers.github_commits.remember_commits_for = 0
+        allow(request).to receive(:body).and_return(valid_payload_one_commit)
+      end
+
+      it "stores does not store the message to redis" do
+        expect(subject.redis).to receive(:setex).never
+        subject.receive(request, response)
+      end
+    end
+
+    context "request with signature" do
+      before do
+        Lita.config.handlers.github_commits.repos["octokitty/testing"] = "#baz"
+        Lita.config.handlers.github_commits.remember_commits_for = 1
+        Lita.config.handlers.github_commits.github_webhook_secret = "something"
+        allow(request).to receive(:body).and_return(valid_payload_one_commit)
+      end
+
+      it "stores does not store the message to redis" do
+        expect(subject.redis).to receive(:setex).never
+        subject.receive(request, response)
+      end
+    end
+
     context "request with commits" do
       before do
         Lita.config.handlers.github_commits.repos["octokitty/testing"] = "#baz"
-        allow(params).to receive(:[]).with("payload").and_return(valid_payload_diff_committer)
+        allow(request).to receive(:body).and_return(valid_payload_diff_committer)
       end
 
       it "sends a notification message to the applicable rooms" do
         expect(robot).to receive(:send_message) do |target, message|
           expect(message).to eq(<<-RESPONSE.chomp
 [GitHub] Got 3 new commits authored by Garen Torikian and committed by Repository Owner on octokitty/testing on the master branch
-  * Test
-  * This is me testing the windows client.
-  * Rename madame-bovary.txt to words/madame-bovary.txt
+  * c441029: Test
+  * 36c5f22: This is me testing the windows client.
+  * 1481a2d: Rename madame-bovary.txt to words/madame-bovary.txt
                                 RESPONSE
                                )
         end
         subject.receive(request, response)
       end
     end
 
+    context "request with commits on a repo with no room" do
+      before do
+        Lita.config.handlers.github_commits.repos["octokitty/testing"] = ""
+        allow(request).to receive(:body).and_return(valid_payload_diff_committer)
+      end
 
+      it "it should not send messages on webhook requests" do
+        expect(robot).not_to receive(:send_message) 
+        subject.receive(request, response)
+      end
+
+      it "it should respond to a previously unseen commit if its a command" do
+        send_command("stuff commit/36c5f2243ed24de5 stuff")
+        expect(replies).to include("[GitHub] Sorry Boss, I can't find that commit")
+      end
+
+      it "it should not respond to a previously unseen commit if its not a command" do
+        send_message("github commit/36c5f2243ed24de5")
+        expect(replies).to eq []
+      end
+
+      it "it should respond to a previously seen commit" do
+        subject.receive(request, response)
+        send_message("do you know about commit/36c5f2243ed24de5?")
+        expect(replies).to include(a_string_starting_with("[GitHub] Commit 36c5f22: This is me testing the windows client.")) 
+        #expect(replies).to include(a_string_starting_with("[GitHub] Commit 36c5f22 committed by Repository Owner on branch master at")) 
+        #expect(replies).to include(a_string_ending_with("Files Modified\n  README.md\n\nMore info https://github.com/octokitty/testing/commit/36c5f2243ed24de58284a96f2a643bed8c028658"))
+      end
+    end
+
+
     context "create payload" do
       before do
         Lita.config.handlers.github_commits.repos["octokitty/testing"] = "#baz"
         allow(params).to receive(:[]).with("payload").and_return(created_payload)
+        allow(request).to receive(:body).and_return(created_payload)
       end
 
       it "sends a notification message to the applicable rooms" do
         expect(robot).to receive(:send_message) do |target, message|
           expect(target.room).to eq("#baz")
@@ -99,11 +179,11 @@
 
 
     context "delete payload" do
       before do
         Lita.config.handlers.github_commits.repos["octokitty/testing"] = "#baz"
-        allow(params).to receive(:[]).with("payload").and_return(deleted_payload)
+        allow(request).to receive(:body).and_return(deleted_payload)
       end
 
       it "sends a notification message to the applicable rooms" do
         expect(robot).to receive(:send_message) do |target, message|
           expect(target.room).to eq("#baz")
@@ -115,26 +195,26 @@
 
 
     context "bad payload" do
       before do
         Lita.config.handlers.github_commits.repos["octokitty/testing"] = "#baz"
-        allow(params).to receive(:[]).with("payload").and_return("yaryary")
+        allow(request).to receive(:body).and_return("yaryary")
       end
 
       it "sends a notification message to the applicable rooms" do
-        expect(Lita.logger).to receive(:error) do |error|
-          expect(error).to include("Could not parse JSON payload from Github")
+        expect(Lita.logger).to receive(:warn) do |warn|
+          expect(warn).to include("Could not parse JSON payload from Github")
         end
         subject.receive(request, response)
       end
     end
 
 
     context "ping event" do
       before do
         Lita.config.handlers.github_commits.repos["octokitty/testing"] = "#baz"
-        allow(params).to receive(:[]).with("payload").and_return(ping_payload)
+        allow(request).to receive(:body).and_return(ping_payload)
         allow(request).to receive(:env).and_return({"HTTP_X_GITHUB_EVENT" => "ping"})
       end
 
       it "handles the ping event" do
         expect(Lita.logger).to_not receive(:error)
@@ -144,11 +224,11 @@
     end
 
     context "unknown event" do
       before do
         Lita.config.handlers.github_commits.repos["octokitty/testing"] = "#baz"
-        allow(params).to receive(:[]).with("payload").and_return(ping_payload)
+        allow(request).to receive(:body).and_return(ping_payload)
         allow(request).to receive(:env).and_return({"HTTP_X_GITHUB_EVENT" => "fakefake"})
       end
 
       it "handles the ping event" do
         expect(Lita.logger).to_not receive(:error)
@@ -158,10 +238,10 @@
     end
 
 
     context "improper config" do
       before do
-        allow(params).to receive(:[]).with("payload").and_return(deleted_payload)
+        allow(request).to receive(:body).and_return(deleted_payload)
       end
 
       it "sends a notification message to the applicable rooms" do
         expect(Lita.logger).to receive(:warn) do |warning|
           expect(warning).to include("Notification from GitHub Commits for unconfigured project")